Add descriptions for private repo public access settings and improve the UI (#34057)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

options/locale/locale_en-US.ini

@@ -2138,6 +2138,11 @@ settings = Settings
 settings.desc = Settings is where you can manage the settings for the repository
 settings.options = Repository
 settings.public_access = Public Access
+settings.public_access_desc = Configure public visitor's access permissions to override the defaults of this repository.
+settings.public_access.docs.not_set = Not Set: no extra public access permission. The visitor's permission follows the repository's visibility and member permissions.
+settings.public_access.docs.anonymous_read = Anonymous Read: users who are not logged in can access the unit with read permission.
+settings.public_access.docs.everyone_read = Everyone Read: all logged-in users can access the unit with read permission. Read permission of issues/pull-requests units also means users can create new issues/pull-requests.
+settings.public_access.docs.everyone_write = Everyone Write: all logged-in users have write permission to the unit. Only Wiki unit supports this permission.
 settings.collaboration = Collaborators
 settings.collaboration.admin = Administrator
 settings.collaboration.write = Write

templates/repo/settings/public_access.tmpl

@@ -1,5 +1,12 @@
 {{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings")}}
 <div class="repo-setting-content">
+	<h4 class="ui top attached header">
+		{{ctx.Locale.Tr "repo.settings.public_access"}}
+	</h4>
+	<div class="ui attached segment">
+		<p>
+			{{ctx.Locale.Tr "repo.settings.public_access_desc"}}
+		</p>
 		{{$paNotSet := "not-set"}}
 		{{$paAnonymousRead := "anonymous-read"}}
 		{{$paEveryoneRead := "everyone-read"}}
@@ -7,13 +14,16 @@
 		<form class="ui form" method="post">
 			{{.CsrfTokenHtml}}
 			<table class="ui table unstackable tw-my-2">
+				<thead>
 					<tr>
-				<th></th>
-				<th>{{ctx.Locale.Tr "settings.permission_not_set"}}</th>
-				<th>{{ctx.Locale.Tr "settings.permission_anonymous_read"}}</th>
-				<th>{{ctx.Locale.Tr "settings.permission_everyone_read"}}</th>
-				<th>{{ctx.Locale.Tr "settings.permission_everyone_write"}}</th>
+						<th>{{ctx.Locale.Tr "units.unit"}}</th>
+						<th class="tw-text-center">{{ctx.Locale.Tr "settings.permission_not_set"}}</th>
+						<th class="tw-text-center">{{ctx.Locale.Tr "settings.permission_anonymous_read"}}</th>
+						<th class="tw-text-center">{{ctx.Locale.Tr "settings.permission_everyone_read"}}</th>
+						<th class="tw-text-center">{{ctx.Locale.Tr "settings.permission_everyone_write"}}</th>
 					</tr>
+				</thead>
+				<tbody>
 				{{range $ua := .RepoUnitPublicAccesses}}
 					<tr>
 						<td>{{$ua.DisplayName}}</td>
@@ -29,8 +39,16 @@
 						</td>
 					</tr>
 				{{end}}
+				</tbody>
 			</table>
+			<ul class="tw-my-3 tw-pl-5 tw-flex tw-flex-col tw-gap-3">
+				<li>{{ctx.Locale.Tr "repo.settings.public_access.docs.not_set"}}</li>
+				<li>{{ctx.Locale.Tr "repo.settings.public_access.docs.anonymous_read"}}</li>
+				<li>{{ctx.Locale.Tr "repo.settings.public_access.docs.everyone_read"}}</li>
+				<li>{{ctx.Locale.Tr "repo.settings.public_access.docs.everyone_write"}}</li>
+			</ul>
 			<button class="ui primary button {{if .GlobalForcePrivate}}disabled{{end}}">{{ctx.Locale.Tr "repo.settings.update_settings"}}</button>
 		</form>
+	</div>
 </div>
 {{template "repo/settings/layout_footer" .}}