Browse Source

Fix OAuth2 Error Code

Closes gh-10319
5.3.x
Josh Cummings 4 years ago
parent
commit
dc95d8d705
  1. 2
      oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/JwtTimestampValidator.java
  2. 2
      oauth2/oauth2-jose/src/test/java/org/springframework/security/oauth2/jwt/JwtTimestampValidatorTests.java

2
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/JwtTimestampValidator.java

@ -95,7 +95,7 @@ public final class JwtTimestampValidator implements OAuth2TokenValidator<Jwt> {
private OAuth2Error createOAuth2Error(String reason) { private OAuth2Error createOAuth2Error(String reason) {
logger.debug(reason); logger.debug(reason);
return new OAuth2Error( return new OAuth2Error(
OAuth2ErrorCodes.INVALID_REQUEST, OAuth2ErrorCodes.INVALID_TOKEN,
reason, reason,
"https://tools.ietf.org/html/rfc6750#section-3.1"); "https://tools.ietf.org/html/rfc6750#section-3.1");
} }

2
oauth2/oauth2-jose/src/test/java/org/springframework/security/oauth2/jwt/JwtTimestampValidatorTests.java

@ -27,6 +27,7 @@ import java.util.stream.Collectors;
import org.junit.Test; import org.junit.Test;
import org.springframework.security.oauth2.core.OAuth2Error; import org.springframework.security.oauth2.core.OAuth2Error;
import org.springframework.security.oauth2.core.OAuth2ErrorCodes;
import org.springframework.security.oauth2.core.OAuth2TokenValidatorResult; import org.springframework.security.oauth2.core.OAuth2TokenValidatorResult;
import org.springframework.security.oauth2.jose.jws.JwsAlgorithms; import org.springframework.security.oauth2.jose.jws.JwsAlgorithms;
@ -109,6 +110,7 @@ public class JwtTimestampValidatorTests {
result.getErrors().stream().map(OAuth2Error::getDescription).collect(Collectors.toList()); result.getErrors().stream().map(OAuth2Error::getDescription).collect(Collectors.toList());
assertThat(result.hasErrors()).isTrue(); assertThat(result.hasErrors()).isTrue();
assertThat(result.getErrors().iterator().next().getErrorCode()).isEqualTo(OAuth2ErrorCodes.INVALID_TOKEN);
assertThat(messages).contains("Jwt used before " + justOverOneDayFromNow); assertThat(messages).contains("Jwt used before " + justOverOneDayFromNow);
} }

Loading…
Cancel
Save