Remove ClientRegistrationRepository.findByClientId()

Fixes gh-4583

oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/registration/ClientRegistrationRepository.java

@@ -15,8 +15,6 @@
  */
 package org.springframework.security.oauth2.client.registration;
 
-import java.util.List;
-
 /**
  * A repository for OAuth 2.0 / OpenID Connect 1.0 {@link ClientRegistration}'s.
  *
@@ -33,8 +31,6 @@ import java.util.List;
  */
 public interface ClientRegistrationRepository {
 
-	List<ClientRegistration> findByClientId(String clientId);
-
 	ClientRegistration findByRegistrationId(String registrationId);
 
 }

oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/registration/InMemoryClientRegistrationRepository.java

@@ -21,7 +21,6 @@ import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.stream.Collectors;
 
 /**
  * A {@link ClientRegistrationRepository} that stores {@link ClientRegistration}(s) <i>in-memory</i>.
@@ -47,14 +46,6 @@ public final class InMemoryClientRegistrationRepository implements ClientRegistr
 		this.registrations = Collections.unmodifiableMap(registrationsMap);
 	}
 
-	@Override
-	public List<ClientRegistration> findByClientId(String clientId) {
-		Assert.hasText(clientId, "clientId cannot be empty");
-		return this.registrations.values().stream()
-			.filter(registration -> registration.getClientId().equals(clientId))
-			.collect(Collectors.toList());
-	}
-
 	@Override
 	public ClientRegistration findByRegistrationId(String registrationId) {
 		Assert.hasText(registrationId, "registrationId cannot be empty");