Browse Source

OPEN - issue SEC-637: Dependency on RequestUtils

http://jira.springframework.org/browse/SEC-637. Removed use of ServletRequestUtils in AbstractRememberMeServices
2.0.x
Luke Taylor 18 years ago
parent
commit
9d54c2d22b
  1. 19
      core/src/main/java/org/springframework/security/ui/rememberme/AbstractRememberMeServices.java

19
core/src/main/java/org/springframework/security/ui/rememberme/AbstractRememberMeServices.java

@ -19,7 +19,6 @@ import org.springframework.security.userdetails.UserDetailsChecker;
import org.springframework.security.userdetails.checker.AccountStatusUserDetailsChecker; import org.springframework.security.userdetails.checker.AccountStatusUserDetailsChecker;
import org.springframework.util.Assert; import org.springframework.util.Assert;
import org.springframework.util.StringUtils; import org.springframework.util.StringUtils;
import org.springframework.web.bind.ServletRequestUtils;
import javax.servlet.http.Cookie; import javax.servlet.http.Cookie;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
@ -232,14 +231,20 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
return true; return true;
} }
if (!ServletRequestUtils.getBooleanParameter(request, parameter, false)) { String paramValue = request.getParameter(parameter);
if (logger.isDebugEnabled()) {
logger.debug("Did not send remember-me cookie (principal did not set parameter '" + parameter + "')"); if (paramValue != null) {
} if (paramValue.equalsIgnoreCase("true") || paramValue.equalsIgnoreCase("on") ||
return false; paramValue.equalsIgnoreCase("yes") || paramValue.equals("1")) {
return true;
}
}
if (logger.isDebugEnabled()) {
logger.debug("Did not send remember-me cookie (principal did not set parameter '" + parameter + "')");
} }
return true; return false;
} }
/** /**

Loading…
Cancel
Save