From 9d54c2d22b67e95328fc2c6ec2a923de76f4bb0c Mon Sep 17 00:00:00 2001 From: Luke Taylor Date: Sun, 13 Apr 2008 12:53:01 +0000 Subject: [PATCH] OPEN - issue SEC-637: Dependency on RequestUtils http://jira.springframework.org/browse/SEC-637. Removed use of ServletRequestUtils in AbstractRememberMeServices --- .../AbstractRememberMeServices.java | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/core/src/main/java/org/springframework/security/ui/rememberme/AbstractRememberMeServices.java b/core/src/main/java/org/springframework/security/ui/rememberme/AbstractRememberMeServices.java index 8165f575f1..7aa8372230 100644 --- a/core/src/main/java/org/springframework/security/ui/rememberme/AbstractRememberMeServices.java +++ b/core/src/main/java/org/springframework/security/ui/rememberme/AbstractRememberMeServices.java @@ -19,7 +19,6 @@ import org.springframework.security.userdetails.UserDetailsChecker; import org.springframework.security.userdetails.checker.AccountStatusUserDetailsChecker; import org.springframework.util.Assert; import org.springframework.util.StringUtils; -import org.springframework.web.bind.ServletRequestUtils; import javax.servlet.http.Cookie; import javax.servlet.http.HttpServletRequest; @@ -232,14 +231,20 @@ public abstract class AbstractRememberMeServices implements RememberMeServices, return true; } - if (!ServletRequestUtils.getBooleanParameter(request, parameter, false)) { - if (logger.isDebugEnabled()) { - logger.debug("Did not send remember-me cookie (principal did not set parameter '" + parameter + "')"); - } - return false; + String paramValue = request.getParameter(parameter); + + if (paramValue != null) { + if (paramValue.equalsIgnoreCase("true") || paramValue.equalsIgnoreCase("on") || + paramValue.equalsIgnoreCase("yes") || paramValue.equals("1")) { + return true; + } + } + + if (logger.isDebugEnabled()) { + logger.debug("Did not send remember-me cookie (principal did not set parameter '" + parameter + "')"); } - return true; + return false; } /**