Browse Source

SimpleApplicationEventMulticaster just swallows event downcast exceptions

Issue: SPR-14846
(cherry picked from commit 13001b9)
pull/1257/head
Juergen Hoeller 9 years ago
parent
commit
fbad637235
  1. 5
      spring-context/src/main/java/org/springframework/context/event/SimpleApplicationEventMulticaster.java
  2. 52
      spring-context/src/test/java/org/springframework/context/event/ApplicationContextEventTests.java

5
spring-context/src/main/java/org/springframework/context/event/SimpleApplicationEventMulticaster.java

@ -166,9 +166,14 @@ public class SimpleApplicationEventMulticaster extends AbstractApplicationEventM @@ -166,9 +166,14 @@ public class SimpleApplicationEventMulticaster extends AbstractApplicationEventM
listener.onApplicationEvent(event);
}
catch (ClassCastException ex) {
if (ex.getMessage().startsWith(event.getClass().getName())) {
// Possibly a lambda-defined listener which we could not resolve the generic event type for
LogFactory.getLog(getClass()).debug("Non-matching event type for listener: " + listener, ex);
}
else {
throw ex;
}
}
}
}

52
spring-context/src/test/java/org/springframework/context/event/ApplicationContextEventTests.java

@ -379,6 +379,50 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen @@ -379,6 +379,50 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen
context.close();
}
@Test
public void anonymousClassAsListener() {
final Set<MyEvent> seenEvents = new HashSet<>();
StaticApplicationContext context = new StaticApplicationContext();
context.addApplicationListener(new ApplicationListener<MyEvent>() {
@Override
public void onApplicationEvent(MyEvent event) {
seenEvents.add(event);
}
});
context.refresh();
MyEvent event1 = new MyEvent(context);
context.publishEvent(event1);
context.publishEvent(new MyOtherEvent(context));
MyEvent event2 = new MyEvent(context);
context.publishEvent(event2);
assertSame(2, seenEvents.size());
assertTrue(seenEvents.contains(event1));
assertTrue(seenEvents.contains(event2));
context.close();
}
@Test
public void lambdaAsListener() {
final Set<MyEvent> seenEvents = new HashSet<>();
StaticApplicationContext context = new StaticApplicationContext();
ApplicationListener<MyEvent> listener = seenEvents::add;
context.addApplicationListener(listener);
context.refresh();
MyEvent event1 = new MyEvent(context);
context.publishEvent(event1);
context.publishEvent(new MyOtherEvent(context));
MyEvent event2 = new MyEvent(context);
context.publishEvent(event2);
assertSame(2, seenEvents.size());
assertTrue(seenEvents.contains(event1));
assertTrue(seenEvents.contains(event2));
context.close();
}
@Test
public void beanPostProcessorPublishesEvents() {
GenericApplicationContext context = new GenericApplicationContext();
@ -415,7 +459,7 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen @@ -415,7 +459,7 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen
public static class MyOrderedListener1 implements ApplicationListener<ApplicationEvent>, Ordered {
public final Set<ApplicationEvent> seenEvents = new HashSet<ApplicationEvent>();
public final Set<ApplicationEvent> seenEvents = new HashSet<>();
@Override
public void onApplicationEvent(ApplicationEvent event) {
@ -459,7 +503,7 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen @@ -459,7 +503,7 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen
public static class MyPayloadListener implements ApplicationListener<PayloadApplicationEvent> {
public final Set<Object> seenPayloads = new HashSet<Object>();
public final Set<Object> seenPayloads = new HashSet<>();
@Override
public void onApplicationEvent(PayloadApplicationEvent event) {
@ -470,7 +514,7 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen @@ -470,7 +514,7 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen
public static class MyNonSingletonListener implements ApplicationListener<ApplicationEvent> {
public static final Set<ApplicationEvent> seenEvents = new HashSet<ApplicationEvent>();
public static final Set<ApplicationEvent> seenEvents = new HashSet<>();
@Override
public void onApplicationEvent(ApplicationEvent event) {
@ -482,7 +526,7 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen @@ -482,7 +526,7 @@ public class ApplicationContextEventTests extends AbstractApplicationEventListen
@Order(5)
public static class MyOrderedListener3 implements ApplicationListener<ApplicationEvent> {
public final Set<ApplicationEvent> seenEvents = new HashSet<ApplicationEvent>();
public final Set<ApplicationEvent> seenEvents = new HashSet<>();
@Override
public void onApplicationEvent(ApplicationEvent event) {

Loading…
Cancel
Save