Browse Source

Apply Checkstyle MethodParamPadCheck module

This commit also fixes its violations.

Closes gh-34173
pull/34398/head
Johnny Lim 12 months ago committed by Sébastien Deleuze
parent
commit
6d86b23fbe
  1. 4
      spring-context/src/test/java/org/springframework/context/event/ApplicationListenerMethodAdapterTests.java
  2. 4
      spring-core/src/test/java/org/springframework/aot/generate/GeneratedClassesTests.java
  3. 1
      src/checkstyle/checkstyle.xml

4
spring-context/src/test/java/org/springframework/context/event/ApplicationListenerMethodAdapterTests.java

@ -213,8 +213,8 @@ class ApplicationListenerMethodAdapterTests extends AbstractApplicationEventList
@Test @Test
void invokeListenerWithWrongGenericPayload() { void invokeListenerWithWrongGenericPayload() {
Method method = ReflectionUtils.findMethod Method method = ReflectionUtils.findMethod(
(SampleEvents.class, "handleGenericStringPayload", EntityWrapper.class); SampleEvents.class, "handleGenericStringPayload", EntityWrapper.class);
EntityWrapper<Integer> payload = new EntityWrapper<>(123); EntityWrapper<Integer> payload = new EntityWrapper<>(123);
invokeListener(method, new PayloadApplicationEvent<>(this, payload)); invokeListener(method, new PayloadApplicationEvent<>(this, payload));
verify(this.sampleEvents, times(0)).handleGenericStringPayload(any()); verify(this.sampleEvents, times(0)).handleGenericStringPayload(any());

4
spring-core/src/test/java/org/springframework/aot/generate/GeneratedClassesTests.java

@ -148,8 +148,8 @@ class GeneratedClassesTests {
"one", TestComponent.class, emptyTypeCustomizer); "one", TestComponent.class, emptyTypeCustomizer);
GeneratedClass generatedClass2 = this.generatedClasses.getOrAddForFeatureComponent( GeneratedClass generatedClass2 = this.generatedClasses.getOrAddForFeatureComponent(
"one", TestComponent.class, emptyTypeCustomizer); "one", TestComponent.class, emptyTypeCustomizer);
GeneratedClass generatedClass3 = prefixed.getOrAddForFeatureComponent GeneratedClass generatedClass3 = prefixed.getOrAddForFeatureComponent(
("one", TestComponent.class, emptyTypeCustomizer); "one", TestComponent.class, emptyTypeCustomizer);
GeneratedClass generatedClass4 = prefixed.getOrAddForFeatureComponent( GeneratedClass generatedClass4 = prefixed.getOrAddForFeatureComponent(
"one", TestComponent.class, emptyTypeCustomizer); "one", TestComponent.class, emptyTypeCustomizer);
assertThat(generatedClass1).isSameAs(generatedClass2).isNotSameAs(generatedClass3); assertThat(generatedClass1).isSameAs(generatedClass2).isNotSameAs(generatedClass3);

1
src/checkstyle/checkstyle.xml

@ -191,6 +191,7 @@
<module name="com.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheck"/> <module name="com.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheck"/>
<!-- Whitespace --> <!-- Whitespace -->
<module name="com.puppycrawl.tools.checkstyle.checks.whitespace.MethodParamPadCheck"/>
<module name="com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheck"/> <module name="com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheck"/>
<!-- Miscellaneous --> <!-- Miscellaneous -->

Loading…
Cancel
Save