GitHub-Spring
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Optimized use of JDBC 3.0 ParameterMetaData.getParameterType, caching information about drivers which do not support that feature 

Issue: SPR-11100
pull/425/merge
Juergen Hoeller 12 years ago
parent
26d143868f
commit
4c8a7899f2
2 changed files with 145 additions and 29 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 49
      spring-jdbc/src/main/java/org/springframework/jdbc/core/StatementCreatorUtils.java
  2. 117
      spring-jdbc/src/test/java/org/springframework/jdbc/core/StatementCreatorUtilsTests.java

49
spring-jdbc/src/main/java/org/springframework/jdbc/core/StatementCreatorUtils.java
Unescape View File

@ -28,8 +28,11 @@ import java.sql.Types;
import java.util.Arrays; import java.util.Arrays;
import java.util.Calendar; import java.util.Calendar;
import java.util.Collection; import java.util.Collection;
import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
@ -60,7 +63,10 @@ public abstract class StatementCreatorUtils {
private static final Log logger = LogFactory.getLog(StatementCreatorUtils.class); private static final Log logger = LogFactory.getLog(StatementCreatorUtils.class);
private static Map<Class<?>, Integer> javaTypeToSqlTypeMap = new HashMap<Class<?>, Integer>(32); static final Set<String> driversWithNoSupportForGetParameterType =
Collections.newSetFromMap(new ConcurrentHashMap<String, Boolean>(1));
private static final Map<Class<?>, Integer> javaTypeToSqlTypeMap = new HashMap<Class<?>, Integer>(32);
static { static {
/* JDBC 3.0 only - not compatible with e.g. MySQL at present /* JDBC 3.0 only - not compatible with e.g. MySQL at present
@ -219,19 +225,44 @@ public abstract class StatementCreatorUtils {
private static void setNull(PreparedStatement ps, int paramIndex, int sqlType, String typeName) throws SQLException { private static void setNull(PreparedStatement ps, int paramIndex, int sqlType, String typeName) throws SQLException {
if (sqlType == SqlTypeValue.TYPE_UNKNOWN) { if (sqlType == SqlTypeValue.TYPE_UNKNOWN) {
boolean useSetObject = false; boolean useSetObject = false;
sqlType = Types.NULL; Integer sqlTypeToUse = null;
DatabaseMetaData dbmd = null;
String jdbcDriverName = null;
boolean checkGetParameterType = true;
if (!driversWithNoSupportForGetParameterType.isEmpty()) {
try { try {
sqlType = ps.getParameterMetaData().getParameterType(paramIndex); dbmd = ps.getConnection().getMetaData();
jdbcDriverName = dbmd.getDriverName();
checkGetParameterType = !driversWithNoSupportForGetParameterType.contains(jdbcDriverName);
}
catch (Throwable ex) {
logger.debug("Could not check connection metadata", ex);
}
}
if (checkGetParameterType) {
try {
sqlTypeToUse = ps.getParameterMetaData().getParameterType(paramIndex);
} }
catch (Throwable ex) { catch (Throwable ex) {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug("JDBC 3.0 getParameterType call not supported - using fallback method instead: " + ex); logger.debug("JDBC 3.0 getParameterType call not supported - using fallback method instead: " + ex);
} }
}
}
if (sqlTypeToUse == null) {
// JDBC driver not compliant with JDBC 3.0 -> proceed with database-specific checks // JDBC driver not compliant with JDBC 3.0 -> proceed with database-specific checks
sqlTypeToUse = Types.NULL;
try { try {
DatabaseMetaData dbmd = ps.getConnection().getMetaData(); if (dbmd == null) {
dbmd = ps.getConnection().getMetaData();
}
if (jdbcDriverName == null) {
jdbcDriverName = dbmd.getDriverName();
}
if (checkGetParameterType) {
driversWithNoSupportForGetParameterType.add(jdbcDriverName);
}
String databaseProductName = dbmd.getDatabaseProductName(); String databaseProductName = dbmd.getDatabaseProductName();
String jdbcDriverName = dbmd.getDriverName();
if (databaseProductName.startsWith("Informix") || if (databaseProductName.startsWith("Informix") ||
jdbcDriverName.startsWith("Microsoft SQL Server")) { jdbcDriverName.startsWith("Microsoft SQL Server")) {
useSetObject = true; useSetObject = true;
@ -240,18 +271,18 @@ public abstract class StatementCreatorUtils {
jdbcDriverName.startsWith("jConnect") || jdbcDriverName.startsWith("jConnect") ||
jdbcDriverName.startsWith("SQLServer")|| jdbcDriverName.startsWith("SQLServer")||
jdbcDriverName.startsWith("Apache Derby")) { jdbcDriverName.startsWith("Apache Derby")) {
sqlType = Types.VARCHAR; sqlTypeToUse = Types.VARCHAR;
} }
} }
catch (Throwable ex2) { catch (Throwable ex) {
logger.debug("Could not check database or driver name", ex2); logger.debug("Could not check connection metadata", ex);
} }
} }
if (useSetObject) { if (useSetObject) {
ps.setObject(paramIndex, null); ps.setObject(paramIndex, null);
} }
else { else {
ps.setNull(paramIndex, sqlType); ps.setNull(paramIndex, sqlTypeToUse);
} }
} }
else if (typeName != null) { else if (typeName != null) {

117
spring-jdbc/src/test/java/org/springframework/jdbc/core/StatementCreatorUtilsTests.java
Unescape View File

@ -18,6 +18,7 @@ package org.springframework.jdbc.core;
import java.sql.Connection; import java.sql.Connection;
import java.sql.DatabaseMetaData; import java.sql.DatabaseMetaData;
import java.sql.ParameterMetaData;
import java.sql.PreparedStatement; import java.sql.PreparedStatement;
import java.sql.SQLException; import java.sql.SQLException;
import java.sql.Types; import java.sql.Types;
@ -26,6 +27,7 @@ import java.util.GregorianCalendar;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import static org.junit.Assert.*;
import static org.mockito.BDDMockito.*; import static org.mockito.BDDMockito.*;
/** /**
@ -41,46 +43,129 @@ public class StatementCreatorUtilsTests {
preparedStatement = mock(PreparedStatement.class); preparedStatement = mock(PreparedStatement.class);
} }
@Test public void testSetParameterValueWithNullAndType() throws SQLException { @Test
public void testSetParameterValueWithNullAndType() throws SQLException {
StatementCreatorUtils.setParameterValue(preparedStatement, 1, Types.VARCHAR, null, null); StatementCreatorUtils.setParameterValue(preparedStatement, 1, Types.VARCHAR, null, null);
verify(preparedStatement).setNull(1, Types.VARCHAR); verify(preparedStatement).setNull(1, Types.VARCHAR);
} }
@Test public void testSetParameterValueWithNullAndTypeName() throws SQLException { @Test
public void testSetParameterValueWithNullAndTypeName() throws SQLException {
StatementCreatorUtils.setParameterValue(preparedStatement, 1, Types.VARCHAR, "mytype", null); StatementCreatorUtils.setParameterValue(preparedStatement, 1, Types.VARCHAR, "mytype", null);
verify(preparedStatement).setNull(1, Types.VARCHAR, "mytype"); verify(preparedStatement).setNull(1, Types.VARCHAR, "mytype");
} }
@Test public void testSetParameterValueWithNullAndUnknownType() throws SQLException { @Test
public void testSetParameterValueWithNullAndUnknownType() throws SQLException {
StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null); StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null);
verify(preparedStatement).setNull(1, Types.NULL); verify(preparedStatement).setNull(1, Types.NULL);
} }
@Test @Test
public void testSetParameterValueWithNullAndUnknownTypeOnInformix() throws SQLException { public void testSetParameterValueWithNullAndUnknownTypeOnInformix() throws SQLException {
StatementCreatorUtils.driversWithNoSupportForGetParameterType.clear();
Connection con = mock(Connection.class); Connection con = mock(Connection.class);
DatabaseMetaData metaData = mock(DatabaseMetaData.class); DatabaseMetaData dbmd = mock(DatabaseMetaData.class);
given(preparedStatement.getConnection()).willReturn(con); given(preparedStatement.getConnection()).willReturn(con);
given(con.getMetaData()).willReturn(metaData); given(con.getMetaData()).willReturn(dbmd);
given(metaData.getDatabaseProductName()).willReturn("Informix Dynamic Server"); given(dbmd.getDatabaseProductName()).willReturn("Informix Dynamic Server");
given(metaData.getDriverName()).willReturn("Informix Driver"); given(dbmd.getDriverName()).willReturn("Informix Driver");
StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null); StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null);
verify(metaData).getDatabaseProductName(); verify(dbmd).getDatabaseProductName();
verify(metaData).getDriverName(); verify(dbmd).getDriverName();
verify(preparedStatement).setObject(1, null); verify(preparedStatement).setObject(1, null);
assertEquals(1, StatementCreatorUtils.driversWithNoSupportForGetParameterType.size());
} }
@Test public void testSetParameterValueWithNullAndUnknownTypeOnDerbyEmbedded() throws SQLException { @Test
public void testSetParameterValueWithNullAndUnknownTypeOnDerbyEmbedded() throws SQLException {
StatementCreatorUtils.driversWithNoSupportForGetParameterType.clear();
Connection con = mock(Connection.class); Connection con = mock(Connection.class);
DatabaseMetaData metaData = mock(DatabaseMetaData.class); DatabaseMetaData dbmd = mock(DatabaseMetaData.class);
given(preparedStatement.getConnection()).willReturn(con); given(preparedStatement.getConnection()).willReturn(con);
given(con.getMetaData()).willReturn(metaData); given(con.getMetaData()).willReturn(dbmd);
given(metaData.getDatabaseProductName()).willReturn("Apache Derby"); given(dbmd.getDatabaseProductName()).willReturn("Apache Derby");
given(metaData.getDriverName()).willReturn("Apache Derby Embedded Driver"); given(dbmd.getDriverName()).willReturn("Apache Derby Embedded Driver");
StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null); StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null);
verify(metaData).getDatabaseProductName(); verify(dbmd).getDatabaseProductName();
verify(metaData).getDriverName(); verify(dbmd).getDriverName();
verify(preparedStatement).setNull(1, Types.VARCHAR); verify(preparedStatement).setNull(1, Types.VARCHAR);
assertEquals(1, StatementCreatorUtils.driversWithNoSupportForGetParameterType.size());
}
@Test
public void testSetParameterValueWithNullAndGetParameterTypeWorking() throws SQLException {
StatementCreatorUtils.driversWithNoSupportForGetParameterType.clear();
ParameterMetaData pmd = mock(ParameterMetaData.class);
given(preparedStatement.getParameterMetaData()).willReturn(pmd);
given(pmd.getParameterType(1)).willReturn(Types.SMALLINT);
StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null);
verify(pmd).getParameterType(1);
verify(preparedStatement, never()).getConnection();
verify(preparedStatement).setNull(1, Types.SMALLINT);
assertTrue(StatementCreatorUtils.driversWithNoSupportForGetParameterType.isEmpty());
}
@Test
public void testSetParameterValueWithNullAndGetParameterTypeWorkingButNotForOtherDriver() throws SQLException {
StatementCreatorUtils.driversWithNoSupportForGetParameterType.clear();
StatementCreatorUtils.driversWithNoSupportForGetParameterType.add("Oracle JDBC Driver");
Connection con = mock(Connection.class);
DatabaseMetaData dbmd = mock(DatabaseMetaData.class);
ParameterMetaData pmd = mock(ParameterMetaData.class);
given(preparedStatement.getConnection()).willReturn(con);
given(con.getMetaData()).willReturn(dbmd);
given(dbmd.getDriverName()).willReturn("Apache Derby Embedded Driver");
given(preparedStatement.getParameterMetaData()).willReturn(pmd);
given(pmd.getParameterType(1)).willReturn(Types.SMALLINT);
StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null);
verify(dbmd).getDriverName();
verify(pmd).getParameterType(1);
verify(preparedStatement).setNull(1, Types.SMALLINT);
assertEquals(1, StatementCreatorUtils.driversWithNoSupportForGetParameterType.size());
}
@Test
public void testSetParameterValueWithNullAndUnknownTypeAndGetParameterTypeNotWorking() throws SQLException {
StatementCreatorUtils.driversWithNoSupportForGetParameterType.clear();
Connection con = mock(Connection.class);
DatabaseMetaData dbmd = mock(DatabaseMetaData.class);
given(preparedStatement.getConnection()).willReturn(con);
given(con.getMetaData()).willReturn(dbmd);
given(dbmd.getDatabaseProductName()).willReturn("Apache Derby");
given(dbmd.getDriverName()).willReturn("Apache Derby Embedded Driver");
StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null);
verify(dbmd).getDatabaseProductName();
verify(dbmd).getDriverName();
verify(preparedStatement).setNull(1, Types.VARCHAR);
assertEquals(1, StatementCreatorUtils.driversWithNoSupportForGetParameterType.size());
reset(preparedStatement, con, dbmd);
ParameterMetaData pmd = mock(ParameterMetaData.class);
given(preparedStatement.getConnection()).willReturn(con);
given(con.getMetaData()).willReturn(dbmd);
given(preparedStatement.getParameterMetaData()).willReturn(pmd);
given(pmd.getParameterType(1)).willThrow(new SQLException("unsupported"));
given(dbmd.getDatabaseProductName()).willReturn("Informix Dynamic Server");
given(dbmd.getDriverName()).willReturn("Informix Driver");
StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null);
verify(pmd).getParameterType(1);
verify(dbmd).getDatabaseProductName();
verify(dbmd).getDriverName();
verify(preparedStatement).setObject(1, null);
assertEquals(2, StatementCreatorUtils.driversWithNoSupportForGetParameterType.size());
reset(preparedStatement, con, dbmd, pmd);
given(preparedStatement.getConnection()).willReturn(con);
given(con.getMetaData()).willReturn(dbmd);
given(dbmd.getDatabaseProductName()).willReturn("Informix Dynamic Server");
given(dbmd.getDriverName()).willReturn("Informix Driver");
StatementCreatorUtils.setParameterValue(preparedStatement, 1, SqlTypeValue.TYPE_UNKNOWN, null, null);
verify(preparedStatement, never()).getParameterMetaData();
verify(dbmd).getDatabaseProductName();
verify(dbmd).getDriverName();
verify(preparedStatement).setObject(1, null);
assertEquals(2, StatementCreatorUtils.driversWithNoSupportForGetParameterType.size());
} }
@Test @Test

Write Preview
Loading…
Cancel
Save