Browse Source

Use String.equals() in LiteralPathElement

pull/30169/head
James Yuzawa 3 years ago committed by Arjen Poutsma
parent
commit
2bc1aa7827
  1. 12
      spring-web/src/main/java/org/springframework/web/util/pattern/LiteralPathElement.java

12
spring-web/src/main/java/org/springframework/web/util/pattern/LiteralPathElement.java

@ -31,6 +31,8 @@ class LiteralPathElement extends PathElement {
private final char[] text; private final char[] text;
private final String textString;
private final int len; private final int len;
private final boolean caseSensitive; private final boolean caseSensitive;
@ -50,6 +52,7 @@ class LiteralPathElement extends PathElement {
this.text[i] = Character.toLowerCase(literalText[i]); this.text[i] = Character.toLowerCase(literalText[i]);
} }
} }
this.textString = new String(this.text);
} }
@ -70,10 +73,9 @@ class LiteralPathElement extends PathElement {
} }
if (this.caseSensitive) { if (this.caseSensitive) {
for (int i = 0; i < this.len; i++) { // This typically uses a JVM intrinsic
if (value.charAt(i) != this.text[i]) { if (!this.textString.equals(value)) {
return false; return false;
}
} }
} }
else { else {
@ -124,7 +126,7 @@ class LiteralPathElement extends PathElement {
@Override @Override
public String toString() { public String toString() {
return "Literal(" + String.valueOf(this.text) + ")"; return "Literal(" + this.textString + ")";
} }
} }

Loading…
Cancel
Save