Browse Source

Polishing.

Ternary ifs and less nesting.

Related: GH-3094
Original pull request: GH-2865
pull/3113/head
Oliver Drotbohm 2 years ago
parent
commit
b09c503480
No known key found for this signature in database
GPG Key ID: 9EB72C54FB72F2A7
  1. 13
      src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolver.java
  2. 13
      src/main/java/org/springframework/data/web/ReactivePageableHandlerMethodArgumentResolver.java

13
src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolver.java

@ -83,15 +83,12 @@ public class PageableHandlerMethodArgumentResolver extends PageableHandlerMethod @@ -83,15 +83,12 @@ public class PageableHandlerMethodArgumentResolver extends PageableHandlerMethod
Sort sort = sortResolver.resolveArgument(methodParameter, mavContainer, webRequest, binderFactory);
Pageable pageable = getPageable(methodParameter, page, pageSize);
if (sort.isSorted()) {
if (pageable.isPaged()) {
pageable = PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort);
}
else {
pageable = Pageable.unpaged(sort);
}
if (!sort.isSorted()) {
return pageable;
}
return pageable;
return pageable.isPaged()
? PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort)
: Pageable.unpaged(sort);
}
}

13
src/main/java/org/springframework/data/web/ReactivePageableHandlerMethodArgumentResolver.java

@ -78,15 +78,12 @@ public class ReactivePageableHandlerMethodArgumentResolver extends PageableHandl @@ -78,15 +78,12 @@ public class ReactivePageableHandlerMethodArgumentResolver extends PageableHandl
Sort sort = sortResolver.resolveArgumentValue(parameter, bindingContext, exchange);
Pageable pageable = getPageable(parameter, page, pageSize);
if (sort.isSorted()) {
if (pageable.isPaged()) {
pageable = PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort);
}
else {
pageable = Pageable.unpaged(sort);
}
if (!sort.isSorted()) {
return pageable;
}
return pageable;
return pageable.isPaged()
? PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort)
: Pageable.unpaged(sort);
}
}

Loading…
Cancel
Save