Browse Source

Avoid `Iterator` allocations when calling `Sort.isSorted()`.

Closes #2445
2.4.x
Mark Paluch 4 years ago
parent
commit
345e18c2ac
No known key found for this signature in database
GPG Key ID: 4406B84C1661DCD1
  1. 9
      src/main/java/org/springframework/data/domain/Sort.java
  2. 5
      src/main/java/org/springframework/data/querydsl/QSort.java

9
src/main/java/org/springframework/data/domain/Sort.java

@ -173,6 +173,11 @@ public class Sort implements Streamable<org.springframework.data.domain.Sort.Ord
return !isEmpty(); return !isEmpty();
} }
@Override
public boolean isEmpty() {
return orders.isEmpty();
}
public boolean isUnsorted() { public boolean isUnsorted() {
return !isSorted(); return !isSorted();
} }
@ -718,7 +723,11 @@ public class Sort implements Streamable<org.springframework.data.domain.Sort.Ord
.map(Order::by) // .map(Order::by) //
.map(Collections::singleton) // .map(Collections::singleton) //
.orElseGet(Collections::emptySet).iterator(); .orElseGet(Collections::emptySet).iterator();
}
@Override
public boolean isEmpty() {
return !recorded.getPropertyPath().isPresent();
} }
/* /*

5
src/main/java/org/springframework/data/querydsl/QSort.java

@ -104,6 +104,11 @@ public class QSort extends Sort implements Serializable {
return Order.by(targetElement.toString()).with(orderSpecifier.isAscending() ? Direction.ASC : Direction.DESC); return Order.by(targetElement.toString()).with(orderSpecifier.isAscending() ? Direction.ASC : Direction.DESC);
} }
@Override
public boolean isEmpty() {
return orderSpecifiers.isEmpty();
}
/** /**
* @return the orderSpecifier * @return the orderSpecifier
*/ */

Loading…
Cancel
Save