Browse Source

Merge branch '3.1.x'

Closes gh-37571
pull/37473/head
Moritz Halbritter 2 years ago
parent
commit
11ec9f95f6
  1. 3
      spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/config/StandardConfigDataLocationResolver.java
  2. 21
      spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/config/StandardConfigDataLocationResolverTests.java

3
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/config/StandardConfigDataLocationResolver.java

@ -228,6 +228,9 @@ public class StandardConfigDataLocationResolver
return Collections.singleton(reference); return Collections.singleton(reference);
} }
} }
if (configDataLocation.isOptional()) {
return Collections.emptySet();
}
throw new IllegalStateException("File extension is not known to any PropertySourceLoader. " throw new IllegalStateException("File extension is not known to any PropertySourceLoader. "
+ "If the location is meant to reference a directory, it must end in '/' or File.separator"); + "If the location is meant to reference a directory, it must end in '/' or File.separator");
} }

21
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/config/StandardConfigDataLocationResolverTests.java

@ -43,6 +43,7 @@ import static org.mockito.Mockito.mock;
* *
* @author Madhura Bhave * @author Madhura Bhave
* @author Phillip Webb * @author Phillip Webb
* @author Moritz Halbritter
*/ */
class StandardConfigDataLocationResolverTests { class StandardConfigDataLocationResolverTests {
@ -263,6 +264,26 @@ class StandardConfigDataLocationResolverTests {
assertThat(locations).isEmpty(); assertThat(locations).isEmpty();
} }
@Test
void resolveWhenOptionalAndLoaderIsUnknownShouldNotFail() {
ConfigDataLocation location = ConfigDataLocation.of("optional:some-unknown-loader:dummy.properties");
assertThatNoException().isThrownBy(() -> this.resolver.resolve(this.context, location));
}
@Test
void resolveWhenOptionalAndLoaderIsUnknownAndExtensionIsUnknownShouldNotFail() {
ConfigDataLocation location = ConfigDataLocation
.of("optional:some-unknown-loader:dummy.some-unknown-extension");
List<StandardConfigDataResource> locations = this.resolver.resolve(this.context, location);
assertThatNoException().isThrownBy(() -> this.resolver.resolve(this.context, location));
}
@Test
void resolveWhenOptionalAndExtensionIsUnknownShouldNotFail() {
ConfigDataLocation location = ConfigDataLocation.of("optional:file:dummy.some-unknown-extension");
assertThatNoException().isThrownBy(() -> this.resolver.resolve(this.context, location));
}
private String filePath(String... components) { private String filePath(String... components) {
return "file [" + String.join(File.separator, components) + "]"; return "file [" + String.join(File.separator, components) + "]";
} }

Loading…
Cancel
Save