Browse Source

Add device verification authentication context support

Previously, device consent handling did not provide a dedicated context
for device verification authentication flows. This commit introduces
OAuth2DeviceVerificationAuthenticationContext and updates related
providers and tests to enhance device authorization and consent flows.

Fixes gh-1965

Signed-off-by: Dinesh Gupta dineshgupta630@outlook.com
pull/2047/head
Dinesh Gupta 6 months ago
parent
commit
3b166b52a0
  1. 146
      oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/OAuth2DeviceVerificationAuthenticationContext.java
  2. 4
      oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2AuthenticationContext.java
  3. 48
      oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2DeviceVerificationAuthenticationProvider.java
  4. 34
      oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2DeviceVerificationAuthenticationProviderTests.java
  5. 2
      oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/config/annotation/web/configurers/OAuth2DeviceCodeGrantTests.java

146
oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/OAuth2DeviceVerificationAuthenticationContext.java

@ -0,0 +1,146 @@ @@ -0,0 +1,146 @@
/*
* Copyright 2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*/
package org.springframework.security.oauth2.server.authorization;
import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.Map;
import org.springframework.lang.Nullable;
import org.springframework.security.core.Authentication;
import org.springframework.security.oauth2.server.authorization.authentication.OAuth2AuthenticationContext;
import org.springframework.security.oauth2.server.authorization.authentication.OAuth2DeviceVerificationAuthenticationToken;
import org.springframework.security.oauth2.server.authorization.client.RegisteredClient;
import org.springframework.util.Assert;
/**
* An {@link OAuth2AuthenticationContext} that holds an
* {@link OAuth2DeviceVerificationAuthenticationToken} together with additional
* information and is used by {@code OAuth2DeviceVerificationAuthenticationProvider} when
* validating a Device Verification request, as well as determining whether authorization
* consent is required.
*
* @author Your Name
* @since 1.3.7
*/
public final class OAuth2DeviceVerificationAuthenticationContext implements OAuth2AuthenticationContext {
private final OAuth2DeviceVerificationAuthenticationToken authentication;
private final RegisteredClient registeredClient;
@Nullable
private final OAuth2Authorization authorization;
@Nullable
private final OAuth2AuthorizationConsent authorizationConsent;
private final Map<Object, Object> context;
@SuppressWarnings("unchecked")
@Override
public <T extends Authentication> T getAuthentication() {
return (T) this.authentication;
}
@Override
@Nullable
public <V> V get(Object key) {
return (V) this.context.get(key);
}
@Override
public boolean hasKey(Object key) {
return this.context.containsKey(key);
}
public RegisteredClient getRegisteredClient() {
return this.registeredClient;
}
@Nullable
public OAuth2Authorization getAuthorization() {
return this.authorization;
}
@Nullable
public OAuth2AuthorizationConsent getAuthorizationConsent() {
return this.authorizationConsent;
}
/* ======== Builder plumbing ======== */
private OAuth2DeviceVerificationAuthenticationContext(Builder builder) {
this.authentication = builder.authentication;
this.registeredClient = builder.registeredClient;
this.authorization = builder.authorization;
this.authorizationConsent = builder.authorizationConsent;
this.context = Collections.unmodifiableMap(new LinkedHashMap<>(builder.getContext()));
}
/**
* Returns a new {@link Builder} pre-initialised with the supplied authentication.
* @param authentication the {@link OAuth2DeviceVerificationAuthenticationToken}
* @return the {@link Builder} for further customisation
*/
public static Builder with(OAuth2DeviceVerificationAuthenticationToken authentication) {
return new Builder(authentication);
}
/**
* A builder for {@link OAuth2DeviceVerificationAuthenticationContext}.
*/
public static final class Builder extends
OAuth2AuthenticationContext.AbstractBuilder<OAuth2DeviceVerificationAuthenticationContext, Builder> {
private final OAuth2DeviceVerificationAuthenticationToken authentication;
private RegisteredClient registeredClient;
private OAuth2Authorization authorization;
private OAuth2AuthorizationConsent authorizationConsent;
private Builder(OAuth2DeviceVerificationAuthenticationToken authentication) {
super(authentication);
Assert.notNull(authentication, "authentication cannot be null");
this.authentication = authentication;
}
public Builder registeredClient(RegisteredClient registeredClient) {
this.registeredClient = registeredClient;
return this;
}
public Builder authorization(@Nullable OAuth2Authorization authorization) {
this.authorization = authorization;
return this;
}
public Builder authorizationConsent(@Nullable OAuth2AuthorizationConsent authorizationConsent) {
this.authorizationConsent = authorizationConsent;
return this;
}
@Override
public OAuth2DeviceVerificationAuthenticationContext build() {
Assert.notNull(this.registeredClient, "registeredClient cannot be null");
return new OAuth2DeviceVerificationAuthenticationContext(this);
}
@Override
protected Builder getThis() {
return this;
}
}
}

4
oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2AuthenticationContext.java

@ -89,12 +89,12 @@ public interface OAuth2AuthenticationContext extends Context { @@ -89,12 +89,12 @@ public interface OAuth2AuthenticationContext extends Context {
return (V) getContext().get(key);
}
protected Map<Object, Object> getContext() {
public Map<Object, Object> getContext() {
return this.context;
}
@SuppressWarnings("unchecked")
protected final B getThis() {
protected B getThis() {
return (B) this;
}

48
oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2DeviceVerificationAuthenticationProvider.java

@ -18,6 +18,7 @@ package org.springframework.security.oauth2.server.authorization.authentication; @@ -18,6 +18,7 @@ package org.springframework.security.oauth2.server.authorization.authentication;
import java.security.Principal;
import java.util.Base64;
import java.util.Set;
import java.util.function.Predicate;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@ -33,11 +34,8 @@ import org.springframework.security.oauth2.core.OAuth2AuthenticationException; @@ -33,11 +34,8 @@ import org.springframework.security.oauth2.core.OAuth2AuthenticationException;
import org.springframework.security.oauth2.core.OAuth2ErrorCodes;
import org.springframework.security.oauth2.core.OAuth2UserCode;
import org.springframework.security.oauth2.core.endpoint.OAuth2ParameterNames;
import org.springframework.security.oauth2.server.authorization.OAuth2Authorization;
import org.springframework.security.oauth2.server.authorization.OAuth2AuthorizationConsent;
import org.springframework.security.oauth2.server.authorization.OAuth2AuthorizationConsentService;
import org.springframework.security.oauth2.server.authorization.OAuth2AuthorizationService;
import org.springframework.security.oauth2.server.authorization.OAuth2TokenType;
import org.springframework.security.oauth2.core.oidc.OidcScopes;
import org.springframework.security.oauth2.server.authorization.*;
import org.springframework.security.oauth2.server.authorization.client.RegisteredClient;
import org.springframework.security.oauth2.server.authorization.client.RegisteredClientRepository;
import org.springframework.security.oauth2.server.authorization.context.AuthorizationServerContextHolder;
@ -78,6 +76,8 @@ public final class OAuth2DeviceVerificationAuthenticationProvider implements Aut @@ -78,6 +76,8 @@ public final class OAuth2DeviceVerificationAuthenticationProvider implements Aut
private final OAuth2AuthorizationConsentService authorizationConsentService;
private Predicate<OAuth2DeviceVerificationAuthenticationContext> authorizationConsentRequired = this::defaultAuthorizationConsentRequired;
/**
* Constructs an {@code OAuth2DeviceVerificationAuthenticationProvider} using the
* provided parameters.
@ -145,7 +145,14 @@ public final class OAuth2DeviceVerificationAuthenticationProvider implements Aut @@ -145,7 +145,14 @@ public final class OAuth2DeviceVerificationAuthenticationProvider implements Aut
OAuth2AuthorizationConsent currentAuthorizationConsent = this.authorizationConsentService
.findById(registeredClient.getId(), principal.getName());
if (requiresAuthorizationConsent(requestedScopes, currentAuthorizationConsent)) {
OAuth2DeviceVerificationAuthenticationContext ctx = OAuth2DeviceVerificationAuthenticationContext
.with(deviceVerificationAuthentication)
.registeredClient(registeredClient)
.authorization(authorization)
.authorizationConsent(currentAuthorizationConsent)
.build();
if (this.authorizationConsentRequired.test(ctx)) {
String state = DEFAULT_STATE_GENERATOR.generateKey();
authorization = OAuth2Authorization.from(authorization)
.principalName(principal.getName())
@ -201,6 +208,35 @@ public final class OAuth2DeviceVerificationAuthenticationProvider implements Aut @@ -201,6 +208,35 @@ public final class OAuth2DeviceVerificationAuthenticationProvider implements Aut
return OAuth2DeviceVerificationAuthenticationToken.class.isAssignableFrom(authentication);
}
public void setAuthorizationConsentRequired(
Predicate<OAuth2DeviceVerificationAuthenticationContext> authorizationConsentRequired) {
Assert.notNull(authorizationConsentRequired, "authorizationConsentRequired cannot be null");
this.authorizationConsentRequired = authorizationConsentRequired;
}
private boolean defaultAuthorizationConsentRequired(OAuth2DeviceVerificationAuthenticationContext ctx) {
RegisteredClient client = ctx.getRegisteredClient();
// (1) global switch on the client
if (!client.getClientSettings().isRequireAuthorizationConsent()) {
return false;
}
OAuth2Authorization authorization = ctx.getAuthorization();
Set<String> requested = authorization != null ? authorization.getAttribute(OAuth2ParameterNames.SCOPE) : null;
if (requested == null) {
requested = java.util.Collections.emptySet();
}
if (requested.size() == 1 && requested.contains(OidcScopes.OPENID)) {
return false; // skip for pure “openid” requests
}
OAuth2AuthorizationConsent priorConsent = ctx.getAuthorizationConsent();
return priorConsent == null || !priorConsent.getScopes().containsAll(requested);
}
private static boolean requiresAuthorizationConsent(Set<String> requestedScopes,
OAuth2AuthorizationConsent authorizationConsent) {

34
oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2DeviceVerificationAuthenticationProviderTests.java

@ -50,6 +50,7 @@ import org.springframework.security.oauth2.server.authorization.client.TestRegis @@ -50,6 +50,7 @@ import org.springframework.security.oauth2.server.authorization.client.TestRegis
import org.springframework.security.oauth2.server.authorization.context.AuthorizationServerContextHolder;
import org.springframework.security.oauth2.server.authorization.context.TestAuthorizationServerContext;
import org.springframework.security.oauth2.server.authorization.settings.AuthorizationServerSettings;
import org.springframework.security.oauth2.server.authorization.settings.ClientSettings;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
@ -240,7 +241,9 @@ public class OAuth2DeviceVerificationAuthenticationProviderTests { @@ -240,7 +241,9 @@ public class OAuth2DeviceVerificationAuthenticationProviderTests {
@Test
public void authenticateWhenAuthorizationConsentDoesNotExistThenReturnAuthorizationConsentWithState() {
RegisteredClient registeredClient = TestRegisteredClients.registeredClient().build();
RegisteredClient registeredClient = TestRegisteredClients.registeredClient()
.clientSettings(ClientSettings.builder().requireAuthorizationConsent(true).build())
.build();
// @formatter:off
OAuth2Authorization authorization = TestOAuth2Authorizations.authorization(registeredClient)
.token(createDeviceCode())
@ -335,7 +338,9 @@ public class OAuth2DeviceVerificationAuthenticationProviderTests { @@ -335,7 +338,9 @@ public class OAuth2DeviceVerificationAuthenticationProviderTests {
@Test
public void authenticateWhenAuthorizationConsentExistsAndRequestedScopesDoNotMatchThenReturnAuthorizationConsentWithState() {
RegisteredClient registeredClient = TestRegisteredClients.registeredClient().build();
RegisteredClient registeredClient = TestRegisteredClients.registeredClient()
.clientSettings(ClientSettings.builder().requireAuthorizationConsent(true).build())
.build();
// @formatter:off
OAuth2Authorization authorization = TestOAuth2Authorizations.authorization(registeredClient)
.authorizationGrantType(AuthorizationGrantType.DEVICE_CODE)
@ -381,6 +386,31 @@ public class OAuth2DeviceVerificationAuthenticationProviderTests { @@ -381,6 +386,31 @@ public class OAuth2DeviceVerificationAuthenticationProviderTests {
.isEqualTo(authenticationResult.getState());
}
@Test
public void authenticateWhenRequireAuthorizationConsentIsFalse_thenConsentPageSkipped() {
RegisteredClient registeredClient = TestRegisteredClients.registeredClient()
.clientSettings(ClientSettings.builder().requireAuthorizationConsent(false).build())
.build();
OAuth2Authorization authorization = TestOAuth2Authorizations.authorization(registeredClient)
.token(createDeviceCode())
.token(createUserCode())
.attributes(Map::clear)
.attribute(OAuth2ParameterNames.SCOPE, registeredClient.getScopes())
.build();
Authentication authentication = createAuthentication();
given(this.registeredClientRepository.findById(anyString())).willReturn(registeredClient);
given(this.authorizationService.findByToken(anyString(), any(OAuth2TokenType.class))).willReturn(authorization);
given(this.authorizationConsentService.findById(anyString(), anyString())).willReturn(null);
Authentication result = this.authenticationProvider.authenticate(authentication);
assertThat(result).isInstanceOf(OAuth2DeviceVerificationAuthenticationToken.class)
.extracting(Authentication::isAuthenticated)
.isEqualTo(true);
}
private static void mockAuthorizationServerContext() {
AuthorizationServerSettings authorizationServerSettings = AuthorizationServerSettings.builder().build();
TestAuthorizationServerContext authorizationServerContext = new TestAuthorizationServerContext(

2
oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/config/annotation/web/configurers/OAuth2DeviceCodeGrantTests.java

@ -79,6 +79,7 @@ import org.springframework.security.oauth2.server.authorization.client.Registere @@ -79,6 +79,7 @@ import org.springframework.security.oauth2.server.authorization.client.Registere
import org.springframework.security.oauth2.server.authorization.client.TestRegisteredClients;
import org.springframework.security.oauth2.server.authorization.config.annotation.web.configuration.OAuth2AuthorizationServerConfiguration;
import org.springframework.security.oauth2.server.authorization.settings.AuthorizationServerSettings;
import org.springframework.security.oauth2.server.authorization.settings.ClientSettings;
import org.springframework.security.oauth2.server.authorization.test.SpringTestContext;
import org.springframework.security.oauth2.server.authorization.test.SpringTestContextExtension;
import org.springframework.test.web.servlet.MockMvc;
@ -311,6 +312,7 @@ public class OAuth2DeviceCodeGrantTests { @@ -311,6 +312,7 @@ public class OAuth2DeviceCodeGrantTests {
// @formatter:off
RegisteredClient registeredClient = TestRegisteredClients.registeredClient()
.authorizationGrantType(AuthorizationGrantType.DEVICE_CODE)
.clientSettings(ClientSettings.builder().requireAuthorizationConsent(true).build())
.build();
// @formatter:on
this.registeredClientRepository.save(registeredClient);

Loading…
Cancel
Save