gitea

19967 Commits

20 Branches

215 Tags

816 MiB

Tree: cb72c901b3

Commit Graph

Author	SHA1	Message	Date
wxiaoguang	0cbaa0b662	Remove incorrect "db.DefaultContext" usages (#35366 )	4 months ago
RiceChuan	dfd7594499	chore: use errors.New to replace fmt.Errorf with no parameters (#32800 ) use errors.New to replace fmt.Errorf with no parameters Signed-off-by: RiceChuan <lc582041246@gmail.com>	1 year ago
Jason Song	a35714372d	Fix halfCommitter and WithTx (#22366 ) Related to #22362. I overlooked that there's always `committer.Close()`, like: ```go ctx, committer, err := db.TxContext(db.DefaultContext) if err != nil { return nil } defer committer.Close() // ... if err != nil { return nil } // ... return committer.Commit() ``` So the `Close` of `halfCommitter` should ignore `commit and close`, it's not a rollback. See: [Why `halfCommitter` and `WithTx` should rollback IMMEDIATELY or commit LATER](https://github.com/go-gitea/gitea/pull/22366#issuecomment-1374778612). Co-authored-by: techknowlogick <techknowlogick@gitea.io>	3 years ago

Author

SHA1

Message

Date

wxiaoguang

0cbaa0b662

Remove incorrect "db.DefaultContext" usages (#35366 )

4 months ago

RiceChuan

dfd7594499

chore: use errors.New to replace fmt.Errorf with no parameters (#32800 )

use errors.New to replace fmt.Errorf with no parameters

Signed-off-by: RiceChuan <lc582041246@gmail.com>

1 year ago

Jason Song

a35714372d

Fix halfCommitter and WithTx (#22366 )

Related to #22362.

I overlooked that there's always `committer.Close()`, like:

```go
		ctx, committer, err := db.TxContext(db.DefaultContext)
		if err != nil {
			return nil
		}
		defer committer.Close()

		// ...

		if err != nil {
			return nil
		}

		// ...

		return committer.Commit()
```

So the `Close` of `halfCommitter` should ignore `commit and close`, it's
not a rollback.

See: [Why `halfCommitter` and `WithTx` should rollback IMMEDIATELY or
commit
LATER](https://github.com/go-gitea/gitea/pull/22366#issuecomment-1374778612).

Co-authored-by: techknowlogick <techknowlogick@gitea.io>

3 years ago

3 Commits (cb72c901b3250fa47c4b403182a3762685d57a02)