Browse Source

Update scheduled tasks even if changes are pushed by "ActionsUser" (#32246) (#32252)

Backport #32246

Fix #32219

Co-authored-by: delvh <dev.lh@web.de>
pull/32265/head
Zettat123 1 year ago committed by GitHub
parent
commit
55562f9c79
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 10
      services/actions/notifier_helper.go

10
services/actions/notifier_helper.go

@ -115,11 +115,20 @@ func (input *notifyInput) Notify(ctx context.Context) { @@ -115,11 +115,20 @@ func (input *notifyInput) Notify(ctx context.Context) {
}
func notify(ctx context.Context, input *notifyInput) error {
shouldDetectSchedules := input.Event == webhook_module.HookEventPush && input.Ref.BranchName() == input.Repo.DefaultBranch
if input.Doer.IsActions() {
// avoiding triggering cyclically, for example:
// a comment of an issue will trigger the runner to add a new comment as reply,
// and the new comment will trigger the runner again.
log.Debug("ignore executing %v for event %v whose doer is %v", getMethod(ctx), input.Event, input.Doer.Name)
// we should update schedule tasks in this case, because
// 1. schedule tasks cannot be triggered by other events, so cyclic triggering will not occur
// 2. some schedule tasks may update the repo periodically, so the refs of schedule tasks need to be updated
if shouldDetectSchedules {
return DetectAndHandleSchedules(ctx, input.Repo)
}
return nil
}
if input.Repo.IsEmpty || input.Repo.IsArchived {
@ -173,7 +182,6 @@ func notify(ctx context.Context, input *notifyInput) error { @@ -173,7 +182,6 @@ func notify(ctx context.Context, input *notifyInput) error {
var detectedWorkflows []*actions_module.DetectedWorkflow
actionsConfig := input.Repo.MustGetUnit(ctx, unit_model.TypeActions).ActionsConfig()
shouldDetectSchedules := input.Event == webhook_module.HookEventPush && input.Ref.BranchName() == input.Repo.DefaultBranch
workflows, schedules, err := actions_module.DetectWorkflows(gitRepo, commit,
input.Event,
input.Payload,

Loading…
Cancel
Save