Fix data-race bug when accessing task.LastRun (#27584)

2 years ago · 1d155a43ad
1 changed files with 1 additions and 2 deletions
--- a/services/cron/cron.go
+++ b/services/cron/cron.go
@ -107,12 +107,11 @@ func ListTasks() TaskTable {
				@@ -107,12 +107,11 @@ func ListTasks() TaskTable {
 			prev = e.PreviousRun()
 		}

+		task.lock.Lock()
 		// If the manual run is after the cron run, use that instead.
 		if prev.Before(task.LastRun) {
 			prev = task.LastRun
 		}
-
-		task.lock.Lock()
 		tTable = append(tTable, &TaskTableRow{
 			Name:        task.Name,
 			Spec:        spec,