Browse Source

remove eslint two disabled rules & fix (#2309)

pull/2356/head
David Luzar 5 years ago committed by GitHub
parent
commit
56215c6c2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      .eslintrc.json
  2. 12
      src/components/ContextMenu.tsx
  3. 1
      src/global.d.ts

2
.eslintrc.json

@ -2,8 +2,6 @@ @@ -2,8 +2,6 @@
"extends": ["prettier", "react-app", "react-app/jest"],
"plugins": ["prettier"],
"rules": {
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/no-redeclare": "off",
"import/no-anonymous-default-export": "off",
"curly": "warn",
"no-console": [

12
src/components/ContextMenu.tsx

@ -38,9 +38,11 @@ const ContextMenu = ({ options, onCloseRequest, top, left }: Props) => { @@ -38,9 +38,11 @@ const ContextMenu = ({ options, onCloseRequest, top, left }: Props) => {
className="context-menu"
onContextMenu={(event) => event.preventDefault()}
>
{options.map((option, idx) => (
{options.map(({ action, label }, idx) => (
<li key={idx} onClick={onCloseRequest}>
<ContextMenuOption {...option} />
<button className="context-menu-option" onClick={action}>
{label}
</button>
</li>
))}
</ul>
@ -49,12 +51,6 @@ const ContextMenu = ({ options, onCloseRequest, top, left }: Props) => { @@ -49,12 +51,6 @@ const ContextMenu = ({ options, onCloseRequest, top, left }: Props) => {
);
};
const ContextMenuOption = ({ label, action }: ContextMenuOption) => (
<button className="context-menu-option" onClick={action}>
{label}
</button>
);
let contextMenuNode: HTMLDivElement;
const getContextMenuNode = (): HTMLDivElement => {
if (contextMenuNode) {

1
src/global.d.ts vendored

@ -1,3 +1,4 @@ @@ -1,3 +1,4 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
interface Document {
fonts?: {
ready?: Promise<void>;

Loading…
Cancel
Save