spring-security

Commit Graph

Author	SHA1	Message	Date
Roberto Paolillo	efb394d3b2	Allow ACL to be owned by GrantedAuthoritySid Closes gh-9425	5 years ago
Phillip Webb	c502312719	Replace expected @Test attributes with AssertJ Replace JUnit expected @Test attributes with AssertJ calls.	5 years ago
Phillip Webb	910b81928f	Replace try/catch with AssertJ Replace manual try/catch/fail blocks with AssertJ calls.	5 years ago
Rob Winch	e3dd8d2530	Polish acl format Issue gh-8945	5 years ago
Phillip Webb	a5aa6b3d7f	Remove blank lines from all tests Remove all blank lines from test code so that test methods are visually grouped together. This generally helps to make the test classes easer to scan, however, the "given" / "when" / "then" blocks used by some tests are now not as easy to discern. Issue gh-8945	5 years ago
Phillip Webb	fdc66d45d5	Polish spring-security-acl main code Manually polish `spring-security-acl` following the formatting and checkstyle fixes. Issue gh-8945	5 years ago
Phillip Webb	834dcf5bcf	Use consistent ternary expression style Update all ternary expressions so that the condition is always in parentheses and "not equals" is used in the test. This helps to bring consistency across the codebase which makes ternary expression easier to scan. For example: `a = (a != null) ? a : b` Issue gh-8945	5 years ago
Phillip Webb	8d3f039f76	Reduce method visibility when possible Reduce method visibility for package private classes when possible. In the case of abstract classes that will eventually be made public, the class has been made public and a package-private constructor has been added. Issue gh-8945	5 years ago
Phillip Webb	ec6a4cb3f0	Use consistent equals/hashCode/toString order Ensure that `equals` `hashCode` and `toString` methods always appear in the same order. This aligns with the style used in Spring Framework. Issue gh-8945	5 years ago
Phillip Webb	52f20b5281	Use parenthesis with single-arg lambdas Use regular expression search/replace to ensure all single-arg lambdas have parenthesis. This aligns with the style used in Spring Boot and ensure that single-arg and multi-arg lambdas are consistent. Issue gh-8945	5 years ago
Phillip Webb	ff94944313	Add whitespace after copyright header Add an additional lines after the copyright header and before the `package` declaration. This aligns with the style used by Spring Framework. Issue gh-8945	5 years ago
Phillip Webb	31ec450d05	Remove superfluous comments Remove a few comments that previously add noise but don't offer a great deal of value. Issue gh-8945	5 years ago
Phillip Webb	8d80166aaf	Update exception variable names Consistently use `ex` for caught exception and `cause` for Exception constructor arguments. Issue gh-8945	5 years ago
Phillip Webb	e9130489a6	Remove restricted static imports Replace static imports with class referenced methods. With the exception of a few well known static imports, checkstyle restricts the static imports that a class can use. For example, `asList(...)` would be replaced with `Arrays.asList(...)`. Issue gh-8945	5 years ago
Phillip Webb	db55ef4b3b	Migrate to BDD Mockito Migrate Mockito imports to use the BDD variant. This aligns better with the "given" / "when" / "then" style used in most tests since the "given" block now uses Mockito `given(...)` calls. The commit also updates a few tests that were accidentally using Power Mockito when regular Mockito could be used. Issue gh-8945	5 years ago
Phillip Webb	218480fb7c	Reduce the number of nested if statements Refactor `HeadersBeanDefinitionParser` and `AclImpl` to reduce the number of nested if statements. A few extracted methods are now used to hopefully improve readability. Issue gh-8945	5 years ago
Phillip Webb	a0b9442265	Use consistent modifier order Update code to use a consistent modifier order that aligns with that used in the "Java Language specification". Issue gh-8945	5 years ago
Phillip Webb	a2f2e9ac8d	Move inner-types so that they are always last Move all inner-types so that they are consistently the last item defined. This aligns with the style used by Spring Framework and the consistency generally makes it easier to scan the source. Issue gh-8945	5 years ago
Phillip Webb	418c3d6808	Avoid inner assignments Replace code of the form `a = b =c` with distinct statements. Although this results in more lines of code, they are usually easier to understand. Issue gh-8945	5 years ago
Phillip Webb	9e08b51ed3	Apply code cleanup rules to projects Apply automated cleanup rules to add `@Override` and `@Deprecated` annotations and to fix class references used with static methods. Issue gh-8945	5 years ago
Phillip Webb	8866fa6fb0	Always use 'this.' when accessing fields Apply an Eclipse cleanup rules to ensure that fields are always accessed using `this.`. This aligns with the style used by Spring Framework and helps users quickly see the difference between a local and member variable. Issue gh-8945	5 years ago
Phillip Webb	6894ff5d12	Make classes final where possible Update classes that have private constructors so that they are also declared final. In a few cases, inner-classes used private constructors but were subclassed. These have now been changed to have package-private constructors. Issue gh-8945	5 years ago
Phillip Webb	37fa94fafc	Organize imports Use "organize imports" from Eclipse to cleanup import statements so that they appear in a consistent and well defined order. Issue gh-8945	5 years ago
Phillip Webb	71bc145ae4	Remove superfluous comments Use '^\s+//\ \~\ .*$' and '^\s+//\ ============+$' regular expression searches to remove superfluous comments. Prior to this commit, many classes would have comments to indicate blocks of code (such as constructors/methods/instance fields). These added a lot of noise and weren't all that helpful, especially given the outline views available in most modern IDEs. Issue gh-8945	5 years ago
Phillip Webb	b7fc18262d	Reformat code using spring-javaformat Run `./gradlew format` to reformat all java files. Issue gh-8945	5 years ago
Phillip Webb	27ac046d8a	Rename Test.java -> Tests.java Rename a few test classes that accidentally ended in `Test` instead of `Tests`. Issue gh-8945	6 years ago
Сергей Цыпанов	3c2a97ed29	Use more efficient singletonList in JdbcAclService	6 years ago
Maksim Vinogradov	4f58576952	Prevent StackOverflowError for AccessControlEntryImpl.hashCode Getting StackOverflowError when invoke AclImpl.hashCode because of cross-references between AclImpl and AccessControlEntryImpl Remove from AccessControlEntryImpl.hashCode method invocation of acl.hashCode fixes gh-5401	6 years ago
Dávid Kovács	4ab9da1c53	Object ID Identicy conversion to long fails on old schema This change fixed a bug which tried to convert non-string object as string Fixes gh-7621	6 years ago
Eleftheria Stein	c5b36664ce	Polish PrincipalSid Remove reduntant UserDetails check and add tests	6 years ago
杨博 (Yang Bo)	ea148d5fee	Avoid toString in favor of getName for extract sid There are some more sophisticated implementations of `getName` in `AbstractAuthenticationToken` and other `Authentication` classes.	6 years ago
Eleftheria Stein	2d26be9446	Remove redundant public modifier	6 years ago
Markus Öllinger	2cc05550fc	rename comparison method to isGranted and add test	6 years ago
Markus Öllinger	a4ea989e9c	remove trailing whitespace	6 years ago
Markus Öllinger	a449d6c316	extract permission mask comparison for subclasses to override	6 years ago
evfool	6f6f5a12da	Fixed typo in comment	6 years ago
Lars Grefer	34dd5fea30	Remove redundant throws clauses Removes exceptions that are declared in a method's signature but never thrown by the method itself or its implementations/derivatives.	7 years ago
Lars Grefer	ff1070df36	remove redundant modifiers found by checkstyle	7 years ago
Lars Grefer	fb39d9c255	Anonymous type can be replaced with lambda	7 years ago
Lars Grefer	2056834432	Cleanup unnecessary unboxing Unboxing is unnecessary under Java 5 and newer, and can be safely removed.	7 years ago
Lars Grefer	2306d987e9	Cleanup unnecessary boxing	7 years ago
Lars Grefer	c5b5cc507c	Cleanup redundant type casts	7 years ago
Bagyoni Attila	878d262a26	Reimplement some hashCodes according to the currently recommended pattern. These hashCode implementations seemed suspicious (field hashCodes XORed together with 31). Included caseSensitive in AntPathRequestMatcher.hashCode() to be consistent with equals().	7 years ago
Spring Operator	2bf126f4cf	URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * http://luke.taylor.openid.cn/ (200) with 1 occurrences could not be migrated: ([https](https://luke.taylor.openid.cn/) result SSLHandshakeException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * http://axschema.org/contact/email (UnknownHostException) with 2 occurrences migrated to: https://axschema.org/contact/email ([https](https://axschema.org/contact/email) result UnknownHostException). * http://axschema.org/namePerson (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson ([https](https://axschema.org/namePerson) result UnknownHostException). * http://axschema.org/namePerson/first (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson/first ([https](https://axschema.org/namePerson/first) result UnknownHostException). * http://axschema.org/namePerson/last (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson/last ([https](https://axschema.org/namePerson/last) result UnknownHostException). * http://luke.taylor.myopenid.com/ (UnknownHostException) with 1 occurrences migrated to: https://luke.taylor.myopenid.com/ ([https](https://luke.taylor.myopenid.com/) result UnknownHostException). * http://schema.openid.net/contact/email (UnknownHostException) with 2 occurrences migrated to: https://schema.openid.net/contact/email ([https](https://schema.openid.net/contact/email) result UnknownHostException). * http://schema.openid.net/namePerson (UnknownHostException) with 1 occurrences migrated to: https://schema.openid.net/namePerson ([https](https://schema.openid.net/namePerson) result UnknownHostException). * http://schema.openid.net/namePerson/friendly (UnknownHostException) with 1 occurrences migrated to: https://schema.openid.net/namePerson/friendly ([https](https://schema.openid.net/namePerson/friendly) result UnknownHostException). * http://somehost/someUrl (UnknownHostException) with 1 occurrences migrated to: https://somehost/someUrl ([https](https://somehost/someUrl) result UnknownHostException). * http://spring.security.test.myopenid.com/ (UnknownHostException) with 1 occurrences migrated to: https://spring.security.test.myopenid.com/ ([https](https://spring.security.test.myopenid.com/) result UnknownHostException). * http://example.net/pkp-report (404) with 1 occurrences migrated to: https://example.net/pkp-report ([https](https://example.net/pkp-report) result 404). * http://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng (404) with 1 occurrences migrated to: https://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng ([https](https://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng) result 404). * http://www.puppycrawl.com/dtds/configuration_1_3.dtd (404) with 1 occurrences migrated to: https://www.puppycrawl.com/dtds/configuration_1_3.dtd ([https](https://www.puppycrawl.com/dtds/configuration_1_3.dtd) result 404). * http://www.puppycrawl.com/dtds/suppressions_1_1.dtd (404) with 1 occurrences migrated to: https://www.puppycrawl.com/dtds/suppressions_1_1.dtd ([https](https://www.puppycrawl.com/dtds/suppressions_1_1.dtd) result 404). * http://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller (404) with 1 occurrences migrated to: https://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller ([https](https://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller) result 404). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://raykrueger.blogspot.com/ with 1 occurrences migrated to: https://raykrueger.blogspot.com/ ([https](https://raykrueger.blogspot.com/) result 200). * http://www.infoq.com/presentations/code-organization-large-projects with 1 occurrences migrated to: https://www.infoq.com/presentations/code-organization-large-projects ([https](https://www.infoq.com/presentations/code-organization-large-projects) result 200). * http://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd with 1 occurrences migrated to: https://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd ([https](https://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd) result 200). * http://www.springframework.org/dtd/spring-beans.dtd with 4 occurrences migrated to: https://www.springframework.org/dtd/spring-beans.dtd ([https](https://www.springframework.org/dtd/spring-beans.dtd) result 200). * http://www.springframework.org/schema/aop/spring-aop-3.0.xsd with 5 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop-3.0.xsd ([https](https://www.springframework.org/schema/aop/spring-aop-3.0.xsd) result 200). * http://www.springframework.org/schema/aop/spring-aop-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop-3.2.xsd ([https](https://www.springframework.org/schema/aop/spring-aop-3.2.xsd) result 200). * http://www.springframework.org/schema/aop/spring-aop.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop.xsd ([https](https://www.springframework.org/schema/aop/spring-aop.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans-3.0.xsd with 20 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.0.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.0.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.1.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.1.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans.xsd with 267 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans.xsd ([https](https://www.springframework.org/schema/beans/spring-beans.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.0.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.0.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.1.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.1.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.2.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.2.xsd) result 200). * http://www.springframework.org/schema/context/spring-context.xsd with 6 occurrences migrated to: https://www.springframework.org/schema/context/spring-context.xsd ([https](https://www.springframework.org/schema/context/spring-context.xsd) result 200). * http://www.springframework.org/schema/data/jpa/spring-jpa.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/data/jpa/spring-jpa.xsd ([https](https://www.springframework.org/schema/data/jpa/spring-jpa.xsd) result 200). * http://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd ([https](https://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd) result 200). * http://www.springframework.org/schema/mvc/spring-mvc.xsd with 10 occurrences migrated to: https://www.springframework.org/schema/mvc/spring-mvc.xsd ([https](https://www.springframework.org/schema/mvc/spring-mvc.xsd) result 200). * http://www.springframework.org/schema/security/spring-security-2.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/security/spring-security-2.0.xsd ([https](https://www.springframework.org/schema/security/spring-security-2.0.xsd) result 200). * http://www.springframework.org/schema/security/spring-security.xsd with 266 occurrences migrated to: https://www.springframework.org/schema/security/spring-security.xsd ([https](https://www.springframework.org/schema/security/spring-security.xsd) result 200). * http://www.springframework.org/schema/tx/spring-tx-3.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx-3.0.xsd ([https](https://www.springframework.org/schema/tx/spring-tx-3.0.xsd) result 200). * http://www.springframework.org/schema/tx/spring-tx.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx.xsd ([https](https://www.springframework.org/schema/tx/spring-tx.xsd) result 200). * http://www.springframework.org/schema/util/spring-util-3.0.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/util/spring-util-3.0.xsd ([https](https://www.springframework.org/schema/util/spring-util-3.0.xsd) result 200). * http://www.springframework.org/schema/util/spring-util-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/util/spring-util-3.1.xsd ([https](https://www.springframework.org/schema/util/spring-util-3.1.xsd) result 200). * http://www.springframework.org/schema/util/spring-util.xsd with 4 occurrences migrated to: https://www.springframework.org/schema/util/spring-util.xsd ([https](https://www.springframework.org/schema/util/spring-util.xsd) result 200). * http://www.springframework.org/schema/websocket/spring-websocket.xsd with 6 occurrences migrated to: https://www.springframework.org/schema/websocket/spring-websocket.xsd ([https](https://www.springframework.org/schema/websocket/spring-websocket.xsd) result 200). * http://www.headwaysoftware.com with 1 occurrences migrated to: https://www.headwaysoftware.com ([https](https://www.headwaysoftware.com) result 301). * http://java.sun.com/dtd/web-app_2_3.dtd with 2 occurrences migrated to: https://java.sun.com/dtd/web-app_2_3.dtd ([https](https://java.sun.com/dtd/web-app_2_3.dtd) result 302). * http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd with 10 occurrences migrated to: https://java.sun.com/xml/ns/javaee/web-app_2_5.xsd ([https](https://java.sun.com/xml/ns/javaee/web-app_2_5.xsd) result 302). * http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd with 2 occurrences migrated to: https://java.sun.com/xml/ns/javaee/web-app_3_0.xsd ([https](https://java.sun.com/xml/ns/javaee/web-app_3_0.xsd) result 302). # Ignored These URLs were intentionally ignored. * http://appengine.google.com/ns/1.0 with 1 occurrences * http://docbook.org/ns/docbook with 1 occurrences * http://jakarta.apache.org/log4j/ with 1 occurrences * http://java.sun.com/xml/ns/javaee with 22 occurrences * http://www.springframework.org/schema/aop with 14 occurrences * http://www.springframework.org/schema/beans with 576 occurrences * http://www.springframework.org/schema/c with 6 occurrences * http://www.springframework.org/schema/context with 18 occurrences * http://www.springframework.org/schema/data/jpa with 2 occurrences * http://www.springframework.org/schema/jdbc with 2 occurrences * http://www.springframework.org/schema/mvc with 20 occurrences * http://www.springframework.org/schema/p with 10 occurrences * http://www.springframework.org/schema/security with 534 occurrences * http://www.springframework.org/schema/tx with 10 occurrences * http://www.springframework.org/schema/util with 16 occurrences * http://www.springframework.org/schema/websocket with 12 occurrences * http://www.w3.org/1999/xlink with 1 occurrences * http://www.w3.org/2001/XMLSchema-instance with 299 occurrences	7 years ago
Spring Operator	b93528138e	URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://www.apache.org/licenses/ with 1 occurrences migrated to: https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200). * http://www.apache.org/licenses/LICENSE-2.0 with 2691 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200). * http://www.apache.org/licenses/LICENSE-2.0.html with 2 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0.html ([https](https://www.apache.org/licenses/LICENSE-2.0.html) result 200).	7 years ago
Nena Raab	d1a754fcf2	JdbcAclService: fixes PostgreSql issue When setup the acl tables as specified in the Spring.io documentation I have faced the following error on a PostgreSql database: org.postgresql.util.PSQLException: ERROR: operator does not exist: bigint = character varying. This is because the acl_object_identity.object_id_identity column is of type varchar(36) but it is not necessarily accessed with a value of type String. - JdbcAclService / JdbcMutableAclService: SQL query must match object_id_identity column specification - JdbcAclService: changed JdbcTemplate to JdbcOperations for testability - JdbcAclServiceTest: Increased test coverage, the integration tests using embedded db relates to this commit `cd8d2079ed` Fixes gh-5508	7 years ago
Nena Raab	1706a5cb83	Spring ACL uses deprecated Mockito methods This change - replaces anyListOf(Class<T> clazz). With Java 8 this method will be removed in Mockito 3.0. This method is only used for generic friendliness to avoid casting, this is not anymore needed in Java 8. - replaces anyObject with any or any(Class<T> clazz) Fixes gh-6212	7 years ago
Nena Raab	918a4cd323	AclClassIdUtils Default GenericConversionService So that String, Long, and UUID conversions are automatically supported.	7 years ago
Paul Wheeler	ccc4e1c876	Made AclClassIdUtils genuinely package level by injecting the conversionService instead of AclClassIdUtils Fixes gh-4814	7 years ago
Paul Wheeler	2c362456fd	AclClassIdUtils should be public Fixes gh-4814	7 years ago

1 2 3 4 5

211 Commits (5.5.3)