spring-security

Commit Graph

Author	SHA1	Message	Date
Phillip Webb	319d3364aa	Migrate to assertThatExceptionOfType Consistently use `assertThatExceptionOfType(...).isThrownBy(...)` rather than `assertThatCode` or `assertThatThrownBy`. This aligns with Spring Boot and Spring Cloud. It also allows the convenience `assertThatIllegalArgument` and `assertThatIllegalState` methods to be used. Issue gh-8945	5 years ago
Phillip Webb	ee661f7b71	Fix whitespace issues in format-off code Fix a few whitespace issues in format-off code that would otherwise fail checkstyle. Issue gh-8945	5 years ago
Phillip Webb	834dcf5bcf	Use consistent ternary expression style Update all ternary expressions so that the condition is always in parentheses and "not equals" is used in the test. This helps to bring consistency across the codebase which makes ternary expression easier to scan. For example: `a = (a != null) ? a : b` Issue gh-8945	5 years ago
Phillip Webb	8d3f039f76	Reduce method visibility when possible Reduce method visibility for package private classes when possible. In the case of abstract classes that will eventually be made public, the class has been made public and a package-private constructor has been added. Issue gh-8945	5 years ago
Phillip Webb	ec6a4cb3f0	Use consistent equals/hashCode/toString order Ensure that `equals` `hashCode` and `toString` methods always appear in the same order. This aligns with the style used in Spring Framework. Issue gh-8945	5 years ago
Phillip Webb	612fb22a7f	Remove unnecessary lambda blocks Remove lambda blocks that aren't needed and replace instead with a simple expression. Issue gh-8945	5 years ago
Phillip Webb	01d90c9881	Hide utility class constructors Update all utility classes so that they have a private constructor. This prevents users from accidentally creating an instance, when they should just use the static methods directly. Issue gh-8945	5 years ago
Phillip Webb	8559447357	Enforce checkstyle header rule Enforce the checkstyle header rule and fix a few classes that had malformed headers. Issue gh-8945	5 years ago
Phillip Webb	8d80166aaf	Update exception variable names Consistently use `ex` for caught exception and `cause` for Exception constructor arguments. Issue gh-8945	5 years ago
Phillip Webb	e9130489a6	Remove restricted static imports Replace static imports with class referenced methods. With the exception of a few well known static imports, checkstyle restricts the static imports that a class can use. For example, `asList(...)` would be replaced with `Arrays.asList(...)`. Issue gh-8945	5 years ago
Phillip Webb	9a3fa6e812	Simplify boolean returns Simplify boolean returns of the form: if (b) { return true; } else { return false; } to: return b; Issue gh-8945	5 years ago
Phillip Webb	b69825d925	Simplify boolean expression Simplify boolean expression of the form `if (b == true)` to instead just use the form `if (b)`. Issue gh-8945	5 years ago
Phillip Webb	db55ef4b3b	Migrate to BDD Mockito Migrate Mockito imports to use the BDD variant. This aligns better with the "given" / "when" / "then" style used in most tests since the "given" block now uses Mockito `given(...)` calls. The commit also updates a few tests that were accidentally using Power Mockito when regular Mockito could be used. Issue gh-8945	5 years ago
Phillip Webb	b33cb1074f	Remove "redundant import" checkstyle suppression Remove the "redundant import" checkstyle suppression since running "organize imports" has fixed any violations. Issue gh-8945	5 years ago
Phillip Webb	18f3d13363	Fix parenthesis padding issues Fix a few parenthesis padding issues caused by the formatter. Issue gh-8945	5 years ago
Phillip Webb	f1cee9500f	Ensure classes are defined in their own files Ensure that all classes are defined in their own files. Mostly classes have been changed to inner-types. Issue gh-8945	5 years ago
Phillip Webb	053af720a4	Ensure no whitespace before lines Fix a few issues cause by the automatic formatting that meant additional leading whitespace was present. Issue gh-8945	5 years ago
Phillip Webb	4d487e8dc3	Ensure all files end with a new line Update all files to ensure that they always end with a new-line character. Issue gh-8945	5 years ago
Phillip Webb	218480fb7c	Reduce the number of nested if statements Refactor `HeadersBeanDefinitionParser` and `AclImpl` to reduce the number of nested if statements. A few extracted methods are now used to hopefully improve readability. Issue gh-8945	5 years ago
Phillip Webb	0b4b22f28f	Remove "need braces" checkstyle suppression Remove the "need braces" checkstyle suppression which does not cause any violations. Issue gh-8945	5 years ago
Phillip Webb	81fe9fc640	Make all exception classes immutable Update all exception classes so that they are fully immutable and cannot be changed once they have been thrown. Issue gh-8945	5 years ago
Phillip Webb	a0b9442265	Use consistent modifier order Update code to use a consistent modifier order that aligns with that used in the "Java Language specification". Issue gh-8945	5 years ago
Phillip Webb	4075595a3f	Ignore existing InterfaceIsType violations Add suppressions for existing `InterfaceIsType` violations. Ideally theses should be classes, but we can't easily change them without breaking binary back compatibility. Issue gh-8945	5 years ago
Phillip Webb	a2f2e9ac8d	Move inner-types so that they are always last Move all inner-types so that they are consistently the last item defined. This aligns with the style used by Spring Framework and the consistency generally makes it easier to scan the source. Issue gh-8945	5 years ago
Phillip Webb	418c3d6808	Avoid inner assignments Replace code of the form `a = b =c` with distinct statements. Although this results in more lines of code, they are usually easier to understand. Issue gh-8945	5 years ago
Phillip Webb	8866fa6fb0	Always use 'this.' when accessing fields Apply an Eclipse cleanup rules to ensure that fields are always accessed using `this.`. This aligns with the style used by Spring Framework and helps users quickly see the difference between a local and member variable. Issue gh-8945	5 years ago
Phillip Webb	6894ff5d12	Make classes final where possible Update classes that have private constructors so that they are also declared final. In a few cases, inner-classes used private constructors but were subclassed. These have now been changed to have package-private constructors. Issue gh-8945	5 years ago
Phillip Webb	b5d499e2eb	Remove empty block Refactor a few classes so that empty blocks are not longer used. For example, rather than: if(x) { } else { i++; } use: if(!x) { i++; } Issue gh-8945	5 years ago
Phillip Webb	37fa94fafc	Organize imports Use "organize imports" from Eclipse to cleanup import statements so that they appear in a consistent and well defined order. Issue gh-8945	5 years ago
Phillip Webb	5f64f53c3f	Use consistent "@" tag order in Javadoc Ensure that Javadoc "@" tags appear in a consistent and well defined order. Issue gh-8945	5 years ago
Phillip Webb	7f0653fa34	Remove array style checkstyle suppression Remove the array style rules suppression since it doesn't cause any checkstyle violations. Issue gh-8945	5 years ago
Phillip Webb	863c0873dd	Suppress third-party code from checkstyle Suppress `BCrypt` and `ComparableVersion` from checkstyle since these source files were developed by a third-party. Issue gh-8945	5 years ago
Phillip Webb	8142e4046f	Use compact annotation style Always use compact annotations when possible. For example, replace `@Target(value = ElementType.TYPE)` with `@Target(ElementType.TYPE)`. Issue gh-8945	5 years ago
Phillip Webb	aea0fea5d9	Add Spring Checkstyle with all checks disabled Introduce checkstyle rules from spring-javaformat, but keep them disabled so that fixes can be introduced one commit at a time. Issue gh-8945	5 years ago
Josh Cummings	77128a94e2	Add OpenSamlRelyingPartyRegistrationBuilderHttpMessageConverter Closes gh-8877	6 years ago
Rob Winch	ca1252be94	Replace whitelist with allowlist Issue gh-8676	6 years ago
Rob Winch	a769f6a0c4	Polish LDAP Authentication Issue gh-7628	6 years ago
Rob Winch	5a4eded696	Add RSocket Support Fixes gh-7360	6 years ago
Lars Grefer	d9016e52e6	Let checkstyle prevent redundant modifiers in the future	7 years ago
Rob Winch	82ce9aa6f8	Add nohttp Closes gh-6819	7 years ago
Spring Operator	2bf126f4cf	URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * http://luke.taylor.openid.cn/ (200) with 1 occurrences could not be migrated: ([https](https://luke.taylor.openid.cn/) result SSLHandshakeException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * http://axschema.org/contact/email (UnknownHostException) with 2 occurrences migrated to: https://axschema.org/contact/email ([https](https://axschema.org/contact/email) result UnknownHostException). * http://axschema.org/namePerson (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson ([https](https://axschema.org/namePerson) result UnknownHostException). * http://axschema.org/namePerson/first (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson/first ([https](https://axschema.org/namePerson/first) result UnknownHostException). * http://axschema.org/namePerson/last (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson/last ([https](https://axschema.org/namePerson/last) result UnknownHostException). * http://luke.taylor.myopenid.com/ (UnknownHostException) with 1 occurrences migrated to: https://luke.taylor.myopenid.com/ ([https](https://luke.taylor.myopenid.com/) result UnknownHostException). * http://schema.openid.net/contact/email (UnknownHostException) with 2 occurrences migrated to: https://schema.openid.net/contact/email ([https](https://schema.openid.net/contact/email) result UnknownHostException). * http://schema.openid.net/namePerson (UnknownHostException) with 1 occurrences migrated to: https://schema.openid.net/namePerson ([https](https://schema.openid.net/namePerson) result UnknownHostException). * http://schema.openid.net/namePerson/friendly (UnknownHostException) with 1 occurrences migrated to: https://schema.openid.net/namePerson/friendly ([https](https://schema.openid.net/namePerson/friendly) result UnknownHostException). * http://somehost/someUrl (UnknownHostException) with 1 occurrences migrated to: https://somehost/someUrl ([https](https://somehost/someUrl) result UnknownHostException). * http://spring.security.test.myopenid.com/ (UnknownHostException) with 1 occurrences migrated to: https://spring.security.test.myopenid.com/ ([https](https://spring.security.test.myopenid.com/) result UnknownHostException). * http://example.net/pkp-report (404) with 1 occurrences migrated to: https://example.net/pkp-report ([https](https://example.net/pkp-report) result 404). * http://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng (404) with 1 occurrences migrated to: https://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng ([https](https://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng) result 404). * http://www.puppycrawl.com/dtds/configuration_1_3.dtd (404) with 1 occurrences migrated to: https://www.puppycrawl.com/dtds/configuration_1_3.dtd ([https](https://www.puppycrawl.com/dtds/configuration_1_3.dtd) result 404). * http://www.puppycrawl.com/dtds/suppressions_1_1.dtd (404) with 1 occurrences migrated to: https://www.puppycrawl.com/dtds/suppressions_1_1.dtd ([https](https://www.puppycrawl.com/dtds/suppressions_1_1.dtd) result 404). * http://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller (404) with 1 occurrences migrated to: https://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller ([https](https://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller) result 404). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://raykrueger.blogspot.com/ with 1 occurrences migrated to: https://raykrueger.blogspot.com/ ([https](https://raykrueger.blogspot.com/) result 200). * http://www.infoq.com/presentations/code-organization-large-projects with 1 occurrences migrated to: https://www.infoq.com/presentations/code-organization-large-projects ([https](https://www.infoq.com/presentations/code-organization-large-projects) result 200). * http://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd with 1 occurrences migrated to: https://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd ([https](https://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd) result 200). * http://www.springframework.org/dtd/spring-beans.dtd with 4 occurrences migrated to: https://www.springframework.org/dtd/spring-beans.dtd ([https](https://www.springframework.org/dtd/spring-beans.dtd) result 200). * http://www.springframework.org/schema/aop/spring-aop-3.0.xsd with 5 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop-3.0.xsd ([https](https://www.springframework.org/schema/aop/spring-aop-3.0.xsd) result 200). * http://www.springframework.org/schema/aop/spring-aop-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop-3.2.xsd ([https](https://www.springframework.org/schema/aop/spring-aop-3.2.xsd) result 200). * http://www.springframework.org/schema/aop/spring-aop.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop.xsd ([https](https://www.springframework.org/schema/aop/spring-aop.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans-3.0.xsd with 20 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.0.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.0.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.1.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.1.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans.xsd with 267 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans.xsd ([https](https://www.springframework.org/schema/beans/spring-beans.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.0.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.0.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.1.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.1.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.2.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.2.xsd) result 200). * http://www.springframework.org/schema/context/spring-context.xsd with 6 occurrences migrated to: https://www.springframework.org/schema/context/spring-context.xsd ([https](https://www.springframework.org/schema/context/spring-context.xsd) result 200). * http://www.springframework.org/schema/data/jpa/spring-jpa.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/data/jpa/spring-jpa.xsd ([https](https://www.springframework.org/schema/data/jpa/spring-jpa.xsd) result 200). * http://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd ([https](https://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd) result 200). * http://www.springframework.org/schema/mvc/spring-mvc.xsd with 10 occurrences migrated to: https://www.springframework.org/schema/mvc/spring-mvc.xsd ([https](https://www.springframework.org/schema/mvc/spring-mvc.xsd) result 200). * http://www.springframework.org/schema/security/spring-security-2.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/security/spring-security-2.0.xsd ([https](https://www.springframework.org/schema/security/spring-security-2.0.xsd) result 200). * http://www.springframework.org/schema/security/spring-security.xsd with 266 occurrences migrated to: https://www.springframework.org/schema/security/spring-security.xsd ([https](https://www.springframework.org/schema/security/spring-security.xsd) result 200). * http://www.springframework.org/schema/tx/spring-tx-3.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx-3.0.xsd ([https](https://www.springframework.org/schema/tx/spring-tx-3.0.xsd) result 200). * http://www.springframework.org/schema/tx/spring-tx.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx.xsd ([https](https://www.springframework.org/schema/tx/spring-tx.xsd) result 200). * http://www.springframework.org/schema/util/spring-util-3.0.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/util/spring-util-3.0.xsd ([https](https://www.springframework.org/schema/util/spring-util-3.0.xsd) result 200). * http://www.springframework.org/schema/util/spring-util-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/util/spring-util-3.1.xsd ([https](https://www.springframework.org/schema/util/spring-util-3.1.xsd) result 200). * http://www.springframework.org/schema/util/spring-util.xsd with 4 occurrences migrated to: https://www.springframework.org/schema/util/spring-util.xsd ([https](https://www.springframework.org/schema/util/spring-util.xsd) result 200). * http://www.springframework.org/schema/websocket/spring-websocket.xsd with 6 occurrences migrated to: https://www.springframework.org/schema/websocket/spring-websocket.xsd ([https](https://www.springframework.org/schema/websocket/spring-websocket.xsd) result 200). * http://www.headwaysoftware.com with 1 occurrences migrated to: https://www.headwaysoftware.com ([https](https://www.headwaysoftware.com) result 301). * http://java.sun.com/dtd/web-app_2_3.dtd with 2 occurrences migrated to: https://java.sun.com/dtd/web-app_2_3.dtd ([https](https://java.sun.com/dtd/web-app_2_3.dtd) result 302). * http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd with 10 occurrences migrated to: https://java.sun.com/xml/ns/javaee/web-app_2_5.xsd ([https](https://java.sun.com/xml/ns/javaee/web-app_2_5.xsd) result 302). * http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd with 2 occurrences migrated to: https://java.sun.com/xml/ns/javaee/web-app_3_0.xsd ([https](https://java.sun.com/xml/ns/javaee/web-app_3_0.xsd) result 302). # Ignored These URLs were intentionally ignored. * http://appengine.google.com/ns/1.0 with 1 occurrences * http://docbook.org/ns/docbook with 1 occurrences * http://jakarta.apache.org/log4j/ with 1 occurrences * http://java.sun.com/xml/ns/javaee with 22 occurrences * http://www.springframework.org/schema/aop with 14 occurrences * http://www.springframework.org/schema/beans with 576 occurrences * http://www.springframework.org/schema/c with 6 occurrences * http://www.springframework.org/schema/context with 18 occurrences * http://www.springframework.org/schema/data/jpa with 2 occurrences * http://www.springframework.org/schema/jdbc with 2 occurrences * http://www.springframework.org/schema/mvc with 20 occurrences * http://www.springframework.org/schema/p with 10 occurrences * http://www.springframework.org/schema/security with 534 occurrences * http://www.springframework.org/schema/tx with 10 occurrences * http://www.springframework.org/schema/util with 16 occurrences * http://www.springframework.org/schema/websocket with 12 occurrences * http://www.w3.org/1999/xlink with 1 occurrences * http://www.w3.org/2001/XMLSchema-instance with 299 occurrences	7 years ago
Spring Operator	b93528138e	URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://www.apache.org/licenses/ with 1 occurrences migrated to: https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200). * http://www.apache.org/licenses/LICENSE-2.0 with 2691 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200). * http://www.apache.org/licenses/LICENSE-2.0.html with 2 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0.html ([https](https://www.apache.org/licenses/LICENSE-2.0.html) result 200).	7 years ago
Vedran Pavic	f7cb53e9bd	Upgrade spring-build-conventions to 0.0.18.RELEASE	8 years ago
Johnny Lim	5f518d00e5	Apply Checkstyle EmptyStatementCheck module This commit adds Checkstyle `EmptyStatementCheck` module and aligns code with it.	8 years ago
Johnny Lim	b6895e6359	Apply Checkstyle WhitespaceAfterCheck module	8 years ago
Johnny Lim	d900f2a623	Remove unused imports This commit also adds UnusedImportsCheck Checkstyle module.	8 years ago
Johnny Lim	99df632f24	Add missing @Override annotations This commit also adds MissingOverrideCheck module to Checkstyle configuration.	8 years ago
Rob Winch	d85c0395bb	Fix checkstyle import into Eclipse Issue gh-3747	10 years ago
Rob Winch	7de4e59167	Auto Import Eclipse Settings Fixes gh-3747	10 years ago
Rob Winch	b52ffe038e	Add Checkstyle Fixes gh-3746	10 years ago

1 2

51 Commits (fa82c00a6753235e5c4a48b31ecf39e1c49fdfd6)