spring-security

Commit Graph

Author	SHA1	Message	Date
Eleftheria Stein	c5b36664ce	Polish PrincipalSid Remove reduntant UserDetails check and add tests	6 years ago
杨博 (Yang Bo)	ea148d5fee	Avoid toString in favor of getName for extract sid There are some more sophisticated implementations of `getName` in `AbstractAuthenticationToken` and other `Authentication` classes.	6 years ago
Eleftheria Stein	2d26be9446	Remove redundant public modifier	6 years ago
Markus Öllinger	2cc05550fc	rename comparison method to isGranted and add test	6 years ago
Markus Öllinger	a4ea989e9c	remove trailing whitespace	6 years ago
Markus Öllinger	a449d6c316	extract permission mask comparison for subclasses to override	6 years ago
evfool	6f6f5a12da	Fixed typo in comment	6 years ago
Lars Grefer	34dd5fea30	Remove redundant throws clauses Removes exceptions that are declared in a method's signature but never thrown by the method itself or its implementations/derivatives.	6 years ago
Lars Grefer	ff1070df36	remove redundant modifiers found by checkstyle	6 years ago
Lars Grefer	fb39d9c255	Anonymous type can be replaced with lambda	6 years ago
Lars Grefer	2056834432	Cleanup unnecessary unboxing Unboxing is unnecessary under Java 5 and newer, and can be safely removed.	6 years ago
Lars Grefer	2306d987e9	Cleanup unnecessary boxing	6 years ago
Lars Grefer	c5b5cc507c	Cleanup redundant type casts	7 years ago
Bagyoni Attila	878d262a26	Reimplement some hashCodes according to the currently recommended pattern. These hashCode implementations seemed suspicious (field hashCodes XORed together with 31). Included caseSensitive in AntPathRequestMatcher.hashCode() to be consistent with equals().	7 years ago
Spring Operator	2bf126f4cf	URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * http://luke.taylor.openid.cn/ (200) with 1 occurrences could not be migrated: ([https](https://luke.taylor.openid.cn/) result SSLHandshakeException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * http://axschema.org/contact/email (UnknownHostException) with 2 occurrences migrated to: https://axschema.org/contact/email ([https](https://axschema.org/contact/email) result UnknownHostException). * http://axschema.org/namePerson (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson ([https](https://axschema.org/namePerson) result UnknownHostException). * http://axschema.org/namePerson/first (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson/first ([https](https://axschema.org/namePerson/first) result UnknownHostException). * http://axschema.org/namePerson/last (UnknownHostException) with 1 occurrences migrated to: https://axschema.org/namePerson/last ([https](https://axschema.org/namePerson/last) result UnknownHostException). * http://luke.taylor.myopenid.com/ (UnknownHostException) with 1 occurrences migrated to: https://luke.taylor.myopenid.com/ ([https](https://luke.taylor.myopenid.com/) result UnknownHostException). * http://schema.openid.net/contact/email (UnknownHostException) with 2 occurrences migrated to: https://schema.openid.net/contact/email ([https](https://schema.openid.net/contact/email) result UnknownHostException). * http://schema.openid.net/namePerson (UnknownHostException) with 1 occurrences migrated to: https://schema.openid.net/namePerson ([https](https://schema.openid.net/namePerson) result UnknownHostException). * http://schema.openid.net/namePerson/friendly (UnknownHostException) with 1 occurrences migrated to: https://schema.openid.net/namePerson/friendly ([https](https://schema.openid.net/namePerson/friendly) result UnknownHostException). * http://somehost/someUrl (UnknownHostException) with 1 occurrences migrated to: https://somehost/someUrl ([https](https://somehost/someUrl) result UnknownHostException). * http://spring.security.test.myopenid.com/ (UnknownHostException) with 1 occurrences migrated to: https://spring.security.test.myopenid.com/ ([https](https://spring.security.test.myopenid.com/) result UnknownHostException). * http://example.net/pkp-report (404) with 1 occurrences migrated to: https://example.net/pkp-report ([https](https://example.net/pkp-report) result 404). * http://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng (404) with 1 occurrences migrated to: https://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng ([https](https://www.oasis-open.org/docbook/xml/5.0/rng/docbook.rng) result 404). * http://www.puppycrawl.com/dtds/configuration_1_3.dtd (404) with 1 occurrences migrated to: https://www.puppycrawl.com/dtds/configuration_1_3.dtd ([https](https://www.puppycrawl.com/dtds/configuration_1_3.dtd) result 404). * http://www.puppycrawl.com/dtds/suppressions_1_1.dtd (404) with 1 occurrences migrated to: https://www.puppycrawl.com/dtds/suppressions_1_1.dtd ([https](https://www.puppycrawl.com/dtds/suppressions_1_1.dtd) result 404). * http://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller (404) with 1 occurrences migrated to: https://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller ([https](https://www.se-radio.net/transcript-82-organization-large-code-bases-juergen-hoeller) result 404). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://raykrueger.blogspot.com/ with 1 occurrences migrated to: https://raykrueger.blogspot.com/ ([https](https://raykrueger.blogspot.com/) result 200). * http://www.infoq.com/presentations/code-organization-large-projects with 1 occurrences migrated to: https://www.infoq.com/presentations/code-organization-large-projects ([https](https://www.infoq.com/presentations/code-organization-large-projects) result 200). * http://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd with 1 occurrences migrated to: https://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd ([https](https://www.oasis-open.org/committees/entity/release/1.0/catalog.dtd) result 200). * http://www.springframework.org/dtd/spring-beans.dtd with 4 occurrences migrated to: https://www.springframework.org/dtd/spring-beans.dtd ([https](https://www.springframework.org/dtd/spring-beans.dtd) result 200). * http://www.springframework.org/schema/aop/spring-aop-3.0.xsd with 5 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop-3.0.xsd ([https](https://www.springframework.org/schema/aop/spring-aop-3.0.xsd) result 200). * http://www.springframework.org/schema/aop/spring-aop-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop-3.2.xsd ([https](https://www.springframework.org/schema/aop/spring-aop-3.2.xsd) result 200). * http://www.springframework.org/schema/aop/spring-aop.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop.xsd ([https](https://www.springframework.org/schema/aop/spring-aop.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans-3.0.xsd with 20 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.0.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.0.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.1.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.1.xsd) result 200). * http://www.springframework.org/schema/beans/spring-beans.xsd with 267 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans.xsd ([https](https://www.springframework.org/schema/beans/spring-beans.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.0.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.0.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.1.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.1.xsd) result 200). * http://www.springframework.org/schema/context/spring-context-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.2.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.2.xsd) result 200). * http://www.springframework.org/schema/context/spring-context.xsd with 6 occurrences migrated to: https://www.springframework.org/schema/context/spring-context.xsd ([https](https://www.springframework.org/schema/context/spring-context.xsd) result 200). * http://www.springframework.org/schema/data/jpa/spring-jpa.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/data/jpa/spring-jpa.xsd ([https](https://www.springframework.org/schema/data/jpa/spring-jpa.xsd) result 200). * http://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd ([https](https://www.springframework.org/schema/jdbc/spring-jdbc-3.1.xsd) result 200). * http://www.springframework.org/schema/mvc/spring-mvc.xsd with 10 occurrences migrated to: https://www.springframework.org/schema/mvc/spring-mvc.xsd ([https](https://www.springframework.org/schema/mvc/spring-mvc.xsd) result 200). * http://www.springframework.org/schema/security/spring-security-2.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/security/spring-security-2.0.xsd ([https](https://www.springframework.org/schema/security/spring-security-2.0.xsd) result 200). * http://www.springframework.org/schema/security/spring-security.xsd with 266 occurrences migrated to: https://www.springframework.org/schema/security/spring-security.xsd ([https](https://www.springframework.org/schema/security/spring-security.xsd) result 200). * http://www.springframework.org/schema/tx/spring-tx-3.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx-3.0.xsd ([https](https://www.springframework.org/schema/tx/spring-tx-3.0.xsd) result 200). * http://www.springframework.org/schema/tx/spring-tx.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx.xsd ([https](https://www.springframework.org/schema/tx/spring-tx.xsd) result 200). * http://www.springframework.org/schema/util/spring-util-3.0.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/util/spring-util-3.0.xsd ([https](https://www.springframework.org/schema/util/spring-util-3.0.xsd) result 200). * http://www.springframework.org/schema/util/spring-util-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/util/spring-util-3.1.xsd ([https](https://www.springframework.org/schema/util/spring-util-3.1.xsd) result 200). * http://www.springframework.org/schema/util/spring-util.xsd with 4 occurrences migrated to: https://www.springframework.org/schema/util/spring-util.xsd ([https](https://www.springframework.org/schema/util/spring-util.xsd) result 200). * http://www.springframework.org/schema/websocket/spring-websocket.xsd with 6 occurrences migrated to: https://www.springframework.org/schema/websocket/spring-websocket.xsd ([https](https://www.springframework.org/schema/websocket/spring-websocket.xsd) result 200). * http://www.headwaysoftware.com with 1 occurrences migrated to: https://www.headwaysoftware.com ([https](https://www.headwaysoftware.com) result 301). * http://java.sun.com/dtd/web-app_2_3.dtd with 2 occurrences migrated to: https://java.sun.com/dtd/web-app_2_3.dtd ([https](https://java.sun.com/dtd/web-app_2_3.dtd) result 302). * http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd with 10 occurrences migrated to: https://java.sun.com/xml/ns/javaee/web-app_2_5.xsd ([https](https://java.sun.com/xml/ns/javaee/web-app_2_5.xsd) result 302). * http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd with 2 occurrences migrated to: https://java.sun.com/xml/ns/javaee/web-app_3_0.xsd ([https](https://java.sun.com/xml/ns/javaee/web-app_3_0.xsd) result 302). # Ignored These URLs were intentionally ignored. * http://appengine.google.com/ns/1.0 with 1 occurrences * http://docbook.org/ns/docbook with 1 occurrences * http://jakarta.apache.org/log4j/ with 1 occurrences * http://java.sun.com/xml/ns/javaee with 22 occurrences * http://www.springframework.org/schema/aop with 14 occurrences * http://www.springframework.org/schema/beans with 576 occurrences * http://www.springframework.org/schema/c with 6 occurrences * http://www.springframework.org/schema/context with 18 occurrences * http://www.springframework.org/schema/data/jpa with 2 occurrences * http://www.springframework.org/schema/jdbc with 2 occurrences * http://www.springframework.org/schema/mvc with 20 occurrences * http://www.springframework.org/schema/p with 10 occurrences * http://www.springframework.org/schema/security with 534 occurrences * http://www.springframework.org/schema/tx with 10 occurrences * http://www.springframework.org/schema/util with 16 occurrences * http://www.springframework.org/schema/websocket with 12 occurrences * http://www.w3.org/1999/xlink with 1 occurrences * http://www.w3.org/2001/XMLSchema-instance with 299 occurrences	7 years ago
Spring Operator	b93528138e	URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://www.apache.org/licenses/ with 1 occurrences migrated to: https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200). * http://www.apache.org/licenses/LICENSE-2.0 with 2691 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200). * http://www.apache.org/licenses/LICENSE-2.0.html with 2 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0.html ([https](https://www.apache.org/licenses/LICENSE-2.0.html) result 200).	7 years ago
Nena Raab	d1a754fcf2	JdbcAclService: fixes PostgreSql issue When setup the acl tables as specified in the Spring.io documentation I have faced the following error on a PostgreSql database: org.postgresql.util.PSQLException: ERROR: operator does not exist: bigint = character varying. This is because the acl_object_identity.object_id_identity column is of type varchar(36) but it is not necessarily accessed with a value of type String. - JdbcAclService / JdbcMutableAclService: SQL query must match object_id_identity column specification - JdbcAclService: changed JdbcTemplate to JdbcOperations for testability - JdbcAclServiceTest: Increased test coverage, the integration tests using embedded db relates to this commit `cd8d2079ed` Fixes gh-5508	7 years ago
Nena Raab	1706a5cb83	Spring ACL uses deprecated Mockito methods This change - replaces anyListOf(Class<T> clazz). With Java 8 this method will be removed in Mockito 3.0. This method is only used for generic friendliness to avoid casting, this is not anymore needed in Java 8. - replaces anyObject with any or any(Class<T> clazz) Fixes gh-6212	7 years ago
Nena Raab	918a4cd323	AclClassIdUtils Default GenericConversionService So that String, Long, and UUID conversions are automatically supported.	7 years ago
Paul Wheeler	ccc4e1c876	Made AclClassIdUtils genuinely package level by injecting the conversionService instead of AclClassIdUtils Fixes gh-4814	7 years ago
Paul Wheeler	2c362456fd	AclClassIdUtils should be public Fixes gh-4814	7 years ago
Johnny Lim	68878a1675	Replace isEqualTo(null) with isNull()	7 years ago
Christoph Dreis	d07cfe655d	Use Supplier variants of Assert methods	8 years ago
Johnny Lim	57353d18e5	Use diamond type	8 years ago
Johnny Lim	5f518d00e5	Apply Checkstyle EmptyStatementCheck module This commit adds Checkstyle `EmptyStatementCheck` module and aligns code with it.	8 years ago
Johnny Lim	b6895e6359	Apply Checkstyle WhitespaceAfterCheck module	8 years ago
Johnny Lim	d900f2a623	Remove unused imports This commit also adds UnusedImportsCheck Checkstyle module.	8 years ago
Johnny Lim	99df632f24	Add missing @Override annotations This commit also adds MissingOverrideCheck module to Checkstyle configuration.	8 years ago
Antoine	0771778b81	Polish more AssertJ assertions	8 years ago
Antoine	e0aca04a28	Polish AssertJ assertions Polish AssertJ assertions	8 years ago
Paul Wheeler	6decf1c8ef	Allow use of non-numeric (e.g. UUID) values for ObjectIdentity.getIdentifier() Prior to this commit, the ObjectIdentity id had to be a number. This commit allows for domain objects to use UUIDs as their identifier. The fully qualified class name of the identifier type can be specified in the acl_object_identity table and a ConversionService can be provided to BasicLookupStrategy to convert from String to the actual identifier type. There are the following other changes: - BasicLookupStrategy has a new property, aclClassIdSupported, which is used to retrieve the new column from the database. This preserves backwards-compatibility, as it is false by default. - JdbcMutableAclService has the same property, aclClassIdSupported, which is needed to modify the insert statement to write to the new column. Defaults to false for backwards-compatibility. - Tests have been updated to verify both the existing functionality for backwards-compatibility and the new functionality. Fixes gh-1224	8 years ago
Rob Winch	23f56f568c	Update MockitJunitRunner import Issue: gh-4608	8 years ago
Rob Winch	445834784a	Update to Mockito 2.10.0 Issue: gh-4608	8 years ago
Rob Winch	f3828924ff	Fix equals and hashCode alignment Fixes gh-4588	8 years ago
Rob Winch	e16b8e7976	Fix logback-test.xml	8 years ago
Rob Winch	3f543d0fbd	Use anyListOf Fixes compatability with Spring IO Cairo	9 years ago
Johnny Lim	3185876a7d	Remove dead code in AclAuthorizationStrategyImplTests	9 years ago
Rob Winch	36f4f7d081	Add securityCheckWhenCustomAuthorityThenNameIsUsed Add a test for AclAuthorizationStrategyImpl.securityCheck when a custom authority is used. Issue gh-4085	9 years ago
Shazin Sadakath	07d1c7c5eb	AclAuthorizationStrategyImpl uses name Fixes gh-4085	9 years ago
Johnny Lim	310bb39a0d	Fix typo	10 years ago
Eddú Meléndez	a2ead4cf7a	Polish Fixes gh-3892	10 years ago
Johnny Lim	933a7e8363	Remove duplicate words Fixes gh-3826	10 years ago
Rob Winch	f221920a19	Clean up code to conform to basic checkstyle Issue gh-3746	10 years ago
Billy Korando	71d4ce96ad	Convert to assertj Fixes gh-3175	10 years ago
Rob Winch	bb600a473e	Start AssertJ Migration Issue gh-3175	10 years ago
Thomas Darimont	ad1d858e2b	SEC-3056 - Fix JavaDoc errors. Fixed JavaDoc errors accross multiple modules in order to make javadoc happy with Java 8.	11 years ago
Rob Winch	aad4e70374	SEC-3034: AclPermissionEvaluator specifies Locale.ENGLISH	11 years ago
Rob Winch	197ddb3cd1	SEC-3029: Fix Compatibility with Spring 4.2.x	11 years ago
Alex Panchenko	0a118336d4	SEC-2955: Convert to "static" for inner classes	11 years ago
Rob Winch	4fdfb8caba	SEC-2915: More Tabs -> Spaces	11 years ago

1 2 3 4

182 Commits (84f45e4196db388e521f5b51c444830e9b94b990)