Phillip Webb
31ec450d05
Remove superfluous comments
...
Remove a few comments that previously add noise but don't offer a great
deal of value.
Issue gh-8945
5 years ago
Phillip Webb
8d80166aaf
Update exception variable names
...
Consistently use `ex` for caught exception and `cause` for Exception
constructor arguments.
Issue gh-8945
5 years ago
Phillip Webb
db55ef4b3b
Migrate to BDD Mockito
...
Migrate Mockito imports to use the BDD variant. This aligns better with
the "given" / "when" / "then" style used in most tests since the "given"
block now uses Mockito `given(...)` calls.
The commit also updates a few tests that were accidentally using
Power Mockito when regular Mockito could be used.
Issue gh-8945
5 years ago
Phillip Webb
a0b9442265
Use consistent modifier order
...
Update code to use a consistent modifier order that aligns with that
used in the "Java Language specification".
Issue gh-8945
5 years ago
Phillip Webb
a2f2e9ac8d
Move inner-types so that they are always last
...
Move all inner-types so that they are consistently the last item
defined. This aligns with the style used by Spring Framework and
the consistency generally makes it easier to scan the source.
Issue gh-8945
5 years ago
Phillip Webb
9e08b51ed3
Apply code cleanup rules to projects
...
Apply automated cleanup rules to add `@Override` and `@Deprecated`
annotations and to fix class references used with static methods.
Issue gh-8945
5 years ago
Phillip Webb
8866fa6fb0
Always use 'this.' when accessing fields
...
Apply an Eclipse cleanup rules to ensure that fields are always accessed
using `this.`. This aligns with the style used by Spring Framework and
helps users quickly see the difference between a local and member
variable.
Issue gh-8945
5 years ago
Phillip Webb
37fa94fafc
Organize imports
...
Use "organize imports" from Eclipse to cleanup import statements so
that they appear in a consistent and well defined order.
Issue gh-8945
5 years ago
Phillip Webb
71bc145ae4
Remove superfluous comments
...
Use '^\s+//\ \~\ .*$' and '^\s+//\ ============+$' regular expression
searches to remove superfluous comments.
Prior to this commit, many classes would have comments to indicate
blocks of code (such as constructors/methods/instance fields). These
added a lot of noise and weren't all that helpful, especially given
the outline views available in most modern IDEs.
Issue gh-8945
5 years ago
Phillip Webb
b7fc18262d
Reformat code using spring-javaformat
...
Run `./gradlew format` to reformat all java files.
Issue gh-8945
5 years ago
Joe Grandja
1d74d556c2
Revert "Lock Dependency Versions for 5.4.0-RC1"
...
This reverts commit f3a1e5d40c .
5 years ago
Joe Grandja
f3a1e5d40c
Lock Dependency Versions for 5.4.0-RC1
5 years ago
Eleftheria Stein
d8bef76a0f
Unlock dependencies
...
This reverts commit b619d298aa .
5 years ago
Eleftheria Stein
b619d298aa
Lock Dependencies for 5.3.4.RELEASE
5 years ago
Eleftheria Stein-Kousathana
7c4a706865
Throw exception if specified ldif does not exist
...
Closes gh-7791
Co-Authored-By: Shay Dratler <dratler@users.noreply.github.com>
5 years ago
Josh Cummings
146d0b6358
Revert "Lock Dependency Versions for 5.4.0-M2"
...
This reverts commit 68538897c8 .
6 years ago
Josh Cummings
68538897c8
Lock Dependency Versions for 5.4.0-M2
6 years ago
Josh Cummings
95f1f81010
Set Integration Test LDAP Port to Zero
...
Closes gh-8762
6 years ago
Josh Cummings
feb49ea9de
Add Timeout to Ldap Test
...
- The test intentionally points to a non-existent LDAP server; on
some machines, this will hang indefinitely without a specified
timeout.
Issue gh-2884
6 years ago
Josh Cummings
bbd2a9ebae
Revert "Lock Dependencies for 5.3.3.RELEASE"
...
This reverts commit 116bfe01e6 .
6 years ago
Josh Cummings
116bfe01e6
Lock Dependencies for 5.3.3.RELEASE
6 years ago
Evgeniy Cheban
0fa339f75b
Allow port=0 for ApacheDSContainer
...
Fixes gh-8144
6 years ago
Joe Grandja
86ca6b013c
Unlock dependencies
...
This reverts commit 206960cf44 .
6 years ago
Joe Grandja
206960cf44
Lock dependencies for 5.4.0-M1
6 years ago
Joe Grandja
413dfc8679
Unlock dependencies
...
This reverts commit a61145f74c .
6 years ago
Joe Grandja
a61145f74c
Lock dependencies for 5.3.2.RELEASE
6 years ago
Dávid Kovács
93a1fc104c
ActiveDirectoryLdapAuthenticationProvider uses InternalAuthenticationServiceException
...
Closes gh-2884
6 years ago
Dávid Kovács
f7b33da577
ActiveDirectoryLdapAuthenticationProvider uses InternalAuthenticationServiceException
...
Closes gh-2884
6 years ago
Joe Grandja
a78872f268
Unlock dependencies for 5.3.1.RELEASE
...
This reverts commit 88c02684bb .
6 years ago
Joe Grandja
88c02684bb
Lock dependencies for 5.3.1.RELEASE
6 years ago
Josh Cummings
6eadf7b140
Unlock dependencies for 5.3.0.RELEASE
...
This reverts commit 147d7dadd7 .
6 years ago
Josh Cummings
147d7dadd7
Lock dependencies for 5.3.0.RELEASE
6 years ago
Eleftheria Stein
84b8a5abd7
Unlock dependencies for next development version
...
This reverts commit 064616f1ef .
6 years ago
Eleftheria Stein
064616f1ef
Lock dependencies for 5.3.0.RC1
6 years ago
Eleftheria Stein
630eb10704
Load LDIF file from classpath in unboundId mode
...
Fixes: gh-7833
6 years ago
Eleftheria Stein
9740b5920b
Load LDIF file from classpath in unboundId mode
...
Fixes: gh-7833
6 years ago
Eleftheria Stein
fcc6457bef
Unlock dependencies for next development version
...
This reverts commit 93acf8f0f1 .
6 years ago
Eleftheria Stein
93acf8f0f1
Lock dependencies for 5.3.0.M1
6 years ago
Giovanni Lovato
63607ee213
Add configurable mapping function to map authorities
6 years ago
Roland Weisleder
f4b9abdbb1
Fix typo in Javadoc
6 years ago
Lars Grefer
34dd5fea30
Remove redundant throws clauses
...
Removes exceptions that are declared in a method's signature but never thrown by the method itself or its implementations/derivatives.
6 years ago
Lars Grefer
cb4f3d2f44
Use UTF-8 for Java sources and XML
6 years ago
Lars Grefer
ff1070df36
remove redundant modifiers found by checkstyle
6 years ago
Lars Grefer
578d628774
'Collection.toArray()' call style
6 years ago
Lars Grefer
40bee457f9
Unnecessary enum modifier
6 years ago
Eddú Meléndez
a171d8b4bf
Make ldap integration tests independent
...
Fixes gh-5942
6 years ago
Eddú Meléndez
76718c4db6
Add method getPort in ApacheDSContainer
...
Fixes gh-7236
6 years ago
Lars Grefer
fb39d9c255
Anonymous type can be replaced with lambda
6 years ago
Josh Cummings
3a831820f6
Polish LdapUserDetailsManagerModifyPasswordTests
...
Issue gh-3392
6 years ago
Lars Grefer
f5cd0ec302
Use try-with-resources instead of try-finally
6 years ago