Browse Source

fix missing access attribute validation in AuthorizationFilterParser

Fixes gh-18503

Signed-off-by: CHANHAN <130114269+chanani@users.noreply.github.com>
pull/18530/head
CHANHAN 2 months ago committed by Robert Winch
parent
commit
f1e367f93d
No known key found for this signature in database
  1. 5
      config/src/main/java/org/springframework/security/config/http/AuthorizationFilterParser.java

5
config/src/main/java/org/springframework/security/config/http/AuthorizationFilterParser.java

@ -124,6 +124,11 @@ class AuthorizationFilterParser implements BeanDefinitionParser { @@ -124,6 +124,11 @@ class AuthorizationFilterParser implements BeanDefinitionParser {
List<Element> interceptMessages = DomUtils.getChildElementsByTagName(element, Elements.INTERCEPT_URL);
for (Element interceptMessage : interceptMessages) {
String accessExpression = interceptMessage.getAttribute(ATT_ACCESS);
if (!StringUtils.hasText(accessExpression)) {
parserContext.getReaderContext()
.error("access attribute cannot be empty or null", interceptMessage);
continue;
}
BeanDefinitionBuilder authorizationManager = BeanDefinitionBuilder
.rootBeanDefinition(WebExpressionAuthorizationManager.class);
authorizationManager.addPropertyReference("expressionHandler", expressionHandlerRef);

Loading…
Cancel
Save