Browse Source

SEC-1803: Add check in AbstractAuthenticationTargetUrlRequestHandler for null targetUrlParameter before attempting to read it from the request. Prevents NPE when targetUrlParameter is not set.

3.0.x
Luke Taylor 15 years ago
parent
commit
ee74c4ced2
  1. 6
      web/src/main/java/org/springframework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandler.java

6
web/src/main/java/org/springframework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandler.java

@ -83,7 +83,11 @@ public abstract class AbstractAuthenticationTargetUrlRequestHandler { @@ -83,7 +83,11 @@ public abstract class AbstractAuthenticationTargetUrlRequestHandler {
}
// Check for the parameter and use that if available
String targetUrl = request.getParameter(targetUrlParameter);
String targetUrl = null;
if (targetUrlParameter != null) {
targetUrl = request.getParameter(targetUrlParameter);
}
if (StringUtils.hasText(targetUrl)) {
try {

Loading…
Cancel
Save