Browse Source

Re-Enable Disabled OpenSAML Tests

Issue gh-15395
pull/15685/head
Josh Cummings 2 years ago
parent
commit
ecf6cace82
No known key found for this signature in database
GPG Key ID: A306A51F43B8E5A5
  1. 6
      saml2/saml2-service-provider/src/opensaml4Test/java/org/springframework/security/saml2/provider/service/registration/OpenSaml4AssertingPartyMetadataRepositoryTests.java
  2. 6
      saml2/saml2-service-provider/src/opensaml5Test/java/org/springframework/security/saml2/provider/service/registration/OpenSaml5AssertingPartyMetadataRepositoryTests.java

6
saml2/saml2-service-provider/src/opensaml4Test/java/org/springframework/security/saml2/provider/service/registration/OpenSaml4AssertingPartyMetadataRepositoryTests.java

@ -37,7 +37,6 @@ import okhttp3.mockwebserver.MockWebServer; @@ -37,7 +37,6 @@ import okhttp3.mockwebserver.MockWebServer;
import okhttp3.mockwebserver.RecordedRequest;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.opensaml.core.xml.XMLObject;
import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
@ -106,7 +105,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests { @@ -106,7 +105,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() throws Exception {
AssertingPartyMetadataRepository parties = OpenSaml4AssertingPartyMetadataRepository
.withTrustedMetadataLocation(web.url("/entity.xml").toString())
@ -121,7 +119,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests { @@ -121,7 +119,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withMetadataUrlLocationnWhenResolvableThenIteratorReturns() throws Exception {
List<AssertingPartyMetadata> parties = new ArrayList<>();
OpenSaml4AssertingPartyMetadataRepository.withTrustedMetadataLocation(web.url("/entities.xml").toString())
@ -218,7 +215,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests { @@ -218,7 +215,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@ -237,7 +233,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests { @@ -237,7 +233,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withTrustedMetadataLocationWhenMismatchingCredentialsThenSaml2Exception() throws IOException {
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@ -332,7 +327,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests { @@ -332,7 +327,6 @@ public class OpenSaml4AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);

6
saml2/saml2-service-provider/src/opensaml5Test/java/org/springframework/security/saml2/provider/service/registration/OpenSaml5AssertingPartyMetadataRepositoryTests.java

@ -37,7 +37,6 @@ import okhttp3.mockwebserver.MockWebServer; @@ -37,7 +37,6 @@ import okhttp3.mockwebserver.MockWebServer;
import okhttp3.mockwebserver.RecordedRequest;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.opensaml.core.xml.XMLObject;
import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
@ -106,7 +105,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests { @@ -106,7 +105,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() throws Exception {
AssertingPartyMetadataRepository parties = OpenSaml5AssertingPartyMetadataRepository
.withTrustedMetadataLocation(web.url("/entity.xml").toString())
@ -121,7 +119,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests { @@ -121,7 +119,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withMetadataUrlLocationnWhenResolvableThenIteratorReturns() throws Exception {
List<AssertingPartyMetadata> parties = new ArrayList<>();
OpenSaml5AssertingPartyMetadataRepository.withTrustedMetadataLocation(web.url("/entities.xml").toString())
@ -218,7 +215,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests { @@ -218,7 +215,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@ -237,7 +233,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests { @@ -237,7 +233,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withTrustedMetadataLocationWhenMismatchingCredentialsThenSaml2Exception() throws IOException {
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@ -332,7 +327,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests { @@ -332,7 +327,6 @@ public class OpenSaml5AssertingPartyMetadataRepositoryTests {
}
@Test
@Disabled("See gh-15395")
public void withMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);

Loading…
Cancel
Save