Browse Source

Polish ForwardAuthenticationFailureHandler

* Whitespace cleanup
* Add @since

Issue gh-3727
pull/257/merge
Rob Winch 10 years ago
parent
commit
e61bc7e93b
  1. 7
      web/src/main/java/org/springframework/security/web/authentication/ForwardAuthenticationFailureHandler.java
  2. 4
      web/src/test/java/org/springframework/security/web/authentication/ForwardAuthenticationFailureHandlerTests.java

7
web/src/main/java/org/springframework/security/web/authentication/ForwardAuthenticationFailureHandler.java

@ -31,7 +31,7 @@ import java.io.IOException; @@ -31,7 +31,7 @@ import java.io.IOException;
* </p>
*
* @author Shazin Sadakath
*
* @since 4.1
*/
public class ForwardAuthenticationFailureHandler implements AuthenticationFailureHandler {
@ -41,12 +41,11 @@ public class ForwardAuthenticationFailureHandler implements AuthenticationFailur @@ -41,12 +41,11 @@ public class ForwardAuthenticationFailureHandler implements AuthenticationFailur
* @param forwardUrl
*/
public ForwardAuthenticationFailureHandler(String forwardUrl) {
Assert.isTrue(UrlUtils.isValidRedirectUrl(forwardUrl), "'"
+ forwardUrl + "' is not a valid forward URL");
Assert.isTrue(UrlUtils.isValidRedirectUrl(forwardUrl), "'"
+ forwardUrl + "' is not a valid forward URL");
this.forwardUrl = forwardUrl;
}
@Override
public void onAuthenticationFailure(HttpServletRequest request, HttpServletResponse response, AuthenticationException exception) throws IOException, ServletException {
request.setAttribute(WebAttributes.AUTHENTICATION_EXCEPTION, exception);
request.getRequestDispatcher(forwardUrl).forward(request, response);

4
web/src/test/java/org/springframework/security/web/authentication/ForwardAuthenticationFailureHandlerTests.java

@ -30,7 +30,7 @@ import static org.mockito.Mockito.mock; @@ -30,7 +30,7 @@ import static org.mockito.Mockito.mock;
* </p>
*
* @author Shazin Sadakath
*
* @since4.1
*/
public class ForwardAuthenticationFailureHandlerTests {
@ -55,6 +55,6 @@ public class ForwardAuthenticationFailureHandlerTests { @@ -55,6 +55,6 @@ public class ForwardAuthenticationFailureHandlerTests {
fafh.onAuthenticationFailure(request, response, e);
assertThat(response.getForwardedUrl()).isEqualTo("/forwardUrl");
assertThat(request.getAttribute(WebAttributes.AUTHENTICATION_EXCEPTION)).isEqualTo(e);
assertThat(request.getAttribute(WebAttributes.AUTHENTICATION_EXCEPTION)).isEqualTo(e);
}
}

Loading…
Cancel
Save