Browse Source

Remove address and phone from default scope for Google

Fixes gh-4895
pull/4918/head
Kazuki Shimizu 8 years ago committed by Joe Grandja
parent
commit
9f6af4f3b8
  1. 2
      config/src/main/java/org/springframework/security/config/oauth2/client/CommonOAuth2Provider.java
  2. 3
      config/src/test/java/org/springframework/security/config/oauth2/client/CommonOAuth2ProviderTests.java

2
config/src/main/java/org/springframework/security/config/oauth2/client/CommonOAuth2Provider.java

@ -37,7 +37,7 @@ public enum CommonOAuth2Provider {
public Builder getBuilder(String registrationId) { public Builder getBuilder(String registrationId) {
ClientRegistration.Builder builder = getBuilder(registrationId, ClientRegistration.Builder builder = getBuilder(registrationId,
ClientAuthenticationMethod.BASIC, DEFAULT_LOGIN_REDIRECT_URL); ClientAuthenticationMethod.BASIC, DEFAULT_LOGIN_REDIRECT_URL);
builder.scope("openid", "profile", "email", "address", "phone"); builder.scope("openid", "profile", "email");
builder.authorizationUri("https://accounts.google.com/o/oauth2/v2/auth"); builder.authorizationUri("https://accounts.google.com/o/oauth2/v2/auth");
builder.tokenUri("https://www.googleapis.com/oauth2/v4/token"); builder.tokenUri("https://www.googleapis.com/oauth2/v4/token");
builder.jwkSetUri("https://www.googleapis.com/oauth2/v3/certs"); builder.jwkSetUri("https://www.googleapis.com/oauth2/v3/certs");

3
config/src/test/java/org/springframework/security/config/oauth2/client/CommonOAuth2ProviderTests.java

@ -52,8 +52,7 @@ public class CommonOAuth2ProviderTests {
assertThat(registration.getAuthorizationGrantType()) assertThat(registration.getAuthorizationGrantType())
.isEqualTo(AuthorizationGrantType.AUTHORIZATION_CODE); .isEqualTo(AuthorizationGrantType.AUTHORIZATION_CODE);
assertThat(registration.getRedirectUriTemplate()).isEqualTo(DEFAULT_LOGIN_REDIRECT_URL); assertThat(registration.getRedirectUriTemplate()).isEqualTo(DEFAULT_LOGIN_REDIRECT_URL);
assertThat(registration.getScopes()).containsOnly("openid", "profile", "email", assertThat(registration.getScopes()).containsOnly("openid", "profile", "email");
"address", "phone");
assertThat(registration.getClientName()).isEqualTo("Google"); assertThat(registration.getClientName()).isEqualTo("Google");
assertThat(registration.getRegistrationId()).isEqualTo("123"); assertThat(registration.getRegistrationId()).isEqualTo("123");
} }

Loading…
Cancel
Save