From 921157cdcda6e13d9dbf29a1217b85c06e0438fc Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Sat, 18 Nov 2017 10:15:19 +0900 Subject: [PATCH] Remove explicit super() calls --- .../configurers/oauth2/client/OAuth2LoginConfigurer.java | 4 ---- .../config/annotation/SecurityConfigurerAdapterTests.java | 1 - .../org/springframework/security/config/method/Contact.java | 3 +-- .../security/core/context/SecurityContextImplTests.java | 6 ------ .../webflux-form/src/main/java/sample/ThymeleafConfig.java | 1 - samples/xml/dms/src/main/java/sample/dms/Directory.java | 1 - .../web/access/expression/DelegatingEvaluationContext.java | 1 - .../security/web/csrf/LazyCsrfTokenRepository.java | 1 - .../security/web/header/writers/HpkpHeaderWriter.java | 1 - .../security/web/header/writers/HstsHeaderWriter.java | 1 - .../web/server/header/HttpHeaderWriterWebFilter.java | 1 - .../springframework/security/web/PortResolverImplTests.java | 6 ------ 12 files changed, 1 insertion(+), 26 deletions(-) diff --git a/config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/client/OAuth2LoginConfigurer.java b/config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/client/OAuth2LoginConfigurer.java index 30972c3724..e8dfb0e214 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/client/OAuth2LoginConfigurer.java +++ b/config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/client/OAuth2LoginConfigurer.java @@ -76,10 +76,6 @@ public final class OAuth2LoginConfigurer> exten private final UserInfoEndpointConfig userInfoEndpointConfig = new UserInfoEndpointConfig(); private String loginPage; - public OAuth2LoginConfigurer() { - super(); - } - public OAuth2LoginConfigurer clientRegistrationRepository(ClientRegistrationRepository clientRegistrationRepository) { Assert.notNull(clientRegistrationRepository, "clientRegistrationRepository cannot be null"); this.getBuilder().setSharedObject(ClientRegistrationRepository.class, clientRegistrationRepository); diff --git a/config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java b/config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java index 6376e3facb..61158e2f43 100644 --- a/config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java +++ b/config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java @@ -42,7 +42,6 @@ public class SecurityConfigurerAdapterTests { private final int order; public OrderedObjectPostProcessor(int order) { - super(); this.order = order; } diff --git a/config/src/test/java/org/springframework/security/config/method/Contact.java b/config/src/test/java/org/springframework/security/config/method/Contact.java index 12f3e433bd..50186107d9 100644 --- a/config/src/test/java/org/springframework/security/config/method/Contact.java +++ b/config/src/test/java/org/springframework/security/config/method/Contact.java @@ -26,7 +26,6 @@ public class Contact { * @param name */ public Contact(String name) { - super(); this.name = name; } @@ -36,4 +35,4 @@ public class Contact { public String getName() { return name; } -} \ No newline at end of file +} diff --git a/core/src/test/java/org/springframework/security/core/context/SecurityContextImplTests.java b/core/src/test/java/org/springframework/security/core/context/SecurityContextImplTests.java index 2d6959aeb4..ffcc523009 100644 --- a/core/src/test/java/org/springframework/security/core/context/SecurityContextImplTests.java +++ b/core/src/test/java/org/springframework/security/core/context/SecurityContextImplTests.java @@ -28,12 +28,6 @@ import org.springframework.security.core.Authentication; * @author Ben Alex */ public class SecurityContextImplTests { - // ~ Constructors - // =================================================================================================== - - public SecurityContextImplTests() { - super(); - } // ~ Methods // ======================================================================================================== diff --git a/samples/javaconfig/webflux-form/src/main/java/sample/ThymeleafConfig.java b/samples/javaconfig/webflux-form/src/main/java/sample/ThymeleafConfig.java index 6a37a82a05..8ea1e8e3b1 100644 --- a/samples/javaconfig/webflux-form/src/main/java/sample/ThymeleafConfig.java +++ b/samples/javaconfig/webflux-form/src/main/java/sample/ThymeleafConfig.java @@ -36,7 +36,6 @@ public class ThymeleafConfig implements WebFluxConfigurer { private ApplicationContext applicationContext; public ThymeleafConfig(final ApplicationContext applicationContext) { - super(); this.applicationContext = applicationContext; } diff --git a/samples/xml/dms/src/main/java/sample/dms/Directory.java b/samples/xml/dms/src/main/java/sample/dms/Directory.java index 6808bb2df9..0d6b3d2bef 100755 --- a/samples/xml/dms/src/main/java/sample/dms/Directory.java +++ b/samples/xml/dms/src/main/java/sample/dms/Directory.java @@ -24,7 +24,6 @@ public class Directory extends AbstractElement { public static final Directory ROOT_DIRECTORY = new Directory(); private Directory() { - super(); } public Directory(String name, Directory parent) { diff --git a/web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java b/web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java index efa9868329..4a49481c32 100644 --- a/web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java +++ b/web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java @@ -39,7 +39,6 @@ class DelegatingEvaluationContext implements EvaluationContext { private final EvaluationContext delegate; public DelegatingEvaluationContext(EvaluationContext delegate) { - super(); this.delegate = delegate; } diff --git a/web/src/main/java/org/springframework/security/web/csrf/LazyCsrfTokenRepository.java b/web/src/main/java/org/springframework/security/web/csrf/LazyCsrfTokenRepository.java index 5d726b7f38..f3ca17b90c 100644 --- a/web/src/main/java/org/springframework/security/web/csrf/LazyCsrfTokenRepository.java +++ b/web/src/main/java/org/springframework/security/web/csrf/LazyCsrfTokenRepository.java @@ -106,7 +106,6 @@ public final class LazyCsrfTokenRepository implements CsrfTokenRepository { SaveOnAccessCsrfToken(CsrfTokenRepository tokenRepository, HttpServletRequest request, HttpServletResponse response, CsrfToken delegate) { - super(); this.tokenRepository = tokenRepository; this.request = request; this.response = response; diff --git a/web/src/main/java/org/springframework/security/web/header/writers/HpkpHeaderWriter.java b/web/src/main/java/org/springframework/security/web/header/writers/HpkpHeaderWriter.java index e9cd6481ce..b0ad6897f8 100644 --- a/web/src/main/java/org/springframework/security/web/header/writers/HpkpHeaderWriter.java +++ b/web/src/main/java/org/springframework/security/web/header/writers/HpkpHeaderWriter.java @@ -133,7 +133,6 @@ public final class HpkpHeaderWriter implements HeaderWriter { * @param reportOnly maps to {@link #setReportOnly(boolean)} */ public HpkpHeaderWriter(long maxAgeInSeconds, boolean includeSubDomains, boolean reportOnly) { - super(); this.maxAgeInSeconds = maxAgeInSeconds; this.includeSubDomains = includeSubDomains; this.reportOnly = reportOnly; diff --git a/web/src/main/java/org/springframework/security/web/header/writers/HstsHeaderWriter.java b/web/src/main/java/org/springframework/security/web/header/writers/HstsHeaderWriter.java index 3e877c4522..0a8f23d803 100644 --- a/web/src/main/java/org/springframework/security/web/header/writers/HstsHeaderWriter.java +++ b/web/src/main/java/org/springframework/security/web/header/writers/HstsHeaderWriter.java @@ -73,7 +73,6 @@ public final class HstsHeaderWriter implements HeaderWriter { */ public HstsHeaderWriter(RequestMatcher requestMatcher, long maxAgeInSeconds, boolean includeSubDomains) { - super(); this.requestMatcher = requestMatcher; this.maxAgeInSeconds = maxAgeInSeconds; this.includeSubDomains = includeSubDomains; diff --git a/web/src/main/java/org/springframework/security/web/server/header/HttpHeaderWriterWebFilter.java b/web/src/main/java/org/springframework/security/web/server/header/HttpHeaderWriterWebFilter.java index e127e4b370..642eb6ae5b 100644 --- a/web/src/main/java/org/springframework/security/web/server/header/HttpHeaderWriterWebFilter.java +++ b/web/src/main/java/org/springframework/security/web/server/header/HttpHeaderWriterWebFilter.java @@ -33,7 +33,6 @@ public class HttpHeaderWriterWebFilter implements WebFilter { private final ServerHttpHeadersWriter writer; public HttpHeaderWriterWebFilter(ServerHttpHeadersWriter writer) { - super(); this.writer = writer; } diff --git a/web/src/test/java/org/springframework/security/web/PortResolverImplTests.java b/web/src/test/java/org/springframework/security/web/PortResolverImplTests.java index 869f98debb..8020a8f3dc 100644 --- a/web/src/test/java/org/springframework/security/web/PortResolverImplTests.java +++ b/web/src/test/java/org/springframework/security/web/PortResolverImplTests.java @@ -28,12 +28,6 @@ import org.springframework.mock.web.MockHttpServletRequest; * @author Ben Alex */ public class PortResolverImplTests { - // ~ Constructors - // =================================================================================================== - - public PortResolverImplTests() { - super(); - } // ~ Methods // ========================================================================================================