Browse Source

Fix StrictHttpFirewall rules

Fixes: gh-5092
pull/5095/head
Rob Winch 8 years ago
parent
commit
8f8deac0f4
  1. 2
      web/src/main/java/org/springframework/security/web/firewall/StrictHttpFirewall.java
  2. 3
      web/src/test/java/org/springframework/security/web/firewall/StrictHttpFirewallTests.java

2
web/src/main/java/org/springframework/security/web/firewall/StrictHttpFirewall.java

@ -340,7 +340,7 @@ public class StrictHttpFirewall implements HttpFirewall { @@ -340,7 +340,7 @@ public class StrictHttpFirewall implements HttpFirewall {
return true;
}
if (path.indexOf("//") > 0) {
if (path.indexOf("//") > -1) {
return false;
}

3
web/src/test/java/org/springframework/security/web/firewall/StrictHttpFirewallTests.java

@ -26,7 +26,8 @@ import static org.assertj.core.api.Assertions.fail; @@ -26,7 +26,8 @@ import static org.assertj.core.api.Assertions.fail;
*/
public class StrictHttpFirewallTests {
public String[] unnormalizedPaths = { "/..", "/./path/", "/path/path/.", "/path/path//.", "./path/../path//.",
"./path", ".//path", ".", "/path//" };
"./path", ".//path", ".", "//path", "//path/path", "//path//path", "/path//path" };
private StrictHttpFirewall firewall = new StrictHttpFirewall();

Loading…
Cancel
Save