From 7313d5def0bb5dfdd49a119ca1dfe4ba80c5bcf9 Mon Sep 17 00:00:00 2001 From: Ben Alex Date: Fri, 15 Sep 2006 07:55:57 +0000 Subject: [PATCH] SEC-324: Ensure IllegalStateException no longer occurs. --- .../ui/AccessDeniedHandlerImpl.java | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/core/src/main/java/org/acegisecurity/ui/AccessDeniedHandlerImpl.java b/core/src/main/java/org/acegisecurity/ui/AccessDeniedHandlerImpl.java index c29e0b252e..8b35bb1d50 100644 --- a/core/src/main/java/org/acegisecurity/ui/AccessDeniedHandlerImpl.java +++ b/core/src/main/java/org/acegisecurity/ui/AccessDeniedHandlerImpl.java @@ -62,21 +62,13 @@ public class AccessDeniedHandlerImpl implements AccessDeniedHandler { // Perform RequestDispatcher "forward" RequestDispatcher rd = request.getRequestDispatcher(errorPage); - - try { - rd.forward(request, response); - ((HttpServletResponse) response).setStatus(HttpServletResponse.SC_FORBIDDEN); - - return; - } catch (Exception responseCommitted) { - if (logger.isErrorEnabled()) { - logger.error("Error processing " + request.toString(), responseCommitted); - } - } + rd.forward(request, response); } - // Send 403 (we do this after response has been written) - ((HttpServletResponse) response).sendError(HttpServletResponse.SC_FORBIDDEN, accessDeniedException.getMessage()); + if (!response.isCommitted()) { + // Send 403 (we do this after response has been written) + ((HttpServletResponse) response).sendError(HttpServletResponse.SC_FORBIDDEN, accessDeniedException.getMessage()); + } } /**