Browse Source

Use Duration for calculating validity

This improves readability.

Issue gh-15735
pull/15875/head
Rob Winch 1 year ago
parent
commit
650ec3ba82
  1. 3
      core/src/main/java/org/springframework/security/authentication/ott/JdbcOneTimeTokenService.java

3
core/src/main/java/org/springframework/security/authentication/ott/JdbcOneTimeTokenService.java

@ -21,6 +21,7 @@ import java.sql.SQLException;
import java.sql.Timestamp; import java.sql.Timestamp;
import java.sql.Types; import java.sql.Types;
import java.time.Clock; import java.time.Clock;
import java.time.Duration;
import java.time.Instant; import java.time.Instant;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@ -131,7 +132,7 @@ public final class JdbcOneTimeTokenService implements OneTimeTokenService, Dispo
public OneTimeToken generate(GenerateOneTimeTokenRequest request) { public OneTimeToken generate(GenerateOneTimeTokenRequest request) {
Assert.notNull(request, "generateOneTimeTokenRequest cannot be null"); Assert.notNull(request, "generateOneTimeTokenRequest cannot be null");
String token = UUID.randomUUID().toString(); String token = UUID.randomUUID().toString();
Instant fiveMinutesFromNow = this.clock.instant().plusSeconds(300); Instant fiveMinutesFromNow = this.clock.instant().plus(Duration.ofMinutes(5));
OneTimeToken oneTimeToken = new DefaultOneTimeToken(token, request.getUsername(), fiveMinutesFromNow); OneTimeToken oneTimeToken = new DefaultOneTimeToken(token, request.getUsername(), fiveMinutesFromNow);
insertOneTimeToken(oneTimeToken); insertOneTimeToken(oneTimeToken);
return oneTimeToken; return oneTimeToken;

Loading…
Cancel
Save