Browse Source

GitHubMilestoneApiTests due_on Uses LocalDate

`GitHubMilestoneApiTests` uses `Instant.now()` for `due_on`. Since
`Instant.now()` is UTC time based,
`isMilestoneDueTodayWhenDueTodayThenTrue` fails when the computer that runs
the test is not the same day as it is in UTC time.

To fix it, `due_on` should be set to an `Instant` based upon the timezone
of the current computer.

Closes gh-11706
pull/11720/head
Rob Winch 3 years ago
parent
commit
4473c3f7d0
  1. 3
      buildSrc/src/test/java/org/springframework/gradle/github/milestones/GitHubMilestoneApiTests.java

3
buildSrc/src/test/java/org/springframework/gradle/github/milestones/GitHubMilestoneApiTests.java

@ -4,6 +4,7 @@ import java.nio.charset.Charset; @@ -4,6 +4,7 @@ import java.nio.charset.Charset;
import java.time.Instant;
import java.time.LocalDate;
import java.time.LocalTime;
import java.time.ZoneId;
import java.util.concurrent.TimeUnit;
import okhttp3.mockwebserver.MockResponse;
@ -636,7 +637,7 @@ public class GitHubMilestoneApiTests { @@ -636,7 +637,7 @@ public class GitHubMilestoneApiTests {
" \"state\":\"open\",\n" +
" \"created_at\":\"2020-09-16T13:28:03Z\",\n" +
" \"updated_at\":\"2021-04-06T23:47:10Z\",\n" +
" \"due_on\":\"" + Instant.now().toString() + "\",\n" +
" \"due_on\":\"" + LocalDate.now().atStartOfDay(ZoneId.systemDefault()).toInstant().toString() + "\",\n" +
" \"closed_at\":null\n" +
" }\n" +
"]";

Loading…
Cancel
Save