From 2d3606284694c9e81edeb219fad984c8574cff8c Mon Sep 17 00:00:00 2001
From: Karel Maxa <karel.maxa@orchitech.cz>
Date: Thu, 11 Jul 2019 15:37:34 +0200
Subject: [PATCH] Remove unnecessary authority comparison.

Issue: gh-7035
---
 .../security/access/hierarchicalroles/RoleHierarchyImpl.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyImpl.java b/core/src/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyImpl.java
index d78355f517..1bdc0e3fb2 100755
--- a/core/src/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyImpl.java
+++ b/core/src/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyImpl.java
@@ -192,7 +192,7 @@ public class RoleHierarchyImpl implements RoleHierarchy {
 					} else {
 						rolesReachableInOneStepSet = this.rolesReachableInOneStepMap.get(higherRole);
 					}
-					addReachableRoles(rolesReachableInOneStepSet, lowerRole);
+					rolesReachableInOneStepSet.add(lowerRole);
 					if (logger.isDebugEnabled()) {
 						logger.debug("buildRolesReachableInOneStepMap() - From role " + higherRole
 								+ " one can reach role " + lowerRole + " in one step.");
@@ -227,7 +227,7 @@ public class RoleHierarchyImpl implements RoleHierarchy {
 				// take a role from the rolesToVisit set
 				GrantedAuthority aRole = rolesToVisitSet.iterator().next();
 				rolesToVisitSet.remove(aRole);
-				addReachableRoles(visitedRolesSet, aRole);
+				visitedRolesSet.add(aRole);
 				if (this.rolesReachableInOneStepMap.containsKey(aRole)) {
 					Set<GrantedAuthority> newReachableRoles = this.rolesReachableInOneStepMap
 							.get(aRole);