From 26ad1cb4a5c8a8b1f8554566a08b5900bd85b235 Mon Sep 17 00:00:00 2001 From: Rob Winch Date: Tue, 21 Jun 2016 14:56:23 -0500 Subject: [PATCH] Polish RememberMe Validation Issue gh-3909 --- .../web/configurers/RememberMeConfigurer.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/config/src/main/java/org/springframework/security/config/annotation/web/configurers/RememberMeConfigurer.java b/config/src/main/java/org/springframework/security/config/annotation/web/configurers/RememberMeConfigurer.java index 76d7fa0137..6b7b8f0b11 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/web/configurers/RememberMeConfigurer.java +++ b/config/src/main/java/org/springframework/security/config/annotation/web/configurers/RememberMeConfigurer.java @@ -79,13 +79,16 @@ import org.springframework.security.web.authentication.ui.DefaultLoginPageGenera */ public final class RememberMeConfigurer> extends AbstractHttpConfigurer, H> { - public static final String REMEMBER_ME = "remember-me"; + /** + * The default name for remember me parameter name and remember me cookie name + */ + private static final String DEFAULT_REMEMBER_ME_NAME = "remember-me"; private AuthenticationSuccessHandler authenticationSuccessHandler; private String key; private RememberMeServices rememberMeServices; private LogoutHandler logoutHandler; - private String rememberMeParameter = REMEMBER_ME; - private String rememberMeCookieName = REMEMBER_ME; + private String rememberMeParameter = DEFAULT_REMEMBER_ME_NAME; + private String rememberMeCookieName = DEFAULT_REMEMBER_ME_NAME; private String rememberMeCookieDomain; private PersistentTokenRepository tokenRepository; private UserDetailsService userDetailsService; @@ -280,7 +283,7 @@ public final class RememberMeConfigurer> * the same time. */ private void validateInput() { - if (this.rememberMeServices != null && this.rememberMeCookieName != REMEMBER_ME) { + if (this.rememberMeServices != null && this.rememberMeCookieName != DEFAULT_REMEMBER_ME_NAME) { throw new IllegalArgumentException("Can not set rememberMeCookieName " + "and custom rememberMeServices."); }