Browse Source

Improve null handling.

1.0.x
Ben Alex 22 years ago
parent
commit
22f8cd0c44
  1. 10
      core/src/main/java/org/acegisecurity/providers/dao/DaoAuthenticationProvider.java

10
core/src/main/java/org/acegisecurity/providers/dao/DaoAuthenticationProvider.java

@ -203,7 +203,11 @@ public class DaoAuthenticationProvider implements AuthenticationProvider, @@ -203,7 +203,11 @@ public class DaoAuthenticationProvider implements AuthenticationProvider,
public Authentication authenticate(Authentication authentication)
throws AuthenticationException {
// Determine username
String username = authentication.getPrincipal().toString();
String username = "NONE_PROVIDED";
if (authentication.getPrincipal() != null) {
username = authentication.getPrincipal().toString();
}
if (authentication.getPrincipal() instanceof UserDetails) {
username = ((UserDetails) authentication.getPrincipal())
@ -220,10 +224,6 @@ public class DaoAuthenticationProvider implements AuthenticationProvider, @@ -220,10 +224,6 @@ public class DaoAuthenticationProvider implements AuthenticationProvider,
user = getUserFromBackend(username);
} catch (BadCredentialsException ex) {
if (this.context != null) {
if ((username == null) || "".equals(username)) {
username = "NONE_PROVIDED";
}
context.publishEvent(new AuthenticationFailureUsernameNotFoundEvent(
authentication,
new User(username, "*****", false,

Loading…
Cancel
Save