Browse Source

Added eclipse plugin to build. Some minor fixes to remove eclipse warnings.

pull/1/head
Luke Taylor 16 years ago
parent
commit
1680807470
  1. 1
      build.gradle
  2. 2
      core/src/main/java/org/springframework/security/authentication/AuthenticationDetailsSourceImpl.java
  3. 1
      itest/context/src/main/java/org/springframework/security/integration/python/PythonInterpreterPreInvocationAdvice.java
  4. 2
      web/src/main/java/org/springframework/security/web/authentication/preauth/websphere/WebSphere2SpringSecurityPropagationInterceptor.java
  5. 2
      web/src/main/java/org/springframework/security/web/authentication/switchuser/SwitchUserFilter.java
  6. 3
      web/src/test/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServicesTests.java

1
build.gradle

@ -46,6 +46,7 @@ apply plugin: 'idea'
configure(javaProjects) { configure(javaProjects) {
apply plugin: 'idea' apply plugin: 'idea'
apply plugin: 'eclipse'
ideaModule { ideaModule {
downloadJavadoc=false downloadJavadoc=false
excludeDirs.add(buildDir) excludeDirs.add(buildDir)

2
core/src/main/java/org/springframework/security/authentication/AuthenticationDetailsSourceImpl.java

@ -18,7 +18,7 @@ import java.lang.reflect.Constructor;
* @deprecated Write an implementation of AuthenticationDetailsSource which returns the desired type directly. * @deprecated Write an implementation of AuthenticationDetailsSource which returns the desired type directly.
*/ */
@Deprecated @Deprecated
public class AuthenticationDetailsSourceImpl implements AuthenticationDetailsSource { public class AuthenticationDetailsSourceImpl implements AuthenticationDetailsSource<Object, Object> {
//~ Instance fields ================================================================================================ //~ Instance fields ================================================================================================
private Class<?> clazz = AuthenticationDetails.class; private Class<?> clazz = AuthenticationDetails.class;

1
itest/context/src/main/java/org/springframework/security/integration/python/PythonInterpreterPreInvocationAdvice.java

@ -21,7 +21,6 @@ import org.springframework.util.ClassUtils;
public class PythonInterpreterPreInvocationAdvice implements PreInvocationAuthorizationAdvice{ public class PythonInterpreterPreInvocationAdvice implements PreInvocationAuthorizationAdvice{
private final ParameterNameDiscoverer parameterNameDiscoverer = new LocalVariableTableParameterNameDiscoverer(); private final ParameterNameDiscoverer parameterNameDiscoverer = new LocalVariableTableParameterNameDiscoverer();
@SuppressWarnings("deprecation")
public boolean before(Authentication authentication, MethodInvocation mi, PreInvocationAttribute preAttr) { public boolean before(Authentication authentication, MethodInvocation mi, PreInvocationAttribute preAttr) {
PythonInterpreterPreInvocationAttribute pythonAttr = (PythonInterpreterPreInvocationAttribute) preAttr; PythonInterpreterPreInvocationAttribute pythonAttr = (PythonInterpreterPreInvocationAttribute) preAttr;
String script = pythonAttr.getScript(); String script = pythonAttr.getScript();

2
web/src/main/java/org/springframework/security/web/authentication/preauth/websphere/WebSphere2SpringSecurityPropagationInterceptor.java

@ -78,7 +78,7 @@ public class WebSphere2SpringSecurityPropagationInterceptor implements MethodInt
/** /**
* @param authenticationDetailsSource The authenticationDetailsSource to set. * @param authenticationDetailsSource The authenticationDetailsSource to set.
*/ */
public void setAuthenticationDetailsSource(AuthenticationDetailsSource authenticationDetailsSource) { public void setAuthenticationDetailsSource(AuthenticationDetailsSource<?,?> authenticationDetailsSource) {
this.authenticationDetailsSource = authenticationDetailsSource; this.authenticationDetailsSource = authenticationDetailsSource;
} }
} }

2
web/src/main/java/org/springframework/security/web/authentication/switchuser/SwitchUserFilter.java

@ -372,7 +372,7 @@ public class SwitchUserFilter extends GenericFilterBean implements ApplicationEv
this.eventPublisher = eventPublisher; this.eventPublisher = eventPublisher;
} }
public void setAuthenticationDetailsSource(AuthenticationDetailsSource authenticationDetailsSource) { public void setAuthenticationDetailsSource(AuthenticationDetailsSource<HttpServletRequest,?> authenticationDetailsSource) {
Assert.notNull(authenticationDetailsSource, "AuthenticationDetailsSource required"); Assert.notNull(authenticationDetailsSource, "AuthenticationDetailsSource required");
this.authenticationDetailsSource = authenticationDetailsSource; this.authenticationDetailsSource = authenticationDetailsSource;
} }

3
web/src/test/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServicesTests.java

@ -27,6 +27,7 @@ import org.springframework.util.StringUtils;
/** /**
* @author Luke Taylor * @author Luke Taylor
*/ */
@SuppressWarnings("unchecked")
public class AbstractRememberMeServicesTests { public class AbstractRememberMeServicesTests {
static User joe = new User("joe", "password", true, true,true,true, AuthorityUtils.createAuthorityList("ROLE_A")); static User joe = new User("joe", "password", true, true,true,true, AuthorityUtils.createAuthorityList("ROLE_A"));
@ -35,7 +36,7 @@ public class AbstractRememberMeServicesTests {
new MockRememberMeServices().decodeCookie("nonBase64CookieValue%"); new MockRememberMeServices().decodeCookie("nonBase64CookieValue%");
} }
@Test @Test
public void setAndGetAreConsistent() throws Exception { public void setAndGetAreConsistent() throws Exception {
MockRememberMeServices services = new MockRememberMeServices(); MockRememberMeServices services = new MockRememberMeServices();
assertNotNull(services.getCookieName()); assertNotNull(services.getCookieName());

Loading…
Cancel
Save