spring-framework

Spring Framework

Tree: f3f05da39b

Sam Brannen 7606a929c9 Fail build for JUnit discovery issues JUnit 5.13 introduced support for Discovery Issues which typically indicate configuration errors in tests that may result in unexpected behavior. Furthermore, discovery issues that are currently reported at INFO level may later be reported at WARNING or ERROR level -- for example, in JUnit 6. In order to ensure that our test suite does not suffer from such potential errors, this commit sets the junit.platform.discovery.issue.severity.critical JVM system property to INFO (instead of leaving it with the default ERROR configuration). Doing so aligns with our build configuration which fails the build for selected warnings in Java source code and Javadoc. If we later determine that INFO causes unnecessary issues for us, we can switch to WARNING. This commit also removes two "intentionally invalid" test cases from AutowiredConfigurationErrorsIntegrationTests, since those test cases are now reported as invalid as of JUnit 5.13. Closes gh-35107	10 months ago
..
main/java/org/springframework/build	Fail build for JUnit discovery issues	10 months ago
test/java/org/springframework/build/multirelease	Update copyright headers in source files	10 months ago

Sam Brannen 7606a929c9 Fail build for JUnit discovery issues

JUnit 5.13 introduced support for Discovery Issues which typically
indicate configuration errors in tests that may result in unexpected
behavior.

Furthermore, discovery issues that are currently reported at INFO level
may later be reported at WARNING or ERROR level -- for example, in
JUnit 6.

In order to ensure that our test suite does not suffer from such
potential errors, this commit sets the
junit.platform.discovery.issue.severity.critical JVM system property to
INFO (instead of leaving it with the default ERROR configuration).

Doing so aligns with our build configuration which fails the build for
selected warnings in Java source code and Javadoc.

If we later determine that INFO causes unnecessary issues for us, we
can switch to WARNING.

This commit also removes two "intentionally invalid" test cases from
AutowiredConfigurationErrorsIntegrationTests, since those test cases
are now reported as invalid as of JUnit 5.13.

Closes gh-35107

10 months ago

main/java/org/springframework/build

Fail build for JUnit discovery issues

10 months ago

test/java/org/springframework/build/multirelease

Update copyright headers in source files

10 months ago