spring-framework

Spring Framework

Tree: cd0379a67f

Brian Clozel 01f97887ea Improve WebClient observations handling of CANCEL signal Prior to this commit, `WebClient` observations would be recorded as aborted (with tags "outcome":"UNKNOWN", "status":"CLIENT_ERROR") for use cases like this: ``` Flux<String> result = client.get() .uri("/path") .retrieve() .bodyToFlux(String.class) .take(1); ``` This is due to operators like `take` or `next` that consume some `onNext` signals and then cancels the subscription before completion. This means the subscriber is only partially interested in the response and we should not count this as a client error. This commit ensures that observations are only recorded as aborted if the response was not published at the time the CANCEL signal was received. The code snippet above will now publish observations with "outcome":"SUCCESS" and "status":"200" tags, for example. Closes gh-30070	3 years ago
..
src	Improve WebClient observations handling of CANCEL signal	3 years ago
spring-webflux.gradle	Refine generic type management in AbstractMessageWriterResultHandler	3 years ago

Brian Clozel 01f97887ea Improve WebClient observations handling of CANCEL signal

Prior to this commit, `WebClient` observations would be recorded as
aborted (with tags "outcome":"UNKNOWN", "status":"CLIENT_ERROR")
for use cases like this:

```
Flux<String> result = client.get()
    .uri("/path")
    .retrieve()
    .bodyToFlux(String.class)
    .take(1);
```

This is due to operators like `take` or `next` that consume *some*
`onNext` signals and then cancels the subscription before completion.
This means the subscriber is only partially interested in the response
and we should not count this as a client error.

This commit ensures that observations are only recorded as aborted if
the response was not published at the time the CANCEL signal was
received.

The code snippet above will now publish observations with
"outcome":"SUCCESS" and "status":"200" tags, for example.

Closes gh-30070

3 years ago

src

Improve WebClient observations handling of CANCEL signal

3 years ago

spring-webflux.gradle

Refine generic type management in AbstractMessageWriterResultHandler

3 years ago