spring-framework

Spring Framework

Tree: c681614bc2

Sam Brannen d902bd7696 Reject ModelMap argument types in WebFlux Prior to this commit, if ModelMap was used as an argument type in a WebFlux controller method, the user encountered an exception similar to the following. java.lang.IllegalStateException: argument type mismatch Controller [example.SampleController] Method [java.lang.String example.SampleController.index(org.springframework.ui.ModelMap)] with argument values: [0] [type=org.springframework.validation.support.BindingAwareConcurrentModel] [value={}] However, the above error message is a bit cryptic since the error occurs while attempting to invoke the controller method with an instance of BindingAwareConcurrentModel which is not compatible with ModelMap. More importantly, this error message does not explicitly convey to the user that a ModelMap is not supported. This commit improve the diagnostics for the user in such scenarios by rejecting the use of ModelMap upfront in WebFlux. Consequently, for the same use case as above, the user now encounters an exception similar to the following. java.lang.IllegalStateException: Could not resolve parameter [0] in java.lang.String example.SampleController.index(org.springframework.ui.ModelMap): No suitable resolver Closes gh-33109	2 years ago
..
src	Reject ModelMap argument types in WebFlux	2 years ago
spring-webflux.gradle	Introduce support for webjars-locator-lite	2 years ago

Sam Brannen d902bd7696 Reject ModelMap argument types in WebFlux

Prior to this commit, if ModelMap was used as an argument type in a
WebFlux controller method, the user encountered an exception similar to
the following.

java.lang.IllegalStateException: argument type mismatch
  Controller [example.SampleController]
  Method [java.lang.String example.SampleController.index(org.springframework.ui.ModelMap)] with argument values:
  [0] [type=org.springframework.validation.support.BindingAwareConcurrentModel] [value={}]

However, the above error message is a bit cryptic since the error
occurs while attempting to invoke the controller method with an
instance of BindingAwareConcurrentModel which is not compatible with
ModelMap. More importantly, this error message does not explicitly
convey to the user that a ModelMap is not supported.

This commit improve the diagnostics for the user in such scenarios by
rejecting the use of ModelMap upfront in WebFlux.

Consequently, for the same use case as above, the user now encounters
an exception similar to the following.

java.lang.IllegalStateException:
  Could not resolve parameter [0] in
  java.lang.String example.SampleController.index(org.springframework.ui.ModelMap):
  No suitable resolver

Closes gh-33109

2 years ago

src

Reject ModelMap argument types in WebFlux

2 years ago

spring-webflux.gradle

Introduce support for webjars-locator-lite

2 years ago