spring-framework

Spring Framework

Tree: b484ab116f

Brian Clozel b484ab116f Record errors thrown by custom handler in RestTemplate observations Prior to this commit, the `RestTemplate` observation instrumentation would only record `RestClientException` and `IOException` as errors in the observation. Other types of errors can be thrown by custom components, such as `ResponseErrorHandler` and in this case they aren't recorded with the observation. Also, the current instrumentation does not create any observation scope around the execution. While this would have a limited benefit as no application code is executed there, developers could set up custom components (such as, again, `ResponseErrorHandler`) that could use contextual logging with trace ids. This commit ensures that all `Throwable` are recorded as errors with the observations and that an observation `Scope` is created around the execution of the client exchange. Fixes gh-32063	2 years ago
..
src	Record errors thrown by custom handler in RestTemplate observations	2 years ago
spring-web.gradle	Fix ordering of releasing resources in JSON Encoder	2 years ago

Brian Clozel b484ab116f Record errors thrown by custom handler in RestTemplate observations

Prior to this commit, the `RestTemplate` observation instrumentation
would only record `RestClientException` and `IOException` as errors in
the observation. Other types of errors can be thrown by custom
components, such as `ResponseErrorHandler` and in this case they aren't
recorded with the observation.
Also, the current instrumentation does not create any observation scope
around the execution. While this would have a limited benefit as no
application code is executed there, developers could set up custom
components (such as, again, `ResponseErrorHandler`) that could use
contextual logging with trace ids.

This commit ensures that all `Throwable` are recorded as errors with the
observations and that an observation `Scope` is created around the
execution of the client exchange.

Fixes gh-32063

2 years ago

src

Record errors thrown by custom handler in RestTemplate observations

2 years ago

spring-web.gradle

Fix ordering of releasing resources in JSON Encoder

2 years ago