spring-framework

Spring Framework

Tree: 89e894205a

Carlos Corbacho e95e4423bb Do not swallow exceptions on failing to release a savepoint By swallowing the exception on failing to release a savepoint, we are hiding client code from database errors that they may need to be aware of or handle. e.g. if the connection is now dead when trying to release the savepoint, by swallowing the exception here, client code has no way of knowing this now until the next operation on the database, which will yield a confusing message about the problem and obscures where the failure occurred as it will be in a different part of their code that throws any exception. Swallowing the exception here is also inconsistent with all the other database calls in the Transaction Object, where we always raise an exception up and let client code decide how to handle the error.	2 years ago
..
main	Do not swallow exceptions on failing to release a savepoint	2 years ago
test	Merge branch '6.1.x'	2 years ago

Carlos Corbacho e95e4423bb Do not swallow exceptions on failing to release a savepoint

By swallowing the exception on failing to release a savepoint, we are hiding
client code from database errors that they may need to be aware of or handle.

e.g. if the connection is now dead when trying to release the savepoint, by
swallowing the exception here, client code has no way of knowing this now until
the next operation on the database, which will yield a confusing message about
the problem and obscures where the failure occurred as it will be in a different
part of their code that throws any exception.

Swallowing the exception here is also inconsistent with all the other database
calls in the Transaction Object, where we always raise an exception up and let
client code decide how to handle the error.

2 years ago

main

Do not swallow exceptions on failing to release a savepoint

2 years ago

test

Merge branch '6.1.x'

2 years ago