spring-framework

Spring Framework

Tree: 36e84a5209

Jonatan Ivanov 36e84a5209 Fix RestClient instrumentation ClientHttpResponse implements Closeable and the close method of DefaultConvertibleClientHttpResponse also stops the current Observation. Before this change exiting the try-with-resource block stopped the Observation since it called close on ClientHttpResponse. After this, there were multiple error and stop calls on the Observation in the catch blocks after the Observation was already stopped which is invalid. This change reorders the flow by stopping the Observation in the finally block (closing ClientHttpResponse) and not stopping the Observation in any of the catch blocks. Closes gh-33346	2 years ago
..
src	Fix RestClient instrumentation	2 years ago
spring-web.gradle	Fix ordering of releasing resources in JSON Encoder	2 years ago

Jonatan Ivanov 36e84a5209 Fix RestClient instrumentation

ClientHttpResponse implements Closeable and the close method of
DefaultConvertibleClientHttpResponse also stops the current Observation.

Before this change exiting the try-with-resource block stopped the
Observation since it called close on ClientHttpResponse.
After this, there were multiple error and stop calls on the Observation
in the catch blocks after the Observation was already stopped
which is invalid.

This change reorders the flow by stopping the Observation in the
finally block (closing ClientHttpResponse) and not stopping
the Observation in any of the catch blocks.

Closes gh-33346

2 years ago

src

Fix RestClient instrumentation

2 years ago

spring-web.gradle

Fix ordering of releasing resources in JSON Encoder

2 years ago