spring-framework

Spring Framework

Tree: 183cd4c8cd

Sam Brannen b3fb9f4e31 Reliably resolve generic read/write methods in PropertyDescriptorUtils Prior to this commit, the determineBasicProperties() method in PropertyDescriptorUtils did not reliably resolve read/write methods in type hierarchies with generics. This utility method is used by SimpleBeanInfoFactory which is used by BeanUtils and BeanWrapperImpl. Thus, failure to reliably resolve read/write JavaBeans methods resulted in bugs in certain scenarios. For example, BeanUtils.copyProperties() randomly failed to copy certain properties if the write method for the property could not be resolved. To address such issues, this commit revises the implementation of PropertyDescriptorUtils as follows. 1) Read methods with covariant return types are now consistently resolved correctly. 2) If multiple ambiguous write methods are discovered, the algorithm now checks for an exact match against the resolved generic parameter type as a fallback. Closes gh-36019 (cherry picked from commit `4b07edbaeb`)	3 weeks ago
..
src	Reliably resolve generic read/write methods in PropertyDescriptorUtils	3 weeks ago
spring-beans.gradle	Reinstate qualifier support for JSR-330 @⁠javax.inject.Named	1 year ago

Sam Brannen b3fb9f4e31 Reliably resolve generic read/write methods in PropertyDescriptorUtils

Prior to this commit, the determineBasicProperties() method in
PropertyDescriptorUtils did not reliably resolve read/write methods in
type hierarchies with generics. This utility method is used by
SimpleBeanInfoFactory which is used by BeanUtils and BeanWrapperImpl.
Thus, failure to reliably resolve read/write JavaBeans methods resulted
in bugs in certain scenarios.

For example, BeanUtils.copyProperties() randomly failed to copy certain
properties if the write method for the property could not be resolved.

To address such issues, this commit revises the implementation of
PropertyDescriptorUtils as follows.

1) Read methods with covariant return types are now consistently
   resolved correctly.

2) If multiple ambiguous write methods are discovered, the algorithm now
   checks for an exact match against the resolved generic parameter type
   as a fallback.

Closes gh-36019

(cherry picked from commit 4b07edbaeb)

3 weeks ago

src Reliably resolve generic read/write methods in PropertyDescriptorUtils 3 weeks ago

spring-beans.gradle Reinstate qualifier support for JSR-330 @⁠javax.inject.Named 1 year ago