13970ae528
Use autoboxing instead of explicit wrapping in tests
...
Closes gh-24801
2020-04-01 14:34:20 +02:00
e26764d249
Remove duplicate words in documentation and polish Javadoc
2020-03-31 12:17:58 +02:00
fdc60311ed
Avoid unnecessary trace logging in ProxyFactoryBean
...
Closes gh-24669
2020-03-24 00:07:40 +01:00
d91fc8c672
No log level check unless String concatenation is following
2020-03-14 00:01:13 +01:00
33642345a4
Lazily check log level within validation conditions
...
See gh-24672
2020-03-13 23:14:38 +01:00
988aae4f2e
Remove unnecessary variable declaration in ProxyCallbackFilter
...
Closes gh-24675
2020-03-11 13:51:13 +01:00
1fd447f395
Reduce String garbage in CglibAopProxy.doValidateClass()
...
Closes gh-24672
2020-03-10 17:16:08 +01:00
b92515bdee
Add logger.isInfoEnabled check before logger.info
...
Closes gh-24667
2020-03-10 14:41:20 +01:00
2093e35f27
Avoid unnecessary sorting
2020-03-04 19:10:14 +00:00
6add7b4dec
Polishing
...
Closes gh-24543
2020-02-17 17:33:39 +01:00
51fa98a1b2
Apply compiler conventions to test fixtures
2020-02-07 11:04:03 +01:00
f5df422de9
Polishing contribution
...
See gh-24470
2020-02-03 20:32:36 +00:00
273812f9c5
Remove unnecessary escapes in regular expressions
...
See gh-24470
2020-02-03 20:22:40 +00:00
e8ef93c508
Polish contribution
...
See gh-24321
2020-01-09 15:56:25 +01:00
047eefd2e2
Improve exception message in AopContext.currentProxy()
...
Closes gh-24321
2020-01-09 15:56:09 +01:00
8e5cad2af3
Add fast path for ClassUtils.hasMethod()
2020-01-08 18:52:15 +01:00
141dae6437
Polish contribution
...
See gh-24293
2020-01-07 11:07:03 +01:00
132805133d
Improve ExposeInvocationInterceptor exception message
...
Closes gh-24293
2020-01-07 11:03:11 +01:00
8a371c7669
Use Gradle test fixture support for spring-aop
...
See gh-23550
2020-01-02 16:01:35 +01:00
7cd4ddf5fc
Rename test fixture package in spring-beans
...
See gh-23550
2020-01-02 16:01:35 +01:00
4260c34b47
Rename test fixture package in spring-core
...
See gh-23550
2020-01-02 16:01:34 +01:00
61d4ee594d
Use Gradle test fixture support for spring-beans and spring-context
...
See gh-23550
2020-01-02 16:01:34 +01:00
5718bf424b
Use Gradle test fixture support for spring-core
...
See gh-23550
2020-01-02 16:01:34 +01:00
e7d489667c
Add missing space in AopConfigException message
...
See gh-24266
2019-12-26 09:52:54 +01:00
6fdf5ef6ee
Polish contribution
...
See gh-24205
2019-12-13 17:14:26 +01:00
d9cae339d6
Simplify AdvisedSupport.removeAdvisor()
...
Closes gh-24205
2019-12-13 17:12:18 +01:00
484006ce90
Hoist Class.getName() from String concatenation to dodge an issue related to profile pollution
2019-12-06 17:36:07 +01:00
59e250c93c
Consistent use of SCOPE_PROTOTYPE and SCOPE_SINGLETON constants
...
Closes gh-19905
2019-11-24 13:49:43 +01:00
769a15cb82
Polishing
2019-11-18 13:01:26 +01:00
f2b3953d76
Use array.clone() instead of manual array creation
2019-11-13 13:53:42 +01:00
f5ae3c77c6
Use Method::getParameterCount where possible
2019-11-07 18:00:15 +01:00
1a13700f8b
Polish contribution
...
See gh-23923
2019-11-06 12:57:01 +01:00
9da15ee23a
Improve usage of String.substring()
...
Closes gh-23923
2019-11-06 12:57:01 +01:00
d00690f43f
Merge branch '5.1.x'
...
# Conflicts:
# build.gradle
# spring-context/spring-context.gradle
# spring-test/spring-test.gradle
# spring-web/spring-web.gradle
# spring-webflux/spring-webflux.gradle
# spring-webmvc/spring-webmvc.gradle
2019-09-25 23:13:49 +02:00
357beb24bc
Polishing
2019-09-25 22:15:07 +02:00
bd70f10d2b
Merge branch '5.1.x'
...
# Conflicts:
# build.gradle
# spring-aop/src/main/java/org/springframework/aop/framework/CglibAopProxy.java
# spring-aspects/spring-aspects.gradle
# spring-beans/src/main/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessor.java
# spring-beans/src/main/java/org/springframework/beans/factory/support/GenericBeanDefinition.java
# spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java
# spring-orm/spring-orm.gradle
# spring-test/spring-test.gradle
2019-09-25 12:43:24 +02:00
bb6f9bb6d4
Polishing
2019-09-25 12:14:48 +02:00
c256af4ef7
Polishing
2019-09-19 16:31:07 +02:00
d611c7484f
Fix Checkstyle violation
2019-09-19 16:21:44 +02:00
9811e21432
Merge branch '5.1.x'
2019-09-19 15:57:33 +02:00
8f6846827d
Ensure ClassFilter and MethodMatcher implementations are cacheable
...
While resolving the regression raised in gh-23571, it came to our
attention that not all of our ClassFilter and MethodMatcher
implementations were properly cacheable with CGLIB generated proxies
due to missing (or improper) equals() and hashCode() implementations.
Although such deficiencies may not manifest themselves as bugs in Core
Spring's default arrangements, these might cause issues in custom
arrangements in user applications.
This commit addresses this by ensuring that ClassFilter and
MethodMatcher implementations properly implement equals() and
hashCode(). In addition, missing toString() implementations have been
added to improve diagnostics for logging and debugging.
Closes gh-23659
2019-09-19 15:35:17 +02:00
e1e072b75c
Fix memory leak regression involving @Async methods
...
Spring Framework 5.2 M1 introduced a memory leak for applications using
@Async methods. Specifically, in a large test suite with multiple
ApplicationContexts that were closed (e.g., via @DirtiesContext,
@MockBean, or context cache eviction), the JVM process could run out of
memory.
Underlying cause: Due to a missing equals() implementation in Spring's
new AnnotationCandidateClassFilter, CGLIB's static cache of generated
classes indirectly retained references to BeanFactory instances for the
closed ApplicationContexts for the duration of the test suite.
This commit fixes this regression by introducing a proper equals()
implementation in AnnotationCandidateClassFilter. This commit also
introduces corresponding hashCode() and toString() implementations.
Closes gh-23571
2019-09-18 14:28:54 +02:00
2e7d344930
Polish ClassFiltersTests
2019-09-18 10:25:54 +02:00
d945ae9191
Add blank line between java and javax imports
...
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io >
2019-09-16 13:41:59 +02:00
deba2ed1b3
Add blank line between java and javax imports
...
See gh-23539
2019-09-04 22:05:46 -07:00
46a37b447c
Fix copyright dates
...
See gh-23393
2019-08-27 19:30:05 +02:00
78d56dc61b
Use Arrays.copyOf and Arrays.copyOfRange where possible
...
Closes gh-23393
2019-08-27 19:18:39 +02:00
1ec9721617
Fix @since tags in ScopedProxyUtils[Tests]
...
See gh-23514
2019-08-27 16:01:50 +02:00
9d2a874e3f
Introduce getOriginalBeanName(String) in ScopedProxyUtils
...
This commit introduces a utility method for retrieving the original
bean name for the target of a scoped proxy.
Closes gh-23514
2019-08-27 15:46:34 +02:00
f8f3067419
Polishing
2019-08-27 12:27:18 +02:00
陈其苗
Sam Brannen
Juergen Hoeller
Сергей Цыпанов
Christoph Dreis
ZhangT
Rossen Stoyanchev
Hyunjin Choi
lixiaolong11000
lixiaolong11000
Pascal Schumacher
Phillip Webb