spring-framework

Commit Graph

Author	SHA1	Message	Date
Sam Brannen	9cac5eeeab	Consistently use generated name in embedded databases ... to avoid database name conflicts when test classes are executed in a different order. See gh-29122	2 years ago
Sam Brannen	0adec6d15a	Apply @⁠DisabledInAotMode to remaining @⁠ContextHierarchy integration tests See gh-29122	2 years ago
Sam Brannen	bb95f2e5ca	Apply @⁠DisabledInAotMode to @⁠ContextHierarchy integration tests This commit applies @⁠DisabledInAotMode to all integration test classes in the spring-test module that use @⁠ContextHierarchy since that feature is not supported for AOT optimizations. Current AOT test results for the spring-test module: Test run finished after 6888 ms [ 403 containers found ] [ 57 containers skipped ] [ 346 containers started ] [ 0 containers aborted ] [ 338 containers successful ] [ 8 containers failed ] [ 757 tests found ] [ 98 tests skipped ] [ 654 tests started ] [ 9 tests aborted ] [ 576 tests successful ] [ 69 tests failed ] Failing Test Classes: org.springframework.test.context.configuration.interfaces.SqlConfigInterfaceTests org.springframework.test.context.expression.ExpressionUsageTests org.springframework.test.context.groovy.AbsolutePathGroovySpringContextTests org.springframework.test.context.groovy.GroovySpringContextTests org.springframework.test.context.groovy.RelativePathGroovySpringContextTests org.springframework.test.context.hierarchies.meta.MetaHierarchyLevelTwoTests org.springframework.test.context.hierarchies.standard.TestHierarchyLevelTwoWithBareContextConfigurationInSubclassTests org.springframework.test.context.jdbc.CustomScriptSyntaxSqlScriptsTests org.springframework.test.context.jdbc.GlobalCustomScriptSyntaxSqlScriptsTests org.springframework.test.context.jdbc.InferredDataSourceTransactionalSqlScriptsTests org.springframework.test.context.jdbc.InfrastructureProxyTransactionalSqlScriptsTests org.springframework.test.context.jdbc.MultipleDataSourcesAndTransactionManagersSqlScriptsTests org.springframework.test.context.jdbc.MultipleDataSourcesAndTransactionManagersTransactionalSqlScriptsTests org.springframework.test.context.jdbc.NonTransactionalSqlScriptsTests org.springframework.test.context.jdbc.RepeatableSqlAnnotationSqlScriptsChildTests org.springframework.test.context.jdbc.RepeatableSqlAnnotationSqlScriptsParentTests org.springframework.test.context.jdbc.TransactionalAfterTestMethodSqlScriptsTests org.springframework.test.context.jdbc.TransactionalInlinedStatementsSqlScriptsTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests$ConfigOverriddenByDefaultTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests$InheritedAndExtendedConfigTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests$InheritedAndExtendedConfigTests$DoubleNestedWithOverriddenConfigTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests$InheritedAndExtendedConfigTests$DoubleNestedWithOverriddenConfigTests$TripleNestedWithInheritedConfigAndTestInterfaceTests org.springframework.test.context.junit.jupiter.orm.JpaEntityListenerTests org.springframework.test.context.junit4.AbsolutePathSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.ClassPathResourceSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.ConcreteTransactionalJUnit4SpringContextTests org.springframework.test.context.junit4.InheritedConfigSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.MultipleResourcesSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.ParameterizedDependencyInjectionTests org.springframework.test.context.junit4.RelativePathSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.SpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.annotation.AnnotationConfigSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.rules.TransactionalSqlScriptsSpringRuleTests org.springframework.test.context.junit4.spr9799.Spr9799XmlConfigTests org.springframework.test.context.testng.ConcreteTransactionalTestNGSpringContextTests org.springframework.test.context.testng.transaction.ejb.CommitForRequiredEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.CommitForRequiresNewEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.RollbackForRequiredEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.RollbackForRequiresNewEjbTxDaoTestNGTests org.springframework.test.context.transaction.ejb.CommitForRequiredEjbTxDaoTests org.springframework.test.context.transaction.ejb.CommitForRequiresNewEjbTxDaoTests org.springframework.test.context.transaction.ejb.RollbackForRequiredEjbTxDaoTests org.springframework.test.context.transaction.ejb.RollbackForRequiresNewEjbTxDaoTests See gh-29122	2 years ago
Sam Brannen	44931dca44	Include all failing test classes in AOT end-to-end test report Prior to this commit, AotIntegrationTests only printed "failing test classes" for tests that failed at the class level. This commit updates the reporting logic to report test classes for failing test methods as well. Current results for the spring-test module: Test run finished after 6531 ms [ 403 containers found ] [ 27 containers skipped ] [ 376 containers started ] [ 0 containers aborted ] [ 366 containers successful ] [ 10 containers failed ] [ 757 tests found ] [ 61 tests skipped ] [ 689 tests started ] [ 9 tests aborted ] [ 585 tests successful ] [ 95 tests failed ] Failing Test Classes: org.springframework.test.context.configuration.interfaces.ContextHierarchyInterfaceTests org.springframework.test.context.configuration.interfaces.SqlConfigInterfaceTests org.springframework.test.context.expression.ExpressionUsageTests org.springframework.test.context.groovy.AbsolutePathGroovySpringContextTests org.springframework.test.context.groovy.GroovySpringContextTests org.springframework.test.context.groovy.RelativePathGroovySpringContextTests org.springframework.test.context.hierarchies.meta.MetaHierarchyLevelTwoTests org.springframework.test.context.hierarchies.standard.ClassHierarchyWithMergedConfigLevelOneTests org.springframework.test.context.hierarchies.standard.ClassHierarchyWithMergedConfigLevelTwoTests org.springframework.test.context.hierarchies.standard.ClassHierarchyWithOverriddenConfigLevelTwoTests org.springframework.test.context.hierarchies.standard.DirtiesContextWithContextHierarchyTests org.springframework.test.context.hierarchies.standard.SingleTestClassWithTwoLevelContextHierarchyAndMixedConfigTypesTests org.springframework.test.context.hierarchies.standard.SingleTestClassWithTwoLevelContextHierarchyTests org.springframework.test.context.hierarchies.standard.TestHierarchyLevelTwoWithBareContextConfigurationInSubclassTests org.springframework.test.context.hierarchies.standard.TestHierarchyLevelTwoWithBareContextConfigurationInSuperclassTests org.springframework.test.context.hierarchies.standard.TestHierarchyLevelTwoWithSingleLevelContextHierarchyAndMixedConfigTypesTests org.springframework.test.context.hierarchies.standard.TestHierarchyLevelTwoWithSingleLevelContextHierarchyTests org.springframework.test.context.hierarchies.web.ControllerIntegrationTests org.springframework.test.context.hierarchies.web.DispatcherWacRootWacEarTests org.springframework.test.context.hierarchies.web.RootWacEarTests org.springframework.test.context.jdbc.CustomScriptSyntaxSqlScriptsTests org.springframework.test.context.jdbc.GlobalCustomScriptSyntaxSqlScriptsTests org.springframework.test.context.jdbc.InferredDataSourceTransactionalSqlScriptsTests org.springframework.test.context.jdbc.InfrastructureProxyTransactionalSqlScriptsTests org.springframework.test.context.jdbc.MultipleDataSourcesAndTransactionManagersSqlScriptsTests org.springframework.test.context.jdbc.MultipleDataSourcesAndTransactionManagersTransactionalSqlScriptsTests org.springframework.test.context.jdbc.NonTransactionalSqlScriptsTests org.springframework.test.context.jdbc.RepeatableSqlAnnotationSqlScriptsChildTests org.springframework.test.context.jdbc.RepeatableSqlAnnotationSqlScriptsParentTests org.springframework.test.context.jdbc.TransactionalAfterTestMethodSqlScriptsTests org.springframework.test.context.jdbc.TransactionalInlinedStatementsSqlScriptsTests org.springframework.test.context.junit.jupiter.nested.ContextHierarchyNestedTests$NestedTestCaseWithInheritedConfigTests org.springframework.test.context.junit.jupiter.nested.ContextHierarchyNestedTests$NestedTestCaseWithInheritedConfigTests$DoubleNestedTestCaseWithOverriddenConfigTests org.springframework.test.context.junit.jupiter.nested.ContextHierarchyNestedTests$NestedTestCaseWithInheritedConfigTests$DoubleNestedTestCaseWithOverriddenConfigTests$TripleNestedWithInheritedConfigAndTestInterfaceTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests$ConfigOverriddenByDefaultTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests$InheritedAndExtendedConfigTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests$InheritedAndExtendedConfigTests$DoubleNestedWithOverriddenConfigTests org.springframework.test.context.junit.jupiter.nested.TestExecutionListenersNestedTests$InheritedAndExtendedConfigTests$DoubleNestedWithOverriddenConfigTests$TripleNestedWithInheritedConfigAndTestInterfaceTests org.springframework.test.context.junit.jupiter.orm.JpaEntityListenerTests org.springframework.test.context.junit4.AbsolutePathSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.ClassPathResourceSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.ConcreteTransactionalJUnit4SpringContextTests org.springframework.test.context.junit4.InheritedConfigSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.MultipleResourcesSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.ParameterizedDependencyInjectionTests org.springframework.test.context.junit4.RelativePathSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.SpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.annotation.AnnotationConfigSpringJUnit4ClassRunnerAppCtxTests org.springframework.test.context.junit4.rules.TransactionalSqlScriptsSpringRuleTests org.springframework.test.context.junit4.spr9799.Spr9799XmlConfigTests org.springframework.test.context.testng.ConcreteTransactionalTestNGSpringContextTests org.springframework.test.context.testng.transaction.ejb.CommitForRequiredEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.CommitForRequiresNewEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.RollbackForRequiredEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.RollbackForRequiresNewEjbTxDaoTestNGTests org.springframework.test.context.transaction.ejb.CommitForRequiredEjbTxDaoTests org.springframework.test.context.transaction.ejb.CommitForRequiresNewEjbTxDaoTests org.springframework.test.context.transaction.ejb.RollbackForRequiredEjbTxDaoTests org.springframework.test.context.transaction.ejb.RollbackForRequiresNewEjbTxDaoTests org.springframework.test.web.servlet.samples.client.context.JavaConfigTests org.springframework.test.web.servlet.samples.client.context.WebAppResourceTests org.springframework.test.web.servlet.samples.client.context.XmlConfigTests org.springframework.test.web.servlet.samples.context.JavaConfigTests org.springframework.test.web.servlet.samples.context.WebAppResourceTests org.springframework.test.web.servlet.samples.context.XmlConfigTests See gh-29122	2 years ago
Sam Brannen	32b4f55d92	Update copyright headers	2 years ago
Sam Brannen	119a9ffc3e	Rename test class to NestedTests for AOT integration testing Prior to this commit, the NestedTestCase resulted in errors during our AOT end-to-end integration tests since it did not comply to our "*Tests" naming convention. See gh-29122	2 years ago
Sam Brannen	66e3a7a25c	Apply @⁠DisabledInAotMode to appropriate test classes This commit applies @⁠DisabledInAotMode to test classes in the spring-test module that will never be able to be processed for AOT optimizations. Test classes that fail for reasons that can potentially be addressed in a future version of the framework have not been annotated with @⁠DisabledInAotMode. See gh-29122	2 years ago
Sam Brannen	991afe0939	Fix formatting for @⁠DisabledInAotMode error messages See gh-30834	2 years ago
Sam Brannen	1281f03b96	Skipping duplicate test classes during test AOT processing Although it should not happen in theory, sometimes a test class is discovered more than once via the TestClassScanner in our integration tests. When it does happen in our tests, the two Class objects have the same fully-qualified class name but represent different classes which leads to failures due to incorrect associations between test class names and their MergedContextConfiguration. To address this, this commit modifies TestContextAotGenerator so that it skips duplicate test class names.	2 years ago
Sam Brannen	28939e4754	Find @⁠DisabledInAotMode on enclosing classes for @⁠Nested tests See gh-30834	2 years ago
Sam Brannen	fc81cc5cda	Polishing	2 years ago
Sam Brannen	41098d52d6	Print test summary for AotIntegrationTests.endToEndTestsForEntireSpringTestModule() Current results for the spring-test module: Test run finished after 6785 ms [ 403 containers found ] [ 6 containers skipped ] [ 397 containers started ] [ 0 containers aborted ] [ 381 containers successful ] [ 16 containers failed ] [ 757 tests found ] [ 41 tests skipped ] [ 703 tests started ] [ 9 tests aborted ] [ 599 tests successful ] [ 95 tests failed ] Failing Test Classes: org.springframework.test.context.testng.transaction.ejb.RollbackForRequiresNewEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.CommitForRequiredEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.RollbackForRequiredEjbTxDaoTestNGTests org.springframework.test.context.testng.transaction.ejb.CommitForRequiresNewEjbTxDaoTestNGTests org.springframework.test.context.env.ExplicitPropertiesFileTestPropertySourceTests$ClasspathTests$PlaceholderAndClasspathPrefixTests org.springframework.test.context.env.ExplicitPropertiesFileTestPropertySourceTests$ClasspathTests$PlaceholderTests org.springframework.test.context.env.ExplicitPropertiesFileTestPropertySourceTests$FileSystemTests$CustomPlaceholderTests org.springframework.test.context.env.ExplicitPropertiesFileTestPropertySourceTests$FileSystemTests$PlaceholdersFollowedByRelativePathsTests org.springframework.test.context.env.ExplicitPropertiesFileTestPropertySourceTests$FileSystemTests$UserDirAndCustomPlaceholdersTests org.springframework.test.web.servlet.samples.client.context.WebAppResourceTests org.springframework.test.web.servlet.samples.client.context.XmlConfigTests org.springframework.test.web.servlet.samples.context.WebAppResourceTests org.springframework.test.web.servlet.samples.context.XmlConfigTests org.springframework.test.context.junit4.ParameterizedDependencyInjectionTests org.springframework.test.context.junit4.nested.NestedTestsWithSpringRulesTests$NestedTestCase org.springframework.test.context.junit4.spr9799.Spr9799XmlConfigTests See gh-29122	2 years ago
Sam Brannen	3ad79e919b	Modify tests so they pass in AOT mode ... when run via AotIntegrationTests.endToEndTestsForEntireSpringTestModule().	2 years ago
Sam Brannen	87127ab684	Polishing	2 years ago
Sam Brannen	39a282e463	Introduce @⁠DisabledInAotMode in the TestContext framework This commit introduces @⁠DisabledInAotMode in the TestContext framework to support the following use cases. - Disabling AOT build-time processing of a test ApplicationContext -- applicable to any testing framework (JUnit 4, JUnit Jupiter, etc.). - Disabling an entire test class or a single test method at run time when the test suite is run with AOT optimizations enabled -- only applicable to JUnit Jupiter based tests. Closes gh-30834	2 years ago
Sam Brannen	39400901cd	Set failOnError flag to false endToEndTestsForEntireSpringTestModule()	2 years ago
Sam Brannen	8b335e793c	Revise endToEndTestsForEntireSpringTestModule()	2 years ago
rstoyanchev	776e28a6c4	MockMvc supports filter initParams and DispatcherType's Closes gh-27717, gh-31362	2 years ago
Sam Brannen	d1b43386b1	Test status quo for @⁠Sql in @⁠Nested test class w/ class-level execution phases	2 years ago
Sam Brannen	b98b999997	Test status quo for inherited @⁠Sql in @⁠Nested test class	2 years ago
Sam Brannen	913dc86e18	Polishing	2 years ago
Sam Brannen	95139fca76	Polishing	2 years ago
Sam Brannen	0afcb4dfed	Revise "Introduce class-level execution phases for @⁠Sql" This commit revises the previous commit as follows. - Remove hasTestMethod() from TestContext and instead introduce a new variant of createDelegatingTransactionAttribute() in TestContextTransactionUtils which accepts a boolean `includeMethodName` flag. - Add missing @⁠TestMethodOrder declaration to AfterTestClassSqlScriptsTests to ensure that the test methods are always executed in the required order. - Polish Javadoc and add missing @⁠since tags. Closes gh-27285	2 years ago
Andreas Ahlenstorf	5aa2d0515e	Introduce class-level execution phases for @⁠Sql This commit introduces BEFORE_TEST_CLASS and AFTER_TEST_CLASS execution phases for @⁠Sql. See gh-27285	2 years ago
rstoyanchev	2e2a62a23c	Polishing	2 years ago
rstoyanchev	af7fe013b6	MockMvcHttpConnector supports RequestPostProcessor's Closes gh-31298	2 years ago
Sam Brannen	7aae97bcd4	Revise NO_VIOLATIONS_DETECTED in SpringExtension to clarify intent See gh-31305 See gh-30962 See gh-30456	2 years ago
ali dandach	1d12c74042	Use Objects.equals() for null-safe string comparison See gh-31305	2 years ago
Sam Brannen	09b1e5edf6	Extract instantiateComponents() method in AbstractTestContextBootstrapper	2 years ago
Sam Brannen	a220c545fc	Support declarative ContextCustomizerFactory registration in the TCF Prior to this commit, it was only possible to register a ContextCustomizerFactory in the TestContext framework (TCF) via the SpringFactoriesLoader mechanism. This commit introduces support for declarative registration of a ContextCustomizerFactory local to a test class via a new @ContextCustomizerFactories annotation. Closes gh-26148	2 years ago
Sam Brannen	5c7bf0c2fe	Add tests for MethodInvoker behavior in the TestContext framework See gh-31199	2 years ago
Sam Brannen	4aeeacb4c2	Simplify and rename TestContextManager[ListenerExecutionOrder]Tests	2 years ago
Sam Brannen	ed83461021	Support parameter injection in @[Before\|After]Transaction methods Prior to this commit, @BeforeTransaction and @AfterTransaction methods could not accept any arguments. This is acceptable with testing frameworks such as JUnit 4 and TestNG that do not provide support for parameter injection. However, users of JUnit Jupiter have become accustomed to being able to accept arguments in lifecycle methods annotated with JUnit's @BeforeEach, @AfterEach, etc. As a follow up to the previous commit (see gh-31199), this commit introduces first-class support for parameter injection in @BeforeTransaction and @AfterTransaction methods, as demonstrated in the following example. @BeforeTransaction void verifyInitialDatabaseState(@Autowired DataSource dataSource) { // Use the DataSource to verify the initial DB state } Closes gh-30736	2 years ago
Sam Brannen	41904d46ad	Introduce MethodInvoker API for TestExecutionListeners In order to be able to support parameter injection in @BeforeTransaction and @AfterTransaction methods (see gh-30736), this commit introduces a MethodInvoker API for TestExecutionListeners as a generic mechanism for delegating to the underlying testing framework to invoke methods. The default implementation simply invokes the method without arguments, which allows TestExecutionListeners using this mechanism to operate correctly when the underlying testing framework is JUnit 4, TestNG, etc. A JUnit Jupiter specific implementation is registered in the SpringExtension which delegates to the ExtensionContext.getExecutableInvoker() mechanism introduced in JUnit Jupiter 5.9. This allows a TestExecutionListener to transparently benefit from registered ParameterResolvers in JUnit Jupiter (including the SpringExtension) when invoking user methods, effectively providing support for parameter injection for arbitrary methods. Closes gh-31199	2 years ago
Sam Brannen	436c7136e9	Polish TransactionAssert	2 years ago
Sam Brannen	0f36c5fd6a	Polishing	2 years ago
Sam Brannen	dfea3d05aa	Revise support for JSR-330 and Jakarta @Inject for autowiring test constructors Closes gh-29851	2 years ago
Florian Lehmann	8dd857a84d	Support @Inject from JSR-330 & Jakarta for autowiring test constructors See gh-29851	2 years ago
Sam Brannen	0a7166234d	Polishing	2 years ago
Sam Brannen	210b42b7d8	Polishing	2 years ago
Sam Brannen	e8fd29091c	Register hints for @TestPropertySource factory This commit updates MergedContextConfigurationRuntimeHints so that it registers hints for a custom PropertySourceFactory. Closes gh-31160	2 years ago
Sam Brannen	7882d265c6	Polishing	2 years ago
Juergen Hoeller	759e3d4aa6	Adapt to PreparedStatementCreator for JdbcClient update operation See gh-31122	2 years ago
Sam Brannen	7598bca799	Revise Checkstyle rules to prohibit use of assertions other than AssertJ Closes gh-31116	2 years ago
Sam Brannen	f9588de247	Reinstate FailingBeforeAndAfterMethodsTestNGTests The tests were ignored due to "Fails against TestNG 6.11"; however, these tests pass against the current version of TestNG that we build against (7.8.0).	2 years ago
Sam Brannen	9911d91f08	Add implementation note See gh-31083	2 years ago
Sam Brannen	620a87bcbc	Polishing	2 years ago
Yanming Zhou	368036cab4	Allow overriding dynamic property from enclosing class in nested test class Prior to this commit, a dynamic property registered via a @DynamicPropertySource method in a @Nested test class was not able to override a property registered via a @DynamicPropertySource method in the enclosing class. See gh-26091 Closes gh-31083	2 years ago
Sam Brannen	baf367831f	Add @AliasFor tip to Javadoc for @TestPropertySource	2 years ago
Sam Brannen	8f71bea553	Avoid unnecessary synchronization in SequencedProperties	2 years ago

... 6 7 8 9 10 ...

2820 Commits (382b51a8d4791f0a66b45db0d1960b898ef3b419)