Sam Brannen
bdf3960283
Suppress warnings in Gradle build
7 years ago
Phillip Webb
9d74da006c
Migrate JUnit 4 assertions to AssertJ
...
Migrate all existing JUnit 4 `assert...` based assertions to AssertJ
and add a checkstyle rule to ensure they don't return.
See gh-23022
7 years ago
Phillip Webb
95a9d46a87
Migrate Hamcrest assertions to AssertJ
...
Migrate all existing `assertThat(..., Matcher)` assertions to AssertJ
and add checkstyle rules to ensure they don't return.
See gh-23022
7 years ago
Phillip Webb
02850f357f
Migrate exception checking tests to use AssertJ
...
Migrate tests that use `@Test(expectedException=...)` or
`try...fail...catch` to use AssertJ's `assertThatException`
instead.
7 years ago
Phillip Webb
816bbee8de
Remove '.*' imports from tests
...
Organize test imports to expand all '.*' static imports into
fully qualified imports.
This update will allow us to use additional checkstyle rules in
the future, and will also help if we migrate fully to AssertJ.
7 years ago
Phil Webb
d7320de871
Migrate away from ExpectedException ( #22922 )
...
* Add limited checkstyles to test code
Add a limited set of checkstyle rules to the test codebase to improve
code consistency.
* Fix checksyle violations in test code
* Organize imports to fix checkstyle for test code
* Migrate to assertThatExceptionOfType
Migrate aware from ExpectedException rules to AssertJ exception
assertions. Also include a checkstyle rules to ensure that the
the ExpectedException is not accidentally used in the future.
See gh-22894
7 years ago
Sam Brannen
47c39304af
Use assertThat from Hamcrest instead of JUnit 4
...
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894
7 years ago
Juergen Hoeller
18f6739be4
Allow null operands in compiled SpEL numeric operator expressions
...
Closes gh-22358
7 years ago
Andy Clement
0f553661a6
Allow null operands in compiled SpEL numeric operator expressions
...
Prior to this when SpEL compiled an expression using the numeric
operators <, >, <= or >= then it would not create code that handled
nulls. Nulls can occur if a boxed numeric operand is used prior
to compilation, then it is nulled out. SpEL now creates null
handling bytecode.
Closes gh-22358
7 years ago
Spring Operator
540759ec41
URL Cleanup
...
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
# Fixed URLs
## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.
* [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to:
https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/ ) result 200).
* [ ] http://www.apache.org/licenses/LICENSE-2.0 with 6515 occurrences migrated to:
https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0 ) result 200).
7 years ago
Spring Operator
dc6f63f610
URL Cleanup
...
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
# Fixed URLs
## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.
* [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to:
https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/ ) result 200).
* [ ] http://www.apache.org/licenses/LICENSE-2.0 with 6625 occurrences migrated to:
https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0 ) result 200).
7 years ago
Juergen Hoeller
7a77e83e10
SpelNodeImpl manages start/end position in separate integer values
...
Fixes gh-22157
7 years ago
Rossen Stoyanchev
bdac937a43
Replace more references to issue tracker
...
Fixes #22254
7 years ago
Stephane Nicoll
9cbd585c30
Polish "Join identical catch branches"
...
Closes gh-2052
7 years ago
igor-suhorukov
a218bf40cd
Join identical catch branches
...
See gh-2052
7 years ago
Rossen Stoyanchev
38ae282c3b
Update log category precision for all tests
...
Replace the full category capped at 36 chars with the class name only
and 1 char per package, e.g. org.apache.commons.Foo -> o.a.c.Foo
7 years ago
Hanope
bfb49c7249
Fix typos
...
See gh-2019
7 years ago
Juergen Hoeller
3abebb3799
Polishing
7 years ago
Juergen Hoeller
90a4740279
Polishing
7 years ago
Andy Clement
f87a37fd0d
Fix SpEL compilation for non trivial elvis operand
...
Issue: SPR-17214
7 years ago
Juergen Hoeller
c4df335a1d
ReflectiveMethodExecutor invokes interface method if possible
...
Issue: SPR-16845
8 years ago
Phillip Webb
a89e716cc7
Use tabs rather than spaces in tests
...
Update tests to ensure that tabs are used instead of spaces. Also
consistently apply a new line at the end of each file.
Issue: SPR-16968
8 years ago
Phillip Webb
1c25cec44f
Polish test code
...
Polish a few issue identified when adding checkstyle to the
build. Although checkstyle is not enforcing rules on tests,
these are a few minor changes that are still worth making.
Issue: SPR-16968
8 years ago
Juergen Hoeller
ac1e2a4598
Consistent SpelEvaluationException messages in findAccessorForMethod
...
Includes abstract declarations for FormatHelper and ReflectionHelper.
Issue: SPR-16762
8 years ago
Juergen Hoeller
d4a55a257b
OperatorMatches flags misguided evaluation attempts as FLAWED_PATTERN
...
Issue: SPR-16731
8 years ago
Juergen Hoeller
b2d87abcbb
Polishing
8 years ago
Juergen Hoeller
c60cefa331
SimpleEvaluationContext.Builder withRootObject/withTypedRootObject
...
Issue: SPR-16588
8 years ago
Juergen Hoeller
9128226da4
SimpleEvaluationContext.Builder withMethodResolvers/withInstanceMethods
...
Includes DataBindingMethodResolver as ReflectiveMethodResolver subclass.
Issue: SPR-16588
8 years ago
Juergen Hoeller
51c57d77d9
SimpleEvaluationContext with dedicated factory methods for common cases
...
Aligned with DataBindingPropertyAccessor and shown in ref doc examples.
Issue: SPR-16588
8 years ago
Juergen Hoeller
b5511645b8
DataBindingPropertyAccessor with factory methods (forReadOnlyAccess etc)
...
Includes configurable write support at ReflectivePropertyAccessor level.
Issue: SPR-16588
8 years ago
Juergen Hoeller
c1405ef140
Polishing
8 years ago
Juergen Hoeller
639d2c6fe7
Polishing
8 years ago
Juergen Hoeller
1fd5935afa
SimplePropertyAccessor with configurable write support
...
Issue: SPR-16588
8 years ago
Andy Clement
1db7e02de3
Modify SpEL code gen to take account of null safe refs
...
With this change the code generation for method and property
references is modified to include branching logic in the
case of null safe dereferencing (?.). This is complicated
by the possible usage of primitives on the left hand side
of the dereference. To cope with this case primitives are
promoted to boxed types when this situation occurs enabling
null to be passed as a possible result.
Issue: SPR-16489
8 years ago
Juergen Hoeller
c543368aad
Polishing
8 years ago
igor-suhorukov
06fef1e5a4
Polish: assertion arguments should be passed in the correct order
8 years ago
Juergen Hoeller
fa670dd07d
Indexer enforces target descriptor only after non-null target check
...
Issue: SPR-16544
8 years ago
Juergen Hoeller
3b810f3544
Consistent Class array vs vararg declarations (and related polishing)
8 years ago
Juergen Hoeller
d5cabca2f7
Internal adaptation to Deque semantics
8 years ago
Juergen Hoeller
b5bd977d9a
Revised assertion refactoring in AbstractExpressionTests
8 years ago
igor-suhorukov
0ee505b73e
Polish: assertion arguments should be passed in the correct order,
...
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
8 years ago
Juergen Hoeller
4a57e26d76
Polishing
8 years ago
Juergen Hoeller
c30145d6f9
MethodReference treats proxy-targeting expressions as non-compilable
...
Issue: SPR-16191
8 years ago
Juergen Hoeller
78284a62e2
Polishing
8 years ago
Juergen Hoeller
419b4440a7
Introspect interface-declared methods in case of proxy (for varargs)
...
Issue: SPR-16122
8 years ago
Juergen Hoeller
fd6f2bd6a4
Test for null value against boolean property
...
Issue: SPR-16123
8 years ago
Juergen Hoeller
03b68286a2
Tokenizer uses single process step and length-based exhaustion check
...
Issue: SPR-16032
8 years ago
Juergen Hoeller
7ae59d0c2a
Nullability refinements on private and static methods
...
Based on IntelliJ IDEA 2017.3 introspection results.
Issue: SPR-15756
8 years ago
Juergen Hoeller
efc5b47b9a
Polishing
9 years ago
Juergen Hoeller
1ad6180019
Expression javadoc alignment
9 years ago