From f481f99516715422558de5e2433ef3983751f290 Mon Sep 17 00:00:00 2001 From: Sam Brannen <104798+sbrannen@users.noreply.github.com> Date: Thu, 26 Feb 2026 12:02:38 +0100 Subject: [PATCH] Avoid unnecessary List and Stream creation See gh-36390 --- .../support/AbstractTestContextBootstrapper.java | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/spring-test/src/main/java/org/springframework/test/context/support/AbstractTestContextBootstrapper.java b/spring-test/src/main/java/org/springframework/test/context/support/AbstractTestContextBootstrapper.java index 2c592082d75..ede931cd3f4 100644 --- a/spring-test/src/main/java/org/springframework/test/context/support/AbstractTestContextBootstrapper.java +++ b/spring-test/src/main/java/org/springframework/test/context/support/AbstractTestContextBootstrapper.java @@ -298,15 +298,18 @@ public abstract class AbstractTestContextBootstrapper implements TestContextBoot https://docs.spring.io/spring-framework/reference/testing/testcontext-framework/ctx-management/default-config.html"""; Set> currentClasses = new HashSet<>(Arrays.asList(mergedConfig.getClasses())); - List> ignoredClasses = Arrays.stream(completeMergedConfig.getClasses()) - .filter(clazz -> !currentClasses.contains(clazz)).toList(); + String ignoredClasses = Arrays.stream(completeMergedConfig.getClasses()) + .filter(clazz -> !currentClasses.contains(clazz)) + .map(Class::getName) + .collect(Collectors.joining(", ")); if (!ignoredClasses.isEmpty()) { - logger.warn(warningMessage.formatted(testClass.getName(), "classes", names(ignoredClasses))); + logger.warn(warningMessage.formatted(testClass.getName(), "classes", ignoredClasses)); } Set currentLocations = new HashSet<>(Arrays.asList(mergedConfig.getLocations())); String ignoredLocations = Arrays.stream(completeMergedConfig.getLocations()) - .filter(location -> !currentLocations.contains(location)).collect(Collectors.joining(", ")); + .filter(location -> !currentLocations.contains(location)) + .collect(Collectors.joining(", ")); if (!ignoredLocations.isEmpty()) { logger.warn(warningMessage.formatted(testClass.getName(), "locations", ignoredLocations)); } @@ -663,10 +666,6 @@ public abstract class AbstractTestContextBootstrapper implements TestContextBoot } - private static String names(Collection> classes) { - return classes.stream().map(Class::getName).collect(Collectors.joining(", ")); - } - private static List classSimpleNames(Collection components) { return components.stream().map(Object::getClass).map(Class::getSimpleName).toList(); }