From eb01cc0d9dd5766422a56d297e176e37dde71093 Mon Sep 17 00:00:00 2001 From: ali dandach Date: Tue, 5 Mar 2024 15:11:06 +0200 Subject: [PATCH] Use String#isEmpty where feasible This commit replaces checks for empty strings ("".equals(...)) with the String#isEmpty method. Closes gh-32377 --- .../main/java/org/springframework/cglib/core/EmitUtils.java | 4 ++-- .../main/java/org/springframework/cglib/core/TypeUtils.java | 2 +- .../src/main/java/org/springframework/util/StringUtils.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spring-core/src/main/java/org/springframework/cglib/core/EmitUtils.java b/spring-core/src/main/java/org/springframework/cglib/core/EmitUtils.java index c1e157b7228..1ff41efbba4 100644 --- a/spring-core/src/main/java/org/springframework/cglib/core/EmitUtils.java +++ b/spring-core/src/main/java/org/springframework/cglib/core/EmitUtils.java @@ -653,14 +653,14 @@ public class EmitUtils { e.dup(); e.ifnull(skip); e.swap(); - if (delims != null && delims.before != null && !"".equals(delims.before)) { + if (delims != null && delims.before != null && !delims.before.isEmpty()) { e.push(delims.before); e.invoke_virtual(Constants.TYPE_STRING_BUFFER, APPEND_STRING); e.swap(); } EmitUtils.process_array(e, type, callback); shrinkStringBuffer(e, 2); - if (delims != null && delims.after != null && !"".equals(delims.after)) { + if (delims != null && delims.after != null && !delims.after.isEmpty()) { e.push(delims.after); e.invoke_virtual(Constants.TYPE_STRING_BUFFER, APPEND_STRING); } diff --git a/spring-core/src/main/java/org/springframework/cglib/core/TypeUtils.java b/spring-core/src/main/java/org/springframework/cglib/core/TypeUtils.java index 8d860cc80f3..de0f693146e 100644 --- a/spring-core/src/main/java/org/springframework/cglib/core/TypeUtils.java +++ b/spring-core/src/main/java/org/springframework/cglib/core/TypeUtils.java @@ -230,7 +230,7 @@ public class TypeUtils { } private static String map(String type) { - if (type.equals("")) { + if (type.isEmpty()) { return type; } String t = (String)transforms.get(type); diff --git a/spring-core/src/main/java/org/springframework/util/StringUtils.java b/spring-core/src/main/java/org/springframework/util/StringUtils.java index 764a8ff2697..9394b6836c0 100644 --- a/spring-core/src/main/java/org/springframework/util/StringUtils.java +++ b/spring-core/src/main/java/org/springframework/util/StringUtils.java @@ -877,7 +877,7 @@ public abstract class StringUtils { @SuppressWarnings("deprecation") // for Locale constructors on JDK 19 @Nullable public static Locale parseLocaleString(String localeString) { - if (localeString.equals("")) { + if (localeString.isEmpty()) { return null; }