diff --git a/spring-aop/src/main/java/org/springframework/aop/ProxyMethodInvocation.java b/spring-aop/src/main/java/org/springframework/aop/ProxyMethodInvocation.java index 55711edfeab..ea9838dd247 100644 --- a/spring-aop/src/main/java/org/springframework/aop/ProxyMethodInvocation.java +++ b/spring-aop/src/main/java/org/springframework/aop/ProxyMethodInvocation.java @@ -61,7 +61,7 @@ public interface ProxyMethodInvocation extends MethodInvocation { MethodInvocation invocableClone(@Nullable Object... arguments); /** - * Set the arguments to be used on subsequent invocations in the any advice + * Set the arguments to be used on subsequent invocations in any advice * in this chain. * @param arguments the argument array */ diff --git a/spring-core/src/main/java/org/springframework/util/ConcurrentReferenceHashMap.java b/spring-core/src/main/java/org/springframework/util/ConcurrentReferenceHashMap.java index 9431524891d..e20693118c3 100644 --- a/spring-core/src/main/java/org/springframework/util/ConcurrentReferenceHashMap.java +++ b/spring-core/src/main/java/org/springframework/util/ConcurrentReferenceHashMap.java @@ -609,7 +609,7 @@ public class ConcurrentReferenceHashMap extends AbstractMap implemen * @param task the update operation * @return the result of the operation */ - public @Nullable T doTask(final int hash, final @Nullable Object key, final Task task) { + private @Nullable T doTask(final int hash, final @Nullable Object key, final Task task) { boolean resize = task.hasOption(TaskOption.RESIZE); if (task.hasOption(TaskOption.RESTRUCTURE_BEFORE)) { restructureIfNecessary(resize); @@ -674,7 +674,6 @@ public class ConcurrentReferenceHashMap extends AbstractMap implemen } private void restructure(boolean allowResize, @Nullable Reference ref) { - boolean needsResize; lock(); try { int expectedCount = this.count.get(); @@ -690,7 +689,7 @@ public class ConcurrentReferenceHashMap extends AbstractMap implemen // Estimate new count, taking into account count inside lock and items that // will be purged. - needsResize = (expectedCount > 0 && expectedCount >= this.resizeThreshold); + boolean needsResize = (expectedCount > 0 && expectedCount >= this.resizeThreshold); boolean resizing = false; int restructureSize = this.references.length; if (allowResize && needsResize && restructureSize < MAXIMUM_SEGMENT_SIZE) { @@ -731,8 +730,8 @@ public class ConcurrentReferenceHashMap extends AbstractMap implemen while (ref != null) { if (!toPurge.contains(ref)) { Entry entry = ref.get(); - // Also filter out null references that are now null - // they should be polled from the queue in a later restructure call. + // Also filter out null references that are now null: + // They should be polled from the queue in a later restructure call. if (entry != null) { purgedRef = this.referenceManager.createReference( entry, ref.getHash(), purgedRef); @@ -744,7 +743,7 @@ public class ConcurrentReferenceHashMap extends AbstractMap implemen this.references[i] = purgedRef; } } - this.count.set(Math.max(newCount, 0)); + this.count.set(newCount); } finally { unlock();