Browse Source

GenericTypeResolver properly handles bound parameterized type

Issue: SPR-10819
pull/340/head
Juergen Hoeller 13 years ago
parent
commit
ea6525f15f
  1. 7
      spring-core/src/main/java/org/springframework/core/GenericTypeResolver.java
  2. 17
      spring-core/src/test/java/org/springframework/core/GenericTypeResolverTests.java

7
spring-core/src/main/java/org/springframework/core/GenericTypeResolver.java

@ -305,7 +305,7 @@ public abstract class GenericTypeResolver { @@ -305,7 +305,7 @@ public abstract class GenericTypeResolver {
}
/**
* Extract a class instance from given Type.
* Extract a Class from the given Type.
*/
private static Class<?> extractClass(Class<?> ownerClass, Type arg) {
if (arg instanceof ParameterizedType) {
@ -322,9 +322,12 @@ public abstract class GenericTypeResolver { @@ -322,9 +322,12 @@ public abstract class GenericTypeResolver {
arg = getTypeVariableMap(ownerClass).get(tv);
if (arg == null) {
arg = extractBoundForTypeVariable(tv);
if (arg instanceof ParameterizedType) {
return extractClass(ownerClass, ((ParameterizedType) arg).getRawType());
}
}
else {
arg = extractClass(ownerClass, arg);
return extractClass(ownerClass, arg);
}
}
return (arg instanceof Class ? (Class) arg : Object.class);

17
spring-core/src/test/java/org/springframework/core/GenericTypeResolverTests.java

@ -19,7 +19,6 @@ package org.springframework.core; @@ -19,7 +19,6 @@ package org.springframework.core;
import java.lang.reflect.Method;
import java.lang.reflect.Type;
import java.lang.reflect.TypeVariable;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
@ -27,7 +26,6 @@ import java.util.Map; @@ -27,7 +26,6 @@ import java.util.Map;
import org.junit.Test;
import static org.junit.Assert.*;
import static org.springframework.core.GenericTypeResolver.*;
import static org.springframework.util.ReflectionUtils.*;
@ -79,7 +77,6 @@ public class GenericTypeResolverTests { @@ -79,7 +77,6 @@ public class GenericTypeResolverTests {
*/
@Test
public void genericMethodReturnTypes() {
Method notParameterized = findMethod(MyTypeWithMethods.class, "notParameterized", new Class[] {});
assertEquals(String.class, resolveReturnTypeForGenericMethod(notParameterized, new Object[] {}));
@ -156,6 +153,11 @@ public class GenericTypeResolverTests { @@ -156,6 +153,11 @@ public class GenericTypeResolverTests {
assertEquals(Integer[].class, resolveType(genericArrMessageMethodParam.getGenericParameterType(), varMap));
}
@Test
public void testBoundParameterizedType() {
assertEquals(B.class, resolveTypeArgument(TestImpl.class, ITest.class));
}
public interface MyInterfaceType<T> {
}
@ -273,4 +275,13 @@ public class GenericTypeResolverTests { @@ -273,4 +275,13 @@ public class GenericTypeResolverTests {
static class GenericClass<T> {
}
class A{}
class B<T>{}
class ITest<T>{}
class TestImpl<I extends A, T extends B<I>> extends ITest<T>{
}
}

Loading…
Cancel
Save