Browse Source

@MessageExceptionHandler matches cause as well (analogous to @ExceptionHandler)

Issue: SPR-14424
pull/1104/head
Juergen Hoeller 10 years ago
parent
commit
e5de7d5455
  1. 33
      spring-messaging/src/main/java/org/springframework/messaging/handler/invocation/AbstractExceptionHandlerMethodResolver.java
  2. 18
      spring-messaging/src/test/java/org/springframework/messaging/handler/annotation/support/AnnotationExceptionHandlerMethodResolverTests.java

33
spring-messaging/src/main/java/org/springframework/messaging/handler/invocation/AbstractExceptionHandlerMethodResolver.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2013 the original author or authors. * Copyright 2002-2016 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -33,6 +33,7 @@ import org.springframework.util.ClassUtils;
* {@link ExceptionDepthComparator} and the top match is returned. * {@link ExceptionDepthComparator} and the top match is returned.
* *
* @author Rossen Stoyanchev * @author Rossen Stoyanchev
* @author Juergen Hoeller
* @since 4.0 * @since 4.0
*/ */
public abstract class AbstractExceptionHandlerMethodResolver { public abstract class AbstractExceptionHandlerMethodResolver {
@ -69,6 +70,7 @@ public abstract class AbstractExceptionHandlerMethodResolver {
return result; return result;
} }
/** /**
* Whether the contained type has any exception mappings. * Whether the contained type has any exception mappings.
*/ */
@ -77,13 +79,30 @@ public abstract class AbstractExceptionHandlerMethodResolver {
} }
/** /**
* Find a method to handle the given exception. * Find a {@link Method} to handle the given exception.
* Use {@link org.springframework.core.ExceptionDepthComparator} if more than one match is found. * Use {@link ExceptionDepthComparator} if more than one match is found.
* @param exception the exception * @param exception the exception
* @return a method to handle the exception or {@code null} * @return a Method to handle the exception, or {@code null} if none found
*/ */
public Method resolveMethod(Exception exception) { public Method resolveMethod(Exception exception) {
Class<? extends Exception> exceptionType = exception.getClass(); Method method = resolveMethodByExceptionType(exception.getClass());
if (method == null) {
Throwable cause = exception.getCause();
if (cause != null) {
method = resolveMethodByExceptionType(cause.getClass());
}
}
return method;
}
/**
* Find a {@link Method} to handle the given exception type. This can be
* useful if an {@link Exception} instance is not available (e.g. for tools).
* @param exceptionType the exception type
* @return a Method to handle the exception, or {@code null} if none found
* @since 4.3.1
*/
public Method resolveMethodByExceptionType(Class<? extends Throwable> exceptionType) {
Method method = this.exceptionLookupCache.get(exceptionType); Method method = this.exceptionLookupCache.get(exceptionType);
if (method == null) { if (method == null) {
method = getMappedMethod(exceptionType); method = getMappedMethod(exceptionType);
@ -93,9 +112,9 @@ public abstract class AbstractExceptionHandlerMethodResolver {
} }
/** /**
* Return the method mapped to the given exception type or {@code null}. * Return the {@link Method} mapped to the given exception type, or {@code null} if none.
*/ */
private Method getMappedMethod(Class<? extends Exception> exceptionType) { private Method getMappedMethod(Class<? extends Throwable> exceptionType) {
List<Class<? extends Throwable>> matches = new ArrayList<Class<? extends Throwable>>(); List<Class<? extends Throwable>> matches = new ArrayList<Class<? extends Throwable>>();
for (Class<? extends Throwable> mappedException : this.mappedMethods.keySet()) { for (Class<? extends Throwable> mappedException : this.mappedMethods.keySet()) {
if (mappedException.isAssignableFrom(exceptionType)) { if (mappedException.isAssignableFrom(exceptionType)) {

18
spring-messaging/src/test/java/org/springframework/messaging/handler/annotation/support/AnnotationExceptionHandlerMethodResolverTests.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2013 the original author or authors. * Copyright 2002-2016 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -33,6 +33,7 @@ import static org.junit.Assert.*;
* Test fixture for {@link AnnotationExceptionHandlerMethodResolver} tests. * Test fixture for {@link AnnotationExceptionHandlerMethodResolver} tests.
* *
* @author Rossen Stoyanchev * @author Rossen Stoyanchev
* @author Juergen Hoeller
*/ */
public class AnnotationExceptionHandlerMethodResolverTests { public class AnnotationExceptionHandlerMethodResolverTests {
@ -50,6 +51,13 @@ public class AnnotationExceptionHandlerMethodResolverTests {
assertEquals("handleIllegalArgumentException", resolver.resolveMethod(exception).getName()); assertEquals("handleIllegalArgumentException", resolver.resolveMethod(exception).getName());
} }
@Test
public void resolveMethodFromArgumentWithErrorType() {
AnnotationExceptionHandlerMethodResolver resolver = new AnnotationExceptionHandlerMethodResolver(ExceptionController.class);
AssertionError exception = new AssertionError();
assertEquals("handleAssertionError", resolver.resolveMethod(new IllegalStateException(exception)).getName());
}
@Test @Test
public void resolveMethodExceptionSubType() { public void resolveMethodExceptionSubType() {
AnnotationExceptionHandlerMethodResolver resolver = new AnnotationExceptionHandlerMethodResolver(ExceptionController.class); AnnotationExceptionHandlerMethodResolver resolver = new AnnotationExceptionHandlerMethodResolver(ExceptionController.class);
@ -91,6 +99,7 @@ public class AnnotationExceptionHandlerMethodResolverTests {
new AnnotationExceptionHandlerMethodResolver(NoExceptionController.class); new AnnotationExceptionHandlerMethodResolver(NoExceptionController.class);
} }
@Controller @Controller
static class ExceptionController { static class ExceptionController {
@ -107,8 +116,13 @@ public class AnnotationExceptionHandlerMethodResolverTests {
@MessageExceptionHandler @MessageExceptionHandler
public void handleIllegalArgumentException(IllegalArgumentException exception) { public void handleIllegalArgumentException(IllegalArgumentException exception) {
} }
@MessageExceptionHandler
public void handleAssertionError(AssertionError exception) {
}
} }
@Controller @Controller
static class InheritedController extends ExceptionController { static class InheritedController extends ExceptionController {
@ -117,6 +131,7 @@ public class AnnotationExceptionHandlerMethodResolverTests {
} }
} }
@Controller @Controller
static class AmbiguousController { static class AmbiguousController {
@ -133,6 +148,7 @@ public class AnnotationExceptionHandlerMethodResolverTests {
} }
} }
@Controller @Controller
static class NoExceptionController { static class NoExceptionController {

Loading…
Cancel
Save